You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/07/28 17:48:57 UTC

[GitHub] [kafka] cadonna opened a new pull request, #12454: MINOR: Fix static mock usage in ThreadMetricsTest

cadonna opened a new pull request, #12454:
URL: https://github.com/apache/kafka/pull/12454

   Before this PR the calls to the static methods on
   StreamsMetricsImpl were just calls and not a verification
   on the mock. This miss happened during the switch from
   EasyMock to Mockito.
   
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] guozhangwang commented on pull request #12454: MINOR: Fix static mock usage in ThreadMetricsTest

Posted by GitBox <gi...@apache.org>.

guozhangwang commented on PR #12454:
URL: https://github.com/apache/kafka/pull/12454#issuecomment-1198602885

   ```
   SocketServerTest.testConnectionIdReuse()
   ```
   
   LGTM. Test failures are irrelevant. Merging to trunk now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] guozhangwang merged pull request #12454: MINOR: Fix static mock usage in ThreadMetricsTest

Posted by GitBox <gi...@apache.org>.

guozhangwang merged PR #12454:
URL: https://github.com/apache/kafka/pull/12454


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org