[jira] [Commented] (ACCUMULO-2208) Unable to cleanly close log...

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ACCUMULO-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13873634#comment-13873634 ] 

ASF subversion and git services commented on ACCUMULO-2208:
-----------------------------------------------------------

Commit fe1348fd0087c85f116d50c4abe09215a893766f in branch refs/heads/1.5.1-SNAPSHOT from [~vines]
[ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=fe1348f ]

ACCUMULO-2208 Provides better error message in case this happens again


> Unable to cleanly close log...
> ------------------------------
>
>                 Key: ACCUMULO-2208
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2208
>             Project: Accumulo
>          Issue Type: Bug
>          Components: tserver
>    Affects Versions: 1.5.0
>            Reporter: John Vines
>
> I saw this once over 36 tserver/days, caused by an InvalidArgumentException, so odd occurrence. It was doing CI but before agitation started so it was a non issue, but it could be. The code around this is
> {code}for (DfsLogger logger : loggers) {
>         try {
>           logger.close();
>         } catch (DfsLogger.LogClosedException ex) {
>           // ignore
>         } catch (Throwable ex) {
>           log.error("Unable to cleanly close log " + logger.getFileName() + ": " + ex);
>         }
>       }
>       loggers.clear();
>       logSizeEstimate.set(0);{code}
> so it seems like it blindly powered forward. However, because of the frequency of syncs and such, even if there was agitation the odds of losing data are very minute, but I do believe their still there.
> But  because the log message just relies on error.toString, I didn't get the violating stack trace. At the bare minimum, the message should be updated to log the full stack trace.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)