You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by "Simone Tripodi (JIRA)" <ji...@apache.org> on 2012/07/19 08:51:34 UTC

[jira] [Commented] (VFS-429) Remove extra FileSystem ivar in AbstractFileObject subclasses with generics

    [ https://issues.apache.org/jira/browse/VFS-429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13418120#comment-13418120 ] 

Simone Tripodi commented on VFS-429:
------------------------------------

+1

even if I am not familiar with VFS codebase, the feedback I can provide you as a potential user is that the patch shows a very clear and comprensive code cleanup.

If it breaks the backward compatibility, don't stop and go for a major release :)

well done!
                
> Remove extra FileSystem ivar in AbstractFileObject subclasses with generics
> ---------------------------------------------------------------------------
>
>                 Key: VFS-429
>                 URL: https://issues.apache.org/jira/browse/VFS-429
>             Project: Commons VFS
>          Issue Type: Improvement
>    Affects Versions: 2.0
>            Reporter: Gary D. Gregory
>         Attachments: vfs-afs.diff
>
>
> Most AbstractFileObject subclasses track a FileSystem instance in an ivar typed for that provider (FtpFileSystem for example).
> This can be cleaned up nicely with generics.
> Thoughts for or against?
> Here is an attachment that shows how this would work for FTP.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira