You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "Adam Fuchs (JIRA)" <ji...@apache.org> on 2012/10/09 16:37:02 UTC
[jira] [Created] (ACCUMULO-794) FirstEntryInRowIterator can scan
through entire last row in range
Adam Fuchs created ACCUMULO-794:
-----------------------------------
Summary: FirstEntryInRowIterator can scan through entire last row in range
Key: ACCUMULO-794
URL: https://issues.apache.org/jira/browse/ACCUMULO-794
Project: Accumulo
Issue Type: Bug
Components: client
Affects Versions: 1.4.1
Reporter: Adam Fuchs
Assignee: Billie Rinaldi
Fix For: 1.5.0, 1.4.2
If the range passed to the FirstEntryInRowIterator is seeked with a Range that has an end key, the FirstEntryInRowIterator will scan through all of the entries in the last row that match the range. This is due to a logic bug -- the if statement on line 93 needs an else clause.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (ACCUMULO-794) FirstEntryInRowIterator can scan
through entire last row in range
Posted by "Adam Fuchs (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACCUMULO-794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adam Fuchs resolved ACCUMULO-794.
---------------------------------
Resolution: Fixed
Assignee: Adam Fuchs (was: Billie Rinaldi)
> FirstEntryInRowIterator can scan through entire last row in range
> -----------------------------------------------------------------
>
> Key: ACCUMULO-794
> URL: https://issues.apache.org/jira/browse/ACCUMULO-794
> Project: Accumulo
> Issue Type: Bug
> Components: client
> Affects Versions: 1.4.1
> Reporter: Adam Fuchs
> Assignee: Adam Fuchs
> Fix For: 1.5.0, 1.4.2
>
>
> If the range passed to the FirstEntryInRowIterator is seeked with a Range that has an end key, the FirstEntryInRowIterator will scan through all of the entries in the last row that match the range. This is due to a logic bug -- the if statement on line 93 needs an else clause.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (ACCUMULO-794) FirstEntryInRowIterator can scan
through entire last row in range
Posted by "Adam Fuchs (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACCUMULO-794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adam Fuchs closed ACCUMULO-794.
-------------------------------
> FirstEntryInRowIterator can scan through entire last row in range
> -----------------------------------------------------------------
>
> Key: ACCUMULO-794
> URL: https://issues.apache.org/jira/browse/ACCUMULO-794
> Project: Accumulo
> Issue Type: Bug
> Components: client
> Affects Versions: 1.4.1
> Reporter: Adam Fuchs
> Assignee: Adam Fuchs
> Fix For: 1.5.0, 1.4.2
>
>
> If the range passed to the FirstEntryInRowIterator is seeked with a Range that has an end key, the FirstEntryInRowIterator will scan through all of the entries in the last row that match the range. This is due to a logic bug -- the if statement on line 93 needs an else clause.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ACCUMULO-794) FirstEntryInRowIterator can scan
through entire last row in range
Posted by "Keith Turner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACCUMULO-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472685#comment-13472685 ]
Keith Turner commented on ACCUMULO-794:
---------------------------------------
Might have been worthwhile to create a unit test that reproduces the bug in the iterator.
> FirstEntryInRowIterator can scan through entire last row in range
> -----------------------------------------------------------------
>
> Key: ACCUMULO-794
> URL: https://issues.apache.org/jira/browse/ACCUMULO-794
> Project: Accumulo
> Issue Type: Bug
> Components: client
> Affects Versions: 1.4.1
> Reporter: Adam Fuchs
> Assignee: Adam Fuchs
> Fix For: 1.5.0, 1.4.2
>
>
> If the range passed to the FirstEntryInRowIterator is seeked with a Range that has an end key, the FirstEntryInRowIterator will scan through all of the entries in the last row that match the range. This is due to a logic bug -- the if statement on line 93 needs an else clause.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ACCUMULO-794) FirstEntryInRowIterator can scan
through entire last row in range
Posted by "Adam Fuchs (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACCUMULO-794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adam Fuchs updated ACCUMULO-794:
--------------------------------
Status: Reopened (was: Closed)
> FirstEntryInRowIterator can scan through entire last row in range
> -----------------------------------------------------------------
>
> Key: ACCUMULO-794
> URL: https://issues.apache.org/jira/browse/ACCUMULO-794
> Project: Accumulo
> Issue Type: Bug
> Components: client
> Affects Versions: 1.4.1
> Reporter: Adam Fuchs
> Assignee: Adam Fuchs
> Fix For: 1.5.0, 1.4.2
>
>
> If the range passed to the FirstEntryInRowIterator is seeked with a Range that has an end key, the FirstEntryInRowIterator will scan through all of the entries in the last row that match the range. This is due to a logic bug -- the if statement on line 93 needs an else clause.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (ACCUMULO-794) FirstEntryInRowIterator can scan
through entire last row in range
Posted by "Adam Fuchs (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACCUMULO-794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adam Fuchs closed ACCUMULO-794.
-------------------------------
> FirstEntryInRowIterator can scan through entire last row in range
> -----------------------------------------------------------------
>
> Key: ACCUMULO-794
> URL: https://issues.apache.org/jira/browse/ACCUMULO-794
> Project: Accumulo
> Issue Type: Bug
> Components: client
> Affects Versions: 1.4.1
> Reporter: Adam Fuchs
> Assignee: Adam Fuchs
> Fix For: 1.5.0, 1.4.2
>
>
> If the range passed to the FirstEntryInRowIterator is seeked with a Range that has an end key, the FirstEntryInRowIterator will scan through all of the entries in the last row that match the range. This is due to a logic bug -- the if statement on line 93 needs an else clause.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ACCUMULO-794) FirstEntryInRowIterator can scan
through entire last row in range
Posted by "Adam Fuchs (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACCUMULO-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472693#comment-13472693 ]
Adam Fuchs commented on ACCUMULO-794:
-------------------------------------
I was thinking that would be non-trivial since this is a performance issue and not a correctness issue. However, I suppose one could write a source iterator that complains if next is called too many times in one row before seek is called. Still seems like more trouble than it's worth.
> FirstEntryInRowIterator can scan through entire last row in range
> -----------------------------------------------------------------
>
> Key: ACCUMULO-794
> URL: https://issues.apache.org/jira/browse/ACCUMULO-794
> Project: Accumulo
> Issue Type: Bug
> Components: client
> Affects Versions: 1.4.1
> Reporter: Adam Fuchs
> Assignee: Adam Fuchs
> Fix For: 1.5.0, 1.4.2
>
>
> If the range passed to the FirstEntryInRowIterator is seeked with a Range that has an end key, the FirstEntryInRowIterator will scan through all of the entries in the last row that match the range. This is due to a logic bug -- the if statement on line 93 needs an else clause.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ACCUMULO-794) FirstEntryInRowIterator can scan
through entire last row in range
Posted by "Billie Rinaldi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACCUMULO-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473168#comment-13473168 ]
Billie Rinaldi commented on ACCUMULO-794:
-----------------------------------------
You could use the CountingIterator (or some variation thereof) as the source of the FirstEntryInRowIterator, wrapping your test source. That would tell you how many times next() is called.
> FirstEntryInRowIterator can scan through entire last row in range
> -----------------------------------------------------------------
>
> Key: ACCUMULO-794
> URL: https://issues.apache.org/jira/browse/ACCUMULO-794
> Project: Accumulo
> Issue Type: Bug
> Components: client
> Affects Versions: 1.4.1
> Reporter: Adam Fuchs
> Assignee: Adam Fuchs
> Fix For: 1.5.0, 1.4.2
>
>
> If the range passed to the FirstEntryInRowIterator is seeked with a Range that has an end key, the FirstEntryInRowIterator will scan through all of the entries in the last row that match the range. This is due to a logic bug -- the if statement on line 93 needs an else clause.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (ACCUMULO-794) FirstEntryInRowIterator can scan
through entire last row in range
Posted by "Adam Fuchs (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACCUMULO-794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adam Fuchs resolved ACCUMULO-794.
---------------------------------
unit test added by popular demand
> FirstEntryInRowIterator can scan through entire last row in range
> -----------------------------------------------------------------
>
> Key: ACCUMULO-794
> URL: https://issues.apache.org/jira/browse/ACCUMULO-794
> Project: Accumulo
> Issue Type: Bug
> Components: client
> Affects Versions: 1.4.1
> Reporter: Adam Fuchs
> Assignee: Adam Fuchs
> Fix For: 1.5.0, 1.4.2
>
>
> If the range passed to the FirstEntryInRowIterator is seeked with a Range that has an end key, the FirstEntryInRowIterator will scan through all of the entries in the last row that match the range. This is due to a logic bug -- the if statement on line 93 needs an else clause.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ACCUMULO-794) FirstEntryInRowIterator can scan
through entire last row in range
Posted by "Adam Fuchs (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACCUMULO-794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adam Fuchs updated ACCUMULO-794:
--------------------------------
Status: Reopened (was: Reopened)
> FirstEntryInRowIterator can scan through entire last row in range
> -----------------------------------------------------------------
>
> Key: ACCUMULO-794
> URL: https://issues.apache.org/jira/browse/ACCUMULO-794
> Project: Accumulo
> Issue Type: Bug
> Components: client
> Affects Versions: 1.4.1
> Reporter: Adam Fuchs
> Assignee: Adam Fuchs
> Fix For: 1.5.0, 1.4.2
>
>
> If the range passed to the FirstEntryInRowIterator is seeked with a Range that has an end key, the FirstEntryInRowIterator will scan through all of the entries in the last row that match the range. This is due to a logic bug -- the if statement on line 93 needs an else clause.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ACCUMULO-794) FirstEntryInRowIterator can scan
through entire last row in range
Posted by "Keith Turner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACCUMULO-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473311#comment-13473311 ]
Keith Turner commented on ACCUMULO-794:
---------------------------------------
bq. I was thinking that would be non-trivial since this is a performance issue and not a correctness issue. However, I suppose one could write a source iterator that complains if next is called too many times in one row before seek is called. Still seems like more trouble than it's worth.
I agree. I did not realize it was just a performance issue. I was not paying close attention. I took a quick look at the bug and thought the iterator was returning more data than it should. That do being said, I do like Billie's suggestion. More test never hurt. Well, as long as they complete in a reasonable amount of time.
> FirstEntryInRowIterator can scan through entire last row in range
> -----------------------------------------------------------------
>
> Key: ACCUMULO-794
> URL: https://issues.apache.org/jira/browse/ACCUMULO-794
> Project: Accumulo
> Issue Type: Bug
> Components: client
> Affects Versions: 1.4.1
> Reporter: Adam Fuchs
> Assignee: Adam Fuchs
> Fix For: 1.5.0, 1.4.2
>
>
> If the range passed to the FirstEntryInRowIterator is seeked with a Range that has an end key, the FirstEntryInRowIterator will scan through all of the entries in the last row that match the range. This is due to a logic bug -- the if statement on line 93 needs an else clause.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira