You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "OleksiienkoMykyta (via GitHub)" <gi...@apache.org> on 2024/09/19 12:16:27 UTC

[PR] Marshal big int returns variable length slice [cassandra-gocql-driver]

OleksiienkoMykyta opened a new pull request, #1823:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1823

   Closes #1740
   Currently, gocql supports arbitrary-precision type big.Int, but in Cassandra the bigint is implemented as an eight-byte two's complement integer (see [Data Type Serialization Formats](https://cassandra.apache.org/_/native_protocol.html)).
   Fixed this issue in the PR, and added a few tests to cover changes. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

Re: [PR] CASSGO-2 Marshal big int returns variable length slice [cassandra-gocql-driver]

Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis commented on PR #1823:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1823#issuecomment-2473838363

   > How could I get one more committer's approval?
   
   I've been trying to call out on the #cassandra-drivers ASF slack channel that we need another committer to look at these PRs but so far I haven't been successful. You could try reaching out to committers directly too.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

Re: [PR] CASSGO-2 Marshal big int returns variable length slice [cassandra-gocql-driver]

Posted by "OleksiienkoMykyta (via GitHub)" <gi...@apache.org>.
OleksiienkoMykyta commented on PR #1823:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1823#issuecomment-2478750292

   
   
   
   
   > > How could I get one more committer's approval?
   > 
   > I've been trying to call out on the #[cassandra-drivers](https://issues.apache.org/jira/browse/CASSANDRA-drivers) ASF slack channel that we need another committer to look at these PRs but so far I haven't been successful. You could try reaching out to committers directly too.
   
   Thank you very much!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

Re: [PR] CASSGO-2 Marshal big int returns variable length slice [cassandra-gocql-driver]

Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis commented on PR #1823:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1823#issuecomment-2622010631

   Can you add @jameshartig as a reviewer to the commit message?  I'll merge this afterwards


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

Re: [PR] CASSGO-2 Marshal big int returns variable length slice [cassandra-gocql-driver]

Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis commented on PR #1823:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1823#issuecomment-2473856480

   It looks like some unit tests are failing


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

Re: [PR] CASSGO-2 Marshal big int returns variable length slice [cassandra-gocql-driver]

Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis merged PR #1823:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1823


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

Re: [PR] CASSGO-2 Marshal big int returns variable length slice [cassandra-gocql-driver]

Posted by "jameshartig (via GitHub)" <gi...@apache.org>.
jameshartig commented on PR #1823:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1823#issuecomment-2563295479

   @OleksiienkoMykyta can you fix the conflicts?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

Re: [PR] CASSGO-2 Marshal big int returns variable length slice [cassandra-gocql-driver]

Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis commented on PR #1823:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1823#issuecomment-2470884251

   Please squash and format your commit message following the rules stated in [CONTRIBUTING.md](https://github.com/apache/cassandra-gocql-driver/blob/trunk/CONTRIBUTING.md#commit-message) and add this JIRA to the `CHANGELOG.md` in the `Fixed` section of `Unreleased`, thanks!
   
   We need another committer +1 to merge this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

Re: [PR] CASSGO-2 Marshal big int returns variable length slice [cassandra-gocql-driver]

Posted by "OleksiienkoMykyta (via GitHub)" <gi...@apache.org>.
OleksiienkoMykyta commented on PR #1823:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1823#issuecomment-2567425336

   > @OleksiienkoMykyta can you fix the conflicts?
   
   Fixed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

Re: [PR] CASSGO-2 Marshal big int returns variable length slice [cassandra-gocql-driver]

Posted by "OleksiienkoMykyta (via GitHub)" <gi...@apache.org>.
OleksiienkoMykyta commented on PR #1823:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1823#issuecomment-2473400672

   > Please squash and format your commit message following the rules stated in [CONTRIBUTING.md](https://github.com/apache/cassandra-gocql-driver/blob/trunk/CONTRIBUTING.md#commit-message) and add this JIRA to the `CHANGELOG.md` in the `Fixed` section of `Unreleased`, thanks!
   > 
   > We need another committer +1 to merge this.
   
   How could I get one more committer's approval? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org