[GitHub] [lucene-solr] s1monw commented on a change in pull request #610: LUCENE-8671: Load FST off-heap if reader is not opened from an index writer

[GitBox <gi...@apache.org>]

s1monw commented on a change in pull request #610: LUCENE-8671: Load FST off-heap if reader is not opened from an index writer
URL: https://github.com/apache/lucene-solr/pull/610#discussion_r267247487
 
 

 ##########
 File path: lucene/core/src/java/org/apache/lucene/codecs/blocktree/FieldReader.java
 ##########
 @@ -91,7 +92,8 @@
       clone.seek(indexStartFP);
       // Initialize FST offheap if index is MMapDirectory and
       // docCount != sumDocFreq implying field is not primary key
-      if (clone instanceof ByteBufferIndexInput && this.docCount != this.sumDocFreq) {
+      isFSTOffHeap = clone instanceof ByteBufferIndexInput && ((this.docCount != this.sumDocFreq) || openedFromWriter == false);
 
 Review comment:
   @mikemccand you assumption is correct. @jpountz I will work on making it possible for users to  configure it down the road but I wanted to break this one out to make it simpler to iterate and not mix concerns.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org