You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "matthiasblaesing (via GitHub)" <gi...@apache.org> on 2023/09/14 19:41:06 UTC
[GitHub] [netbeans] matthiasblaesing opened a new pull request, #6451: Improvement of CSS support in NetBeans (@layer, @supports, containment module, text module, math functions, less optional imports)
matthiasblaesing opened a new pull request, #6451:
URL: https://github.com/apache/netbeans/pull/6451
This PR bundles various updates to the CSS/LESS support in NetBeans, as many changes depend on changes to the lexer/parser and the generated code makes it unfeasible to separate them into different PRs.
Parsing support for @layer
------------------------------
```css
@layer module, utilities, state;
@import "utils.css" layer(utilities);
@layer state {
/** */
}
@layer module {
/** */
}
```
Enhanced `@supports` support
---------------------------------
@supports constructs which involved function-style checks added to the supported set.
```css
https://github.com/supports selector(h2 > p) {
}
https://github.com/supports font-tech(color-COLRv1) {
}
https://github.com/supports font-format(opentype) {
}
```
Support for the CSS containment module was added
----------------------------------------------------------
```css
.post {
container-type: inline-size;
container-name: sidebar;
}
@container sidebar (min-width: 400px) {
/* <stylesheet> */
}
```
Properties of CSS text module level 4 were mapped
---------------------------------------------------------
```css
.hints {
hyphenate-character: auto;
hyphenate-limit-chars: 10;
}
```
Math functions (min, max, clamp, ...) are now recognized by the property parser
---------------------------------------------------------------------------------------
```css
.hints {
font-size: min(25px, 2rem);
margin: 0px 0px min(5px, 0.26cqh);
margin-top: max(2px, 10%);
}
```
The `optional` keyword for LESS imports is now recognized
-----------------------------------------------------------------
```less
@import (optional) "user.less";
```
Closes: #5918
Closes: #6060
Closes: #5975
Closes: #6447
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] vieiro commented on a diff in pull request #6451: Improvement of CSS support in NetBeans (@layer, @supports, containment module, text module, math functions, less optional imports)
Posted by "vieiro (via GitHub)" <gi...@apache.org>.
vieiro commented on code in PR #6451:
URL: https://github.com/apache/netbeans/pull/6451#discussion_r1337599156
##########
ide/css.editor/external/binaries-list:
##########
@@ -15,4 +15,4 @@
# specific language governing permissions and limitations
# under the License.
901D8F815922C435D985DA3814D20E34CC7622CB css21-spec.zip
-B9A045802E3214909501B822177EE3AA2F4A469F css3-spec.zip
+72202BE5A9B984CDE2B6FEE9A86DDBABA7922384 css3-spec.zip
Review Comment:
Ah, pretty good! I forgot about the name+sha sum combination. Good to go then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing merged pull request #6451: Improvement of CSS support in NetBeans (@layer, @supports, containment module, text module, math functions, less optional imports)
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing merged PR #6451:
URL: https://github.com/apache/netbeans/pull/6451
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a diff in pull request #6451: Improvement of CSS support in NetBeans (@layer, @supports, containment module, text module, math functions, less optional imports)
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on code in PR #6451:
URL: https://github.com/apache/netbeans/pull/6451#discussion_r1337585332
##########
ide/css.editor/external/binaries-list:
##########
@@ -15,4 +15,4 @@
# specific language governing permissions and limitations
# under the License.
901D8F815922C435D985DA3814D20E34CC7622CB css21-spec.zip
-B9A045802E3214909501B822177EE3AA2F4A469F css3-spec.zip
+72202BE5A9B984CDE2B6FEE9A86DDBABA7922384 css3-spec.zip
Review Comment:
This is a binary hosted on the OSUSOL server. For these the coordinate is the combination of the binary name and the SHA1 sum. Switching between commits will cause an update of the binary either from the local mirror (`~/.hgexternalcache`) or download from the binary server.
The binary is already uploaded and at this time you can still build master and will continue to be able to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] vieiro commented on a diff in pull request #6451: Improvement of CSS support in NetBeans (@layer, @supports, containment module, text module, math functions, less optional imports)
Posted by "vieiro (via GitHub)" <gi...@apache.org>.
vieiro commented on code in PR #6451:
URL: https://github.com/apache/netbeans/pull/6451#discussion_r1336249856
##########
ide/css.editor/external/binaries-list:
##########
@@ -15,4 +15,4 @@
# specific language governing permissions and limitations
# under the License.
901D8F815922C435D985DA3814D20E34CC7622CB css21-spec.zip
-B9A045802E3214909501B822177EE3AA2F4A469F css3-spec.zip
+72202BE5A9B984CDE2B6FEE9A86DDBABA7922384 css3-spec.zip
Review Comment:
Mmm... if we upload a new "css3-spec.zip" with a different shasum...
- Will we be breaking previous NetBeans builds?
- Or builds in git branches that have yet merged this new checksum?
##########
ide/css.editor/external/css3-spec-howtocreate.txt:
##########
@@ -45,15 +45,16 @@ http://www.w3.org/TR/css3-preslev/ \
http://www.w3.org/TR/css3-regions/ \
http://www.w3.org/TR/css3-ruby/ \
http://www.w3.org/TR/css3-speech/ \
-http://www.w3.org/TR/css3-text/ \
http://www.w3.org/TR/css3-transitions/ \
http://www.w3.org/TR/css3-ui/ \
http://www.w3.org/TR/css3-values/ \
http://www.w3.org/TR/css3-writing-modes/ \
http://www.w3.org/TR/css-align-3/ \
http://www.w3.org/TR/css-break-3/ \
http://www.w3.org/TR/css-position-3/ \
-http://www.w3.org/TR/css-sizing-3/
+http://www.w3.org/TR/css-sizing-3/ \
+http://www.w3.org/TR/css-contain-3/ \
+http://www.w3.org/TR/css-text-4/
Review Comment:
What about uploading the newly generated `css3-spec.zip` with a version number? This could be `css3-spec-2023-09-25.zip`, for instance. This will avoid breaking previous builds, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #6451: Improvement of CSS support in NetBeans (@layer, @supports, containment module, text module, math functions, less optional imports)
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #6451:
URL: https://github.com/apache/netbeans/pull/6451#issuecomment-1737759321
I intent to merge this next weekend. If anyone wants to object, please do so now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a diff in pull request #6451: Improvement of CSS support in NetBeans (@layer, @supports, containment module, text module, math functions, less optional imports)
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on code in PR #6451:
URL: https://github.com/apache/netbeans/pull/6451#discussion_r1337588162
##########
ide/css.editor/external/css3-spec-howtocreate.txt:
##########
@@ -45,15 +45,16 @@ http://www.w3.org/TR/css3-preslev/ \
http://www.w3.org/TR/css3-regions/ \
http://www.w3.org/TR/css3-ruby/ \
http://www.w3.org/TR/css3-speech/ \
-http://www.w3.org/TR/css3-text/ \
http://www.w3.org/TR/css3-transitions/ \
http://www.w3.org/TR/css3-ui/ \
http://www.w3.org/TR/css3-values/ \
http://www.w3.org/TR/css3-writing-modes/ \
http://www.w3.org/TR/css-align-3/ \
http://www.w3.org/TR/css-break-3/ \
http://www.w3.org/TR/css-position-3/ \
-http://www.w3.org/TR/css-sizing-3/
+http://www.w3.org/TR/css-sizing-3/ \
+http://www.w3.org/TR/css-contain-3/ \
+http://www.w3.org/TR/css-text-4/
Review Comment:
The build is not broken by this (see above), the version number will more or less be an arbitrary number and this in my mind the SHA1 sum is as good as a number I would imagine. Does this address your concerns?
Oh, it might be helpful to know, that this update five times now since the Apache transition, all in this way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] vieiro commented on a diff in pull request #6451: Improvement of CSS support in NetBeans (@layer, @supports, containment module, text module, math functions, less optional imports)
Posted by "vieiro (via GitHub)" <gi...@apache.org>.
vieiro commented on code in PR #6451:
URL: https://github.com/apache/netbeans/pull/6451#discussion_r1336249856
##########
ide/css.editor/external/binaries-list:
##########
@@ -15,4 +15,4 @@
# specific language governing permissions and limitations
# under the License.
901D8F815922C435D985DA3814D20E34CC7622CB css21-spec.zip
-B9A045802E3214909501B822177EE3AA2F4A469F css3-spec.zip
+72202BE5A9B984CDE2B6FEE9A86DDBABA7922384 css3-spec.zip
Review Comment:
Mmm... if we upload a new "css3-spec.zip" with a different shasum...
- Will we be breaking previous NetBeans builds?
- Or builds in git branches that have not merged this new checksum yet?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists