You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by aniro <gi...@git.apache.org> on 2015/10/08 17:29:03 UTC

[GitHub] spark pull request: [SPARK-2960][Deploy] Support executing Spark f...

Github user aniro commented on the pull request:

    https://github.com/apache/spark/pull/8669#issuecomment-146579493
  
    Can the following be fixed as well?
    ```
    --- a/bin/load-spark-env.sh    2015-10-08 14:51:20.874478368 +0000
    +++ b/bin/load-spark-env.sh    2015-10-08 15:04:02.109674611 +0000
    @@ -47,10 +47,7 @@
     if [ -z "$SPARK_ENV_LOADED" ]; then
       export SPARK_ENV_LOADED=1
    
    -  # Returns the parent of the directory this script lives in.
    -  parent_dir="$(cd "`dirname "$0"`"/..; pwd)"
    -
    -  user_conf_dir="${SPARK_CONF_DIR:-"$parent_dir"/conf}"
    +  user_conf_dir="${SPARK_CONF_DIR:-"$FWDIR"/conf}"
    
       if [ -f "${user_conf_dir}/spark-env.sh" ]; then
         # Promote all variable declarations to environment (exported) variables
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org