[GitHub] [kyuubi] ulysses-you commented on a diff in pull request #5079: [WIP] Infer constant conditions for dynamic partitions

["ulysses-you (via GitHub)" <gi...@apache.org>]

ulysses-you commented on code in PR #5079:
URL: https://github.com/apache/kyuubi/pull/5079#discussion_r1270424412


##########
extensions/spark/kyuubi-extension-spark-3-3/src/main/scala/org/apache/kyuubi/sql/RebalanceBeforeWriting.scala:
##########
@@ -27,7 +27,18 @@ trait RepartitionBuilderWithRebalance extends RepartitionBuilder {
       query: LogicalPlan): LogicalPlan = {
     if (!conf.getConf(KyuubiSQLConf.INFER_REBALANCE_AND_SORT_ORDERS) ||
       dynamicPartitionColumns.nonEmpty) {
-      RebalancePartitions(dynamicPartitionColumns, query)
+      // TODO: make configurable
+      val constantConditions = InferDynamicPartitionConstantConditions
+        .infer(dynamicPartitionColumns, query)

Review Comment:
   We can add a new rule before `RepartitionBeforeWriting` that changes the dynamic partition write to static partition write.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org