You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2018/09/04 09:39:04 UTC
Re: Review Request 68567: Restructured /roles code.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68567/#review208297
-----------------------------------------------------------
Fix it, then Ship it!
src/master/http.cpp
Line 2648 (original), 2644 (patched)
<https://reviews.apache.org/r/68567/#comment292034>
`std::move()`
src/master/http.cpp
Lines 2671 (patched)
<https://reviews.apache.org/r/68567/#comment292035>
const
src/master/http.cpp
Lines 2765 (patched)
<https://reviews.apache.org/r/68567/#comment292036>
const
- Alexander Rukletsov
On Aug. 30, 2018, 11:33 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68567/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2018, 11:33 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Reworked the structure of the role handling in both
> v0 and v1 APIs in preparation for the subsequent commit.
>
> As a nice bonus on top, this also saves one trip
> through the master queue for every call of this endpoint.
>
>
> Diffs
> -----
>
> src/master/http.cpp e074a93666d82944774e7b0c3fa32d7021d93c97
> src/master/master.hpp eecb66c8826b2b681ef94e6457c2651fc63c724b
>
>
> Diff: https://reviews.apache.org/r/68567/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 68567: Restructured /roles code.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On Sept. 4, 2018, 9:39 a.m., Alexander Rukletsov wrote:
> > src/master/http.cpp
> > Line 2648 (original), 2644 (patched)
> > <https://reviews.apache.org/r/68567/diff/1/?file=2079012#file2079012line2648>
> >
> > `std::move()`
Reading https://www.ibm.com/developerworks/community/blogs/5894415f-be62-4bc0-81c5-3956e82276f3/entry/RVO_V_S_std_move?lang=en_us
it seems that casting to rvalue prevents compilers from doing NRVO => dropping.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68567/#review208297
-----------------------------------------------------------
On Sept. 4, 2018, 9:39 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68567/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2018, 9:39 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Reworked the structure of the role handling in both
> v0 and v1 APIs in preparation for the subsequent commit.
>
> As a nice bonus on top, this also saves one trip
> through the master queue for every call of this endpoint.
>
>
> Diffs
> -----
>
> src/master/http.cpp e074a93666d82944774e7b0c3fa32d7021d93c97
> src/master/master.hpp eecb66c8826b2b681ef94e6457c2651fc63c724b
>
>
> Diff: https://reviews.apache.org/r/68567/diff/1/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/68568/
>
>
> Thanks,
>
> Benno Evers
>
>