You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dubbo.apache.org by il...@apache.org on 2019/07/15 02:46:01 UTC
[dubbo] branch master updated: Optimize
Version#isRelease263OrHigher check (#4551) (#4567)
This is an automated email from the ASF dual-hosted git repository.
iluo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/dubbo.git
The following commit(s) were added to refs/heads/master by this push:
new 39b6b0c Optimize Version#isRelease263OrHigher check (#4551) (#4567)
39b6b0c is described below
commit 39b6b0c83bd198a3602ad10fd87a4f7bf57fdfb9
Author: nisiyong <ni...@users.noreply.github.com>
AuthorDate: Mon Jul 15 10:45:50 2019 +0800
Optimize Version#isRelease263OrHigher check (#4551) (#4567)
---
dubbo-common/src/main/java/org/apache/dubbo/common/Version.java | 2 +-
.../src/test/java/org/apache/dubbo/common/version/VersionTest.java | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/dubbo-common/src/main/java/org/apache/dubbo/common/Version.java b/dubbo-common/src/main/java/org/apache/dubbo/common/Version.java
index a015b44..b67d32c 100644
--- a/dubbo-common/src/main/java/org/apache/dubbo/common/Version.java
+++ b/dubbo-common/src/main/java/org/apache/dubbo/common/Version.java
@@ -100,7 +100,7 @@ public final class Version {
// for previous dubbo version(2.0.10/020010~2.6.2/020602), this version is the jar's version, so they need to
// be ignore
int iVersion = getIntVersion(version);
- if (iVersion >= 2001000 && iVersion <= 2060200) {
+ if (iVersion >= 2001000 && iVersion < 2060300) {
return false;
}
diff --git a/dubbo-common/src/test/java/org/apache/dubbo/common/version/VersionTest.java b/dubbo-common/src/test/java/org/apache/dubbo/common/version/VersionTest.java
index 10da6f0..419e5d8 100644
--- a/dubbo-common/src/test/java/org/apache/dubbo/common/version/VersionTest.java
+++ b/dubbo-common/src/test/java/org/apache/dubbo/common/version/VersionTest.java
@@ -60,6 +60,7 @@ public class VersionTest {
Assertions.assertTrue(Version.isRelease263OrHigher("2.7.0.1"));
Assertions.assertTrue(Version.isRelease263OrHigher("2.6.4"));
Assertions.assertFalse(Version.isRelease263OrHigher("2.6.2"));
+ Assertions.assertFalse(Version.isRelease263OrHigher("2.6.2.1"));
Assertions.assertFalse(Version.isRelease263OrHigher("2.6.1.1"));
Assertions.assertTrue(Version.isRelease263OrHigher("2.6.3"));
}