You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/08/14 23:15:00 UTC

[jira] [Work logged] (GOBBLIN-1235) Migrate Log4J to SLF4J to provide a clean log environment for downstream users

     [ https://issues.apache.org/jira/browse/GOBBLIN-1235?focusedWorklogId=470918&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-470918 ]

ASF GitHub Bot logged work on GOBBLIN-1235:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Aug/20 23:14
            Start Date: 14/Aug/20 23:14
    Worklog Time Spent: 10m 
      Work Description: ZihanLi58 opened a new pull request #3081:
URL: https://github.com/apache/incubator-gobblin/pull/3081


   … still use log4j as implementation
   
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1235
   
   
   ### Description
   - [ ] Here are some details about my PR, including screenshots (if applicable):
   change gradle dependencies to migrate log4j to slf4j, and for unit test we still use log4j as log implementation
   By applying this change, to make job can still running on hadoop or still use log4j as log implementation, user will need to exclude 'org.slf4j', module: 'log4j-over-slf4j' from their job to avoid endless loop between 'log4j-over-slf4j' and 'slf4j-log4j12'
   
   ### Tests
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   Test on hadoop that this can work, local deploy service and make sure they can use log4j2 as log implementation.
   
   ### Commits
   - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 470918)
    Remaining Estimate: 0h
            Time Spent: 10m

> Migrate Log4J to SLF4J to provide a clean log environment for downstream users
> ------------------------------------------------------------------------------
>
>                 Key: GOBBLIN-1235
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1235
>             Project: Apache Gobblin
>          Issue Type: Task
>            Reporter: Zihan Li
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)