You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/27 18:34:44 UTC

[GitHub] [arrow] westonpace commented on pull request #12967: ARROW-16294: [C++] Improve performance of parquet readahead

westonpace commented on PR #12967:
URL: https://github.com/apache/arrow/pull/12967#issuecomment-1111349618

   > Looks like there's a lint failure, and MSVC is unhappy as usual:
   
   The dangers of thinking I can fix an MSVC complaint using Github's edit feature :laughing: 
   
   I think this is good now.  I changed the variable itself to int64_t instead of adding static_cast since it is now a "rows" variable and not a "batches" variable.
   
   The behavior for 0 readahead is now "fetch batch when asked for" instead of defaulting to something like 1 row (which probably would have been the same thing anyways but I think this is more clear about our intentions).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org