You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/10/01 08:10:00 UTC
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #775: Fix visibility of action buttons for Isos and templates
rhtyd commented on a change in pull request #775:
URL: https://github.com/apache/cloudstack-primate/pull/775#discussion_r498060019
##########
File path: src/views/image/IsoZones.vue
##########
@@ -32,15 +32,15 @@
<template slot="action" slot-scope="text, record">
<span style="margin-right: 5px">
<a-button
- :disabled="!('copyIso' in $store.getters.apis)"
+ :disabled="!('copyIso' in $store.getters.apis && record.isready)"
icon="copy"
shape="circle"
:loading="copyLoading"
@click="showCopyIso(record)" />
</span>
<span style="margin-right: 5px">
<a-popconfirm
- v-if="'deleteIso' in $store.getters.apis"
+ v-if="'deleteIso' in $store.getters.apis && record.isready"
Review comment:
@Pearl1594 can you check against old UI, if deleting should be allowed? For example for error on download or uploading of local file?
##########
File path: src/views/image/TemplateZones.vue
##########
@@ -32,15 +32,15 @@
<template slot="action" slot-scope="text, record">
<span style="margin-right: 5px">
<a-button
- :disabled="!('copyTemplate' in $store.getters.apis)"
+ :disabled="!('copyTemplate' in $store.getters.apis && record.isready)"
icon="copy"
shape="circle"
:loading="copyLoading"
@click="showCopyTemplate(record)" />
</span>
<span style="margin-right: 5px">
<a-button
- :disabled="!('deleteTemplate' in $store.getters.apis)"
+ :disabled="!('deleteTemplate' in $store.getters.apis && record.isready)"
Review comment:
@Pearl1594 can you check against old UI, if deleting should be allowed? For example for error on download or uploading of local file?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org