You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/02/22 14:16:30 UTC

[GitHub] [incubator-seatunnel] wuchunfu commented on pull request #1256: [Feature] [connector] Support spark hdfs source

wuchunfu commented on pull request #1256:
URL: https://github.com/apache/incubator-seatunnel/pull/1256#issuecomment-1047840951


   > > > hi, thanks for your contribution, but we already have a `files` source, can you describe the difference between the two
   > > 
   > > 
   > > `File source connector` now only supports the prefix `file://`, this pr refers to `File sink` to extend support for hdfs.
   > > **Before**: ![image](https://user-images.githubusercontent.com/18065113/154605532-25e6f82f-e39c-4f1b-ac25-afed584ee524.png)
   > > **After**: ![image](https://user-images.githubusercontent.com/18065113/154605547-66798a17-51c0-4cd4-bbbb-3d4ab61b0252.png)
   > 
   > If it's just this change, we might be better off making changes to the `files` plugin instead of adding a plugin.
   
   @simon824 Can the `sink plugin` also be like the `source plugin` , without distinguishing in the code whether it is `file://` or `hdfs://`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org