You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "Zouxxyy (via GitHub)" <gi...@apache.org> on 2023/03/20 09:01:57 UTC

[GitHub] [hudi] Zouxxyy opened a new pull request, #8243: [HUDI-5957] Fix table props not being properly propagated for HoodieCLIUtils

Zouxxyy opened a new pull request, #8243:
URL: https://github.com/apache/hudi/pull/8243

   ### Change Logs
   
   At present,  `finalParameters` in `HoodieCLIUtils.createHoodieClientFromPath` not contain table props. 
   
   This causes some problems, such as: 
   
   Run cluster should fail when using bucket index, but it does not, because it didn't use `hoodie.index.type` in table props
   
   ```sql
   drop table hudi_cow_test_tbl;
   create table hudi_cow_test_tbl (
     id bigint,  
     name string,  
     ts bigint,  
     dt string,  
     hh string
   ) using hudi
   tblproperties (
     type = 'cow',
     primaryKey = 'id',
     preCombineField = 'ts',
     hoodie.index.type = 'BUCKET'
   )partitioned by (dt, hh);
   
   insert into hudi_cow_test_tbl values (1, 'a1', 1001, '2021-12-09', '10');
   insert into hudi_cow_test_tbl values (2, 'a2', 1001, '2021-12-09', '10');
   
   # this operation should fail, otherwise the table will become unavailable
   call run_clustering(table => 'hudi_cow_test_tbl');
   
   insert into hudi_cow_test_tbl values (3, 'a3', 1001, '2021-12-09', '10'); 
   ```
   
   ### Impact
   
   Fix `finalParameters` in `HoodieCLIUtils.createHoodieClientFromPath`
   
   ### Risk level (write none, low medium or high below)
   
   low
   
   ### Documentation Update
   
   none
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] XuQianJin-Stars merged pull request #8243: [HUDI-5957] Fix table props not being properly propagated for HoodieCLIUtils

Posted by "XuQianJin-Stars (via GitHub)" <gi...@apache.org>.
XuQianJin-Stars merged PR #8243:
URL: https://github.com/apache/hudi/pull/8243


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8243: [HUDI-5957] Fix table props not being properly propagated for HoodieCLIUtils

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8243:
URL: https://github.com/apache/hudi/pull/8243#issuecomment-1476760588

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "120dc11ef3f9fd5f809a9acbd69365aed6e989c9",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15809",
       "triggerID" : "120dc11ef3f9fd5f809a9acbd69365aed6e989c9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 120dc11ef3f9fd5f809a9acbd69365aed6e989c9 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15809) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8243: [HUDI-5957] Fix table props not being properly propagated for HoodieCLIUtils

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8243:
URL: https://github.com/apache/hudi/pull/8243#issuecomment-1475917157

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "120dc11ef3f9fd5f809a9acbd69365aed6e989c9",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15809",
       "triggerID" : "120dc11ef3f9fd5f809a9acbd69365aed6e989c9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 120dc11ef3f9fd5f809a9acbd69365aed6e989c9 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15809) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] Zouxxyy commented on pull request #8243: [HUDI-5957] Fix table props not being properly propagated for HoodieCLIUtils

Posted by "Zouxxyy (via GitHub)" <gi...@apache.org>.
Zouxxyy commented on PR #8243:
URL: https://github.com/apache/hudi/pull/8243#issuecomment-1477517943

   @XuQianJin-Stars Can you help with a review?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8243: [HUDI-5957] Fix table props not being properly propagated for HoodieCLIUtils

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8243:
URL: https://github.com/apache/hudi/pull/8243#issuecomment-1475863877

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "120dc11ef3f9fd5f809a9acbd69365aed6e989c9",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "120dc11ef3f9fd5f809a9acbd69365aed6e989c9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 120dc11ef3f9fd5f809a9acbd69365aed6e989c9 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org