[GitHub] [skywalking-python] probeyang commented on pull request #144: add falcon plugin

[GitBox <gi...@apache.org>]

probeyang commented on pull request #144:
URL: https://github.com/apache/skywalking-python/pull/144#issuecomment-893933507


   i see,  i will close the current PR, and add a new PR after fix it 
   
   
   
   
   ------------------ 原始邮件 ------------------
   发件人: ***@***.***>; 
   发送时间: 2021年8月6日(星期五) 上午9:21
   收件人: ***@***.***>; 
   抄送: ***@***.***>; ***@***.***>; 
   主题: Re: [apache/skywalking-python] add falcon plugin (#144)
   
   
   
   
   
    
   @probeyang can you fix the failure in CI? It's mostly because of code style
    flake8 . --count --max-complexity=15 --max-line-length=120 35 ./tests/plugin/sw_falcon/__init__.py:16:2: W292 no newline at end of file 36 ./tests/plugin/sw_falcon/__init__.py:16:2: W292 no newline at end of file 37 ./tests/plugin/sw_falcon/__init__.py:16:2: W292 no newline at end of file 38 ./tests/plugin/sw_falcon/test_falcon.py:25:1: E302 expected 2 blank lines, found 1 39 ./tests/plugin/sw_falcon/services/consumer.py:26:1: E302 expected 2 blank lines, found 1 40 ./tests/plugin/sw_falcon/services/consumer.py:31:1: E305 expected 2 blank lines after class or function definition, found 1 41 ./tests/plugin/sw_falcon/services/consumer.py:31:40: W292 no newline at end of file 42 ./tests/plugin/sw_falcon/services/provider.py:28:1: E302 expected 2 blank lines, found 1 43 ./tests/plugin/sw_falcon/services/provider.py:33:1: E305 expected 2 blank lines after class or function definition, found 1 44 ./tests/plugin/sw_falcon/services/provider.py:33:40: W292 no newline at end of file  
   —
   You are receiving this because you were mentioned.
   Reply to this email directly, view it on GitHub, or unsubscribe.
   Triage notifications on the go with GitHub Mobile for iOS or Android.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org