[GitHub] [beam] boyuanzz edited a comment on pull request #13533: [BEAM-11474] Track transform processing thread in Java SDK harness and set log entry field

[GitBox <gi...@apache.org>]

boyuanzz edited a comment on pull request #13533:
URL: https://github.com/apache/beam/pull/13533#issuecomment-745540192


   > > Currently you have recorded the threadId-transformId mapping on
   > > 
   > > * startBundle
   > > * finishBundle
   > > * processElementForWindowObservingParDo
   > > * processElementForParDo
   > > 
   > > There are some other places we also invoke user code:
   > > 
   > > * processElementForWindowObservingPairWithRestriction
   > > * processElementForPairWithRestriction
   > > * processElementForWindowObservingSplitRestriction
   > > * processElementForSplitRestriction
   > > * processElementForWindowObservingTruncateRestriction
   > > * processElementForTruncateRestriction
   > > * processElementForWindowObservingSizedElementAndRestriction
   > > * tearDown
   > > * invoke timer callback
   > 
   > Do you think the step info will be useful for the logs in SDF related callbacks? I haven't added for them since I'm not familiar how user would use logging in SDFs but sure we can add tracking for all of them if necessary.
   
   `SDF` indeed is a `DoFn`, not a callback. The SDF author could add additional logging just like in a normal DoFn. If the purpose of this PR is to add step info for the log that users add in their code, then I think we should consider all these places where we will invoke user code.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org