You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/03/23 01:33:41 UTC

[GitHub] [cloudstack] lujiefsi opened a new pull request #4854: CLOUDSTACK-10434:updateVolume should have access check

lujiefsi opened a new pull request #4854:
URL: https://github.com/apache/cloudstack/pull/4854


   ### Description
   
   This PR...
   <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] lujiefsi commented on pull request #4854: CLOUDSTACK-10434:Some APIs should have access check

Posted by GitBox <gi...@apache.org>.
lujiefsi commented on pull request #4854:
URL: https://github.com/apache/cloudstack/pull/4854#issuecomment-805615736


   @rhtyd i will close this this pull request and move the description to https://github.com/apache/cloudstack/pull/4859


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4854: CLOUDSTACK-10434:Some APIs should have access check

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4854:
URL: https://github.com/apache/cloudstack/pull/4854#issuecomment-804919248


   @lujiefsi can you change base branch to 4.15 as it's marked bug fix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4854: CLOUDSTACK-10434:Some APIs should have access check

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4854:
URL: https://github.com/apache/cloudstack/pull/4854#issuecomment-805547075


   @lujiefsi this PR may be closed in favour of https://github.com/apache/cloudstack/pull/4859
   Generally if a PR exists for older branch, we can review/test merge it and forward-merge it until master branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #4854: CLOUDSTACK-10434:Some APIs should have access check

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4854:
URL: https://github.com/apache/cloudstack/pull/4854#issuecomment-804768335


   @lujiefsi why do you think this "solves" CLOUDSTACK-10434? I can not find that, it redirects me to [CLOUDSTACK-10431](https://issues.apache.org/jira/projects/CLOUDSTACK/issues/CLOUDSTACK-10431), the highest ticket number to date.
   Note that the jira board is only used for GSoC currently and issues are at [github](https://github.com/apache/cloudstack/issues)
   
   this is in no way a comment on the code or the functionality of your PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] lujiefsi commented on pull request #4854: CLOUDSTACK-10434:Some APIs should have access check

Posted by GitBox <gi...@apache.org>.
lujiefsi commented on pull request #4854:
URL: https://github.com/apache/cloudstack/pull/4854#issuecomment-805083336


   > @lujiefsi can you change base branch to 4.15 as it's marked bug fix
   
   done see https://github.com/apache/cloudstack/pull/4859/files


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] lujiefsi commented on pull request #4854: CLOUDSTACK-10434:Some APIs should have access check

Posted by GitBox <gi...@apache.org>.
lujiefsi commented on pull request #4854:
URL: https://github.com/apache/cloudstack/pull/4854#issuecomment-805037552


   > @lujiefsi can you change base branch to 4.15 as it's marked bug fix
   
   YES, i will!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] lujiefsi commented on pull request #4854: CLOUDSTACK-10434:Some APIs should have access check

Posted by GitBox <gi...@apache.org>.
lujiefsi commented on pull request #4854:
URL: https://github.com/apache/cloudstack/pull/4854#issuecomment-805036943


   > @lujiefsi why do you think this "solves" CLOUDSTACK-10434? I can not find that, it redirects me to [CLOUDSTACK-10431](https://issues.apache.org/jira/projects/CLOUDSTACK/issues/CLOUDSTACK-10431), the highest ticket number to date.
   > Note that the jira board is only used for GSoC currently and issues are at [github](https://github.com/apache/cloudstack/issues)
   > 
   > this is in no way a comment on the code or the functionality of your PR!
   
   
   
   > @lujiefsi why do you think this "solves" CLOUDSTACK-10434? I can not find that, it redirects me to [CLOUDSTACK-10431](https://issues.apache.org/jira/projects/CLOUDSTACK/issues/CLOUDSTACK-10431), the highest ticket number to date.
   > Note that the jira board is only used for GSoC currently and issues are at [github](https://github.com/apache/cloudstack/issues)
   > 
   > this is in no way a comment on the code or the functionality of your PR!
   
   The issuse link is:
   https://issues.apache.org/jira/browse/CLOUDSTACK-10434


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] lujiefsi closed pull request #4854: CLOUDSTACK-10434:Some APIs should have access check

Posted by GitBox <gi...@apache.org>.
lujiefsi closed pull request #4854:
URL: https://github.com/apache/cloudstack/pull/4854


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] lujiefsi edited a comment on pull request #4854: CLOUDSTACK-10434:Some APIs should have access check

Posted by GitBox <gi...@apache.org>.
lujiefsi edited a comment on pull request #4854:
URL: https://github.com/apache/cloudstack/pull/4854#issuecomment-805083336


   > @lujiefsi can you change base branch to 4.15 as it's marked bug fix
   
   done see https://github.com/apache/cloudstack/pull/4859


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org