You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2020/03/02 16:00:17 UTC
[GitHub] [carbondata] Indhumathi27 opened a new pull request #3651: [WIP]
Fix Incorrect query results on mv with limit
Indhumathi27 opened a new pull request #3651: [WIP] Fix Incorrect query results on mv with limit
URL: https://github.com/apache/carbondata/pull/3651
### Why is this PR needed?
### What changes were proposed in this PR?
### Does this PR introduce any user interface change?
- No
- Yes. (please explain the change and update document)
### Is any new testcase added?
- No
- Yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3651:
[CARBONDATA-3733] Fix Incorrect query results on mv with limit
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3651: [CARBONDATA-3733] Fix Incorrect query results on mv with limit
URL: https://github.com/apache/carbondata/pull/3651#issuecomment-601620708
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2521/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3651:
[CARBONDATA-3733] Fix Incorrect query results on mv with limit
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3651: [CARBONDATA-3733] Fix Incorrect query results on mv with limit
URL: https://github.com/apache/carbondata/pull/3651#issuecomment-595645056
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2353/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3651:
[CARBONDATA-3733] Fix Incorrect query results on mv with limit
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3651: [CARBONDATA-3733] Fix Incorrect query results on mv with limit
URL: https://github.com/apache/carbondata/pull/3651#issuecomment-595210860
Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/637/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3651: [WIP] Fix
Incorrect query results on mv with limit
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3651: [WIP] Fix Incorrect query results on mv with limit
URL: https://github.com/apache/carbondata/pull/3651#issuecomment-593484956
Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/565/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3651:
[CARBONDATA-3733] Fix Incorrect query results on mv with limit
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3651: [CARBONDATA-3733] Fix Incorrect query results on mv with limit
URL: https://github.com/apache/carbondata/pull/3651#issuecomment-601568178
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2514/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] asfgit closed pull request #3651: [CARBONDATA-3733]
Fix Incorrect query results on mv with limit
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3651: [CARBONDATA-3733] Fix Incorrect query results on mv with limit
URL: https://github.com/apache/carbondata/pull/3651
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3651:
[CARBONDATA-3733] Fix Incorrect query results on mv with limit
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3651: [CARBONDATA-3733] Fix Incorrect query results on mv with limit
URL: https://github.com/apache/carbondata/pull/3651#issuecomment-599491757
Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/767/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3651:
[CARBONDATA-3733] Fix Incorrect query results on mv with limit
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3651: [CARBONDATA-3733] Fix Incorrect query results on mv with limit
URL: https://github.com/apache/carbondata/pull/3651#issuecomment-593965394
Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/587/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3651:
[CARBONDATA-3733] Fix Incorrect query results on mv with limit
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3651: [CARBONDATA-3733] Fix Incorrect query results on mv with limit
URL: https://github.com/apache/carbondata/pull/3651#issuecomment-593834394
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2276/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3651:
[CARBONDATA-3733] Fix Incorrect query results on mv with limit
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3651: [CARBONDATA-3733] Fix Incorrect query results on mv with limit
URL: https://github.com/apache/carbondata/pull/3651#issuecomment-596360970
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2392/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] Indhumathi27 commented on a change in pull request
#3651: [CARBONDATA-3733] Fix Incorrect query results on mv with limit
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on a change in pull request #3651: [CARBONDATA-3733] Fix Incorrect query results on mv with limit
URL: https://github.com/apache/carbondata/pull/3651#discussion_r387021167
##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonAlterTableCompactionCommand.scala
##########
@@ -220,17 +219,23 @@ case class CarbonAlterTableCompactionCommand(
val LOGGER = LogServiceFactory.getLogService(this.getClass.getName)
val compactionType = CompactionType.valueOf(alterTableModel.compactionType.toUpperCase)
val compactionSize = CarbonDataMergerUtil.getCompactionSize(compactionType, carbonLoadModel)
+ val carbonTable = carbonLoadModel.getCarbonDataLoadSchema.getCarbonTable
if (CompactionType.IUD_UPDDEL_DELTA == compactionType) {
if (alterTableModel.segmentUpdateStatusManager.isDefined) {
carbonLoadModel.setSegmentUpdateStatusManager(
alterTableModel.segmentUpdateStatusManager.get)
carbonLoadModel.setLoadMetadataDetails(
alterTableModel.segmentUpdateStatusManager.get.getLoadMetadataDetails.toList.asJava)
+ } else {
+ // segmentUpdateStatusManager will not be defined, in case of IUD compaction on materialised
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3651:
[CARBONDATA-3733] Fix Incorrect query results on mv with limit
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3651: [CARBONDATA-3733] Fix Incorrect query results on mv with limit
URL: https://github.com/apache/carbondata/pull/3651#issuecomment-594511636
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2316/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3651:
[CARBONDATA-3733] Fix Incorrect query results on mv with limit
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3651: [CARBONDATA-3733] Fix Incorrect query results on mv with limit
URL: https://github.com/apache/carbondata/pull/3651#issuecomment-599493253
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2475/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3651:
[CARBONDATA-3733] Fix Incorrect query results on mv with limit
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3651: [CARBONDATA-3733] Fix Incorrect query results on mv with limit
URL: https://github.com/apache/carbondata/pull/3651#issuecomment-594513884
Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/609/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] akashrn5 commented on a change in pull request #3651:
[CARBONDATA-3733] Fix Incorrect query results on mv with limit
Posted by GitBox <gi...@apache.org>.
akashrn5 commented on a change in pull request #3651: [CARBONDATA-3733] Fix Incorrect query results on mv with limit
URL: https://github.com/apache/carbondata/pull/3651#discussion_r387008135
##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonAlterTableCompactionCommand.scala
##########
@@ -220,17 +219,23 @@ case class CarbonAlterTableCompactionCommand(
val LOGGER = LogServiceFactory.getLogService(this.getClass.getName)
val compactionType = CompactionType.valueOf(alterTableModel.compactionType.toUpperCase)
val compactionSize = CarbonDataMergerUtil.getCompactionSize(compactionType, carbonLoadModel)
+ val carbonTable = carbonLoadModel.getCarbonDataLoadSchema.getCarbonTable
if (CompactionType.IUD_UPDDEL_DELTA == compactionType) {
if (alterTableModel.segmentUpdateStatusManager.isDefined) {
carbonLoadModel.setSegmentUpdateStatusManager(
alterTableModel.segmentUpdateStatusManager.get)
carbonLoadModel.setLoadMetadataDetails(
alterTableModel.segmentUpdateStatusManager.get.getLoadMetadataDetails.toList.asJava)
+ } else {
+ // segmentUpdateStatusManager will not be defined, in case of IUD compaction on materialised
Review comment:
```suggestion
// segmentUpdateStatusManager will not be defined in case of IUD compaction on materialized
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3651:
[CARBONDATA-3733] Fix Incorrect query results on mv with limit
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3651: [CARBONDATA-3733] Fix Incorrect query results on mv with limit
URL: https://github.com/apache/carbondata/pull/3651#issuecomment-596361915
Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/686/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] akashrn5 commented on a change in pull request #3651:
[CARBONDATA-3733] Fix Incorrect query results on mv with limit
Posted by GitBox <gi...@apache.org>.
akashrn5 commented on a change in pull request #3651: [CARBONDATA-3733] Fix Incorrect query results on mv with limit
URL: https://github.com/apache/carbondata/pull/3651#discussion_r395444257
##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonAlterTableCompactionCommand.scala
##########
@@ -220,17 +219,23 @@ case class CarbonAlterTableCompactionCommand(
val LOGGER = LogServiceFactory.getLogService(this.getClass.getName)
val compactionType = CompactionType.valueOf(alterTableModel.compactionType.toUpperCase)
val compactionSize = CarbonDataMergerUtil.getCompactionSize(compactionType, carbonLoadModel)
+ val carbonTable = carbonLoadModel.getCarbonDataLoadSchema.getCarbonTable
if (CompactionType.IUD_UPDDEL_DELTA == compactionType) {
if (alterTableModel.segmentUpdateStatusManager.isDefined) {
carbonLoadModel.setSegmentUpdateStatusManager(
alterTableModel.segmentUpdateStatusManager.get)
carbonLoadModel.setLoadMetadataDetails(
alterTableModel.segmentUpdateStatusManager.get.getLoadMetadataDetails.toList.asJava)
+ } else {
+ // segmentUpdateStatusManager will not be defined in case of IUD compaction on materialized
Review comment:
mention horizontal compaction also, even in descripton
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] Indhumathi27 commented on issue #3651:
[CARBONDATA-3733] Fix Incorrect query results on mv with limit
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on issue #3651: [CARBONDATA-3733] Fix Incorrect query results on mv with limit
URL: https://github.com/apache/carbondata/pull/3651#issuecomment-599416123
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] Indhumathi27 commented on issue #3651:
[CARBONDATA-3733] Fix Incorrect query results on mv with limit
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on issue #3651: [CARBONDATA-3733] Fix Incorrect query results on mv with limit
URL: https://github.com/apache/carbondata/pull/3651#issuecomment-601539304
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] Indhumathi27 commented on issue #3651:
[CARBONDATA-3733] Fix Incorrect query results on mv with limit
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on issue #3651: [CARBONDATA-3733] Fix Incorrect query results on mv with limit
URL: https://github.com/apache/carbondata/pull/3651#issuecomment-601569921
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3651:
[CARBONDATA-3733] Fix Incorrect query results on mv with limit
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3651: [CARBONDATA-3733] Fix Incorrect query results on mv with limit
URL: https://github.com/apache/carbondata/pull/3651#issuecomment-595207068
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2344/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] akashrn5 commented on a change in pull request #3651:
[CARBONDATA-3733] Fix Incorrect query results on mv with limit
Posted by GitBox <gi...@apache.org>.
akashrn5 commented on a change in pull request #3651: [CARBONDATA-3733] Fix Incorrect query results on mv with limit
URL: https://github.com/apache/carbondata/pull/3651#discussion_r395444682
##########
File path: mv/core/src/main/scala/org/apache/carbondata/mv/extension/MVHelper.scala
##########
@@ -85,6 +85,25 @@ object MVHelper {
"with limit")
case _ =>
}
+
+ // Order by columns needs to be present in projection list for creating mv. This is because,
+ // we have to perform order by on all segments during query, which requires the order by column
+ // data
+ queryPlan.transform {
+ case sort@Sort(order, _, _) =>
+ order.map { orderByCol =>
+ orderByCol.child match {
+ case attr: AttributeReference =>
+ if (!queryPlan.output.contains(attr.toAttribute)) {
+ throw new UnsupportedOperationException(
+ "Order by columns must be present in project columns")
Review comment:
please give column name also in error
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3651:
[CARBONDATA-3733] Fix Incorrect query results on mv with limit
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3651: [CARBONDATA-3733] Fix Incorrect query results on mv with limit
URL: https://github.com/apache/carbondata/pull/3651#issuecomment-595644805
Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/647/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] akashrn5 commented on issue #3651: [CARBONDATA-3733]
Fix Incorrect query results on mv with limit
Posted by GitBox <gi...@apache.org>.
akashrn5 commented on issue #3651: [CARBONDATA-3733] Fix Incorrect query results on mv with limit
URL: https://github.com/apache/carbondata/pull/3651#issuecomment-595169631
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3651:
[CARBONDATA-3733] Fix Incorrect query results on mv with limit
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3651: [CARBONDATA-3733] Fix Incorrect query results on mv with limit
URL: https://github.com/apache/carbondata/pull/3651#issuecomment-601619408
Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/814/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3651:
[CARBONDATA-3733] Fix Incorrect query results on mv with limit
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3651: [CARBONDATA-3733] Fix Incorrect query results on mv with limit
URL: https://github.com/apache/carbondata/pull/3651#issuecomment-593806296
Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/571/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3651:
[CARBONDATA-3733] Fix Incorrect query results on mv with limit
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3651: [CARBONDATA-3733] Fix Incorrect query results on mv with limit
URL: https://github.com/apache/carbondata/pull/3651#issuecomment-601567502
Build Failed with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/810/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] Indhumathi27 commented on issue #3651:
[CARBONDATA-3733] Fix Incorrect query results on mv with limit
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on issue #3651: [CARBONDATA-3733] Fix Incorrect query results on mv with limit
URL: https://github.com/apache/carbondata/pull/3651#issuecomment-594420468
@akashrn5 Please review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3651: [WIP] Fix
Incorrect query results on mv with limit
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3651: [WIP] Fix Incorrect query results on mv with limit
URL: https://github.com/apache/carbondata/pull/3651#issuecomment-593532908
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2269/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3651:
[CARBONDATA-3733] Fix Incorrect query results on mv with limit
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3651: [CARBONDATA-3733] Fix Incorrect query results on mv with limit
URL: https://github.com/apache/carbondata/pull/3651#issuecomment-593998502
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2293/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] akashrn5 commented on issue #3651: [CARBONDATA-3733]
Fix Incorrect query results on mv with limit
Posted by GitBox <gi...@apache.org>.
akashrn5 commented on issue #3651: [CARBONDATA-3733] Fix Incorrect query results on mv with limit
URL: https://github.com/apache/carbondata/pull/3651#issuecomment-601635105
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3651:
[CARBONDATA-3733] Fix Incorrect query results on mv with limit
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3651: [CARBONDATA-3733] Fix Incorrect query results on mv with limit
URL: https://github.com/apache/carbondata/pull/3651#issuecomment-601587463
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2516/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services