You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2022/03/16 23:17:38 UTC
[Impala-ASF-CR] IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18328
Change subject: IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
......................................................................
IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
Change-Id: I2bdd8a9c68ffb0dd1c3ea72c3649b00abcc05a49
---
M bin/run-all-tests.sh
1 file changed, 11 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/28/18328/1
--
To view, visit http://gerrit.cloudera.org:8080/18328
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2bdd8a9c68ffb0dd1c3ea72c3649b00abcc05a49
Gerrit-Change-Number: 18328
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18328 )
Change subject: IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10299/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18328
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2bdd8a9c68ffb0dd1c3ea72c3649b00abcc05a49
Gerrit-Change-Number: 18328
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Mar 2022 23:37:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18328 )
Change subject: IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
......................................................................
Patch Set 5:
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8132/
--
To view, visit http://gerrit.cloudera.org:8080/18328
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2bdd8a9c68ffb0dd1c3ea72c3649b00abcc05a49
Gerrit-Change-Number: 18328
Gerrit-PatchSet: 5
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sun, 22 May 2022 01:50:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18328 )
Change subject: IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
......................................................................
Patch Set 5:
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8131/
--
To view, visit http://gerrit.cloudera.org:8080/18328
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2bdd8a9c68ffb0dd1c3ea72c3649b00abcc05a49
Gerrit-Change-Number: 18328
Gerrit-PatchSet: 5
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sat, 21 May 2022 13:44:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18328 )
Change subject: IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10611/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18328
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2bdd8a9c68ffb0dd1c3ea72c3649b00abcc05a49
Gerrit-Change-Number: 18328
Gerrit-PatchSet: 5
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sat, 21 May 2022 04:56:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18328
to look at the new patch set (#2).
Change subject: IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
......................................................................
IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
We launch a background process checking whether tests are timeout in
run-all-tests.sh. When NUM_TEST_ITERATIONS is set to larger than 1,
run-all-tests.sh will repeat the tests. However, the timeout process is
killed at the end of each iteration, which fails the script when we want
to repeat tests.
This patch move the killing logic outside the loop.
Tested with NUM_TEST_ITERATIONS=20 and verified it works.
Change-Id: I2bdd8a9c68ffb0dd1c3ea72c3649b00abcc05a49
---
M bin/run-all-tests.sh
1 file changed, 11 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/28/18328/2
--
To view, visit http://gerrit.cloudera.org:8080/18328
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2bdd8a9c68ffb0dd1c3ea72c3649b00abcc05a49
Gerrit-Change-Number: 18328
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18328 )
Change subject: IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
......................................................................
Patch Set 3: Code-Review+2
carry +1 from Csaba
--
To view, visit http://gerrit.cloudera.org:8080/18328
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2bdd8a9c68ffb0dd1c3ea72c3649b00abcc05a49
Gerrit-Change-Number: 18328
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 20 May 2022 20:51:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18328 )
Change subject: IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
......................................................................
Patch Set 5: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8130/
--
To view, visit http://gerrit.cloudera.org:8080/18328
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2bdd8a9c68ffb0dd1c3ea72c3649b00abcc05a49
Gerrit-Change-Number: 18328
Gerrit-PatchSet: 5
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sat, 21 May 2022 09:10:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18328 )
Change subject: IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
......................................................................
Patch Set 6: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18328
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2bdd8a9c68ffb0dd1c3ea72c3649b00abcc05a49
Gerrit-Change-Number: 18328
Gerrit-PatchSet: 6
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 23 May 2022 06:24:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18328
to look at the new patch set (#3).
Change subject: IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
......................................................................
IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
We launch a background process checking whether tests are timeout in
run-all-tests.sh. When NUM_TEST_ITERATIONS is set to larger than 1,
run-all-tests.sh will repeat the tests. However, the timeout process is
killed at the end of each iteration, which fails the script when we want
to repeat tests. This patch moves the killing logic outside the loop.
This patch also adds a new variable, CLUSTER_TEST_FILES, to specify
a particular custom-cluster test to run.
To speedup the test iteration, this patch avoids always restarting the
Impala cluster. E.g. when we just need to run a particular EE test, we
only need to start the Impala cluster once.
Tested with NUM_TEST_ITERATIONS=10 and verified with following
scenarios.
1) custom-cluster test only
export BE_TEST, FE_TEST, JDBC_TEST, EE_TEST to false
export CLUSTER_TEST=true and CLUSTER_TEST_FILES to following values:
custom_cluster/test_local_catalog.py
custom_cluster/test_local_catalog.py::TestLocalCatalogRetries
custom_cluster/test_local_catalog.py::TestLocalCatalogRetries::test_replan_limit
"custom_cluster/test_local_catalog.py -k replan_limit"
2) e2e test only
export BE_TEST, FE_TEST, JDBC_TEST, CLUSTER_TEST to false
export EE_TEST=true and
EE_TEST_FILES=query_test/test_scanners.py::TestParquet::test_multiple_blocks_mt_dop
Change-Id: I2bdd8a9c68ffb0dd1c3ea72c3649b00abcc05a49
---
M bin/run-all-tests.sh
M tests/run-custom-cluster-tests.sh
M tests/run-tests.py
3 files changed, 28 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/28/18328/3
--
To view, visit http://gerrit.cloudera.org:8080/18328
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2bdd8a9c68ffb0dd1c3ea72c3649b00abcc05a49
Gerrit-Change-Number: 18328
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18328 )
Change subject: IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18328
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2bdd8a9c68ffb0dd1c3ea72c3649b00abcc05a49
Gerrit-Change-Number: 18328
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 20 May 2022 23:17:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18328 )
Change subject: IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
......................................................................
Patch Set 5: Code-Review+2
Carry +2 from Csaba and Wenzhe
--
To view, visit http://gerrit.cloudera.org:8080/18328
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2bdd8a9c68ffb0dd1c3ea72c3649b00abcc05a49
Gerrit-Change-Number: 18328
Gerrit-PatchSet: 5
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sat, 21 May 2022 04:41:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18328 )
Change subject: IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
......................................................................
Patch Set 4: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8128/
--
To view, visit http://gerrit.cloudera.org:8080/18328
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2bdd8a9c68ffb0dd1c3ea72c3649b00abcc05a49
Gerrit-Change-Number: 18328
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sat, 21 May 2022 03:29:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18328 )
Change subject: IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
......................................................................
Patch Set 5:
> Patch Set 5:
>
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8131/
Hit IMPALA-10927 again: https://jenkins.impala.io/job/ubuntu-16.04-dockerised-tests/5705/
--
To view, visit http://gerrit.cloudera.org:8080/18328
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2bdd8a9c68ffb0dd1c3ea72c3649b00abcc05a49
Gerrit-Change-Number: 18328
Gerrit-PatchSet: 5
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sat, 21 May 2022 13:45:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18328 )
Change subject: IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8132/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18328
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2bdd8a9c68ffb0dd1c3ea72c3649b00abcc05a49
Gerrit-Change-Number: 18328
Gerrit-PatchSet: 5
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sat, 21 May 2022 21:22:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18328 )
Change subject: IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8128/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18328
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2bdd8a9c68ffb0dd1c3ea72c3649b00abcc05a49
Gerrit-Change-Number: 18328
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 20 May 2022 23:17:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18328 )
Change subject: IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8131/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18328
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2bdd8a9c68ffb0dd1c3ea72c3649b00abcc05a49
Gerrit-Change-Number: 18328
Gerrit-PatchSet: 5
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sat, 21 May 2022 09:14:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18328 )
Change subject: IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8130/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18328
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2bdd8a9c68ffb0dd1c3ea72c3649b00abcc05a49
Gerrit-Change-Number: 18328
Gerrit-PatchSet: 5
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sat, 21 May 2022 04:42:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Hello Csaba Ringhofer, Wenzhe Zhou, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18328
to look at the new patch set (#5).
Change subject: IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
......................................................................
IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
We launch a background process checking whether tests are timeout in
run-all-tests.sh. When NUM_TEST_ITERATIONS is set to larger than 1,
run-all-tests.sh will repeat the tests. However, the timeout process is
killed at the end of each iteration, which fails the script when we want
to repeat tests. This patch moves the killing logic outside the loop.
This patch also adds a new variable, CLUSTER_TEST_FILES, to specify
a particular custom-cluster test to run.
To speedup the test iteration, this patch avoids always restarting the
Impala cluster. E.g. when we just need to run a particular EE test, we
only need to start the Impala cluster once.
Tested with NUM_TEST_ITERATIONS=10 and verified with following
scenarios.
1) custom-cluster test only
export BE_TEST, FE_TEST, JDBC_TEST, EE_TEST to false
export CLUSTER_TEST=true and CLUSTER_TEST_FILES to following values:
custom_cluster/test_local_catalog.py
custom_cluster/test_local_catalog.py::TestLocalCatalogRetries
custom_cluster/test_local_catalog.py::TestLocalCatalogRetries::test_replan_limit
"custom_cluster/test_local_catalog.py -k replan_limit"
2) e2e test only
export BE_TEST, FE_TEST, JDBC_TEST, CLUSTER_TEST to false
export EE_TEST=true and
EE_TEST_FILES=query_test/test_scanners.py::TestParquet::test_multiple_blocks_mt_dop
Change-Id: I2bdd8a9c68ffb0dd1c3ea72c3649b00abcc05a49
---
M bin/run-all-tests.sh
M tests/run-custom-cluster-tests.sh
M tests/run-tests.py
3 files changed, 29 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/28/18328/5
--
To view, visit http://gerrit.cloudera.org:8080/18328
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2bdd8a9c68ffb0dd1c3ea72c3649b00abcc05a49
Gerrit-Change-Number: 18328
Gerrit-PatchSet: 5
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18328 )
Change subject: IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
......................................................................
Patch Set 5:
> Patch Set 5: Verified-1
>
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8130/
The failure is due to IMPALA-10927
--
To view, visit http://gerrit.cloudera.org:8080/18328
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2bdd8a9c68ffb0dd1c3ea72c3649b00abcc05a49
Gerrit-Change-Number: 18328
Gerrit-PatchSet: 5
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sat, 21 May 2022 09:13:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18328 )
Change subject: IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
......................................................................
Patch Set 6:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8138/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18328
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2bdd8a9c68ffb0dd1c3ea72c3649b00abcc05a49
Gerrit-Change-Number: 18328
Gerrit-PatchSet: 6
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 23 May 2022 01:57:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18328 )
Change subject: IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18328
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2bdd8a9c68ffb0dd1c3ea72c3649b00abcc05a49
Gerrit-Change-Number: 18328
Gerrit-PatchSet: 6
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 23 May 2022 01:57:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18328 )
Change subject: IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
......................................................................
IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
We launch a background process checking whether tests are timeout in
run-all-tests.sh. When NUM_TEST_ITERATIONS is set to larger than 1,
run-all-tests.sh will repeat the tests. However, the timeout process is
killed at the end of each iteration, which fails the script when we want
to repeat tests. This patch moves the killing logic outside the loop.
This patch also adds a new variable, CLUSTER_TEST_FILES, to specify
a particular custom-cluster test to run.
To speedup the test iteration, this patch avoids always restarting the
Impala cluster. E.g. when we just need to run a particular EE test, we
only need to start the Impala cluster once.
Tested with NUM_TEST_ITERATIONS=10 and verified with following
scenarios.
1) custom-cluster test only
export BE_TEST, FE_TEST, JDBC_TEST, EE_TEST to false
export CLUSTER_TEST=true and CLUSTER_TEST_FILES to following values:
custom_cluster/test_local_catalog.py
custom_cluster/test_local_catalog.py::TestLocalCatalogRetries
custom_cluster/test_local_catalog.py::TestLocalCatalogRetries::test_replan_limit
"custom_cluster/test_local_catalog.py -k replan_limit"
2) e2e test only
export BE_TEST, FE_TEST, JDBC_TEST, CLUSTER_TEST to false
export EE_TEST=true and
EE_TEST_FILES=query_test/test_scanners.py::TestParquet::test_multiple_blocks_mt_dop
Change-Id: I2bdd8a9c68ffb0dd1c3ea72c3649b00abcc05a49
Reviewed-on: http://gerrit.cloudera.org:8080/18328
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/run-all-tests.sh
M tests/run-custom-cluster-tests.sh
M tests/run-tests.py
3 files changed, 29 insertions(+), 9 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18328
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2bdd8a9c68ffb0dd1c3ea72c3649b00abcc05a49
Gerrit-Change-Number: 18328
Gerrit-PatchSet: 7
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18328 )
Change subject: IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18328
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2bdd8a9c68ffb0dd1c3ea72c3649b00abcc05a49
Gerrit-Change-Number: 18328
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 20 May 2022 12:53:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18328 )
Change subject: IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
......................................................................
Patch Set 4:
> Patch Set 4: Verified-1
>
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8128/
Oops, this failed by
/home/ubuntu/Impala/tests/run-custom-cluster-tests.sh: line 39: CLUSTER_TEST_FILES: unbound variable
+ RET_CODE=1
--
To view, visit http://gerrit.cloudera.org:8080/18328
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2bdd8a9c68ffb0dd1c3ea72c3649b00abcc05a49
Gerrit-Change-Number: 18328
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sat, 21 May 2022 04:29:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18328 )
Change subject: IMPALA-11183: Fix run-all-tests.sh can't repeat tests more than once
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10606/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18328
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2bdd8a9c68ffb0dd1c3ea72c3649b00abcc05a49
Gerrit-Change-Number: 18328
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 20 May 2022 10:55:31 +0000
Gerrit-HasComments: No