You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "PurelyApplied (GitHub)" <gi...@apache.org> on 2019/04/09 17:10:31 UTC

[GitHub] [geode] PurelyApplied opened pull request #3433: GEODE-6383: Be explicit in evaluation dependencies.

* A previous commit under this ticket was too aggressive in project evaluation dependencies.  Explicit > Implicit.

-----

`evaluationDependsOn` is a bit of a code smell in any case, and we should work towards better modularity / less cross-project reliance in any case.  But that is Future Work (tm) (r) (c).

-----

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [nope] Have you written or updated unit tests to verify your changes?

- [n/a] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/3433 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] rhoughton-pivot closed pull request #3433: GEODE-6383: Be explicit in evaluation dependencies.

Posted by "rhoughton-pivot (GitHub)" <gi...@apache.org>.
[ pull request closed by rhoughton-pivot ]

[ Full content available at: https://github.com/apache/geode/pull/3433 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org