You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/01/21 08:44:44 UTC
[GitHub] [incubator-tvm] masahi opened a new pull request #4756: [Docker]
Update torch version to 1.4
masahi opened a new pull request #4756: [Docker] Update torch version to 1.4
URL: https://github.com/apache/incubator-tvm/pull/4756
v1.4 was out last week and we are still at 1.2.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] jwfromm commented on issue #4756: [Docker] update
onnx to 1.6 and torch to 1.4
Posted by GitBox <gi...@apache.org>.
jwfromm commented on issue #4756: [Docker] update onnx to 1.6 and torch to 1.4
URL: https://github.com/apache/incubator-tvm/pull/4756#issuecomment-581691232
You're right that importing onnx first resolves the issue. I tried it out with a few different pytorch and onnx version combinations and it runs fine with them all. Your explanation of the issue makes perfect sense as well. Funny that it was something so simple all along.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] masahi commented on issue #4756: [Docker] Update
torch version to 1.4
Posted by GitBox <gi...@apache.org>.
masahi commented on issue #4756: [Docker] Update torch version to 1.4
URL: https://github.com/apache/incubator-tvm/pull/4756#issuecomment-577617857
ok reverted
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] masahi commented on issue #4756: [Docker] Update
torch version to 1.4
Posted by GitBox <gi...@apache.org>.
masahi commented on issue #4756: [Docker] Update torch version to 1.4
URL: https://github.com/apache/incubator-tvm/pull/4756#issuecomment-581182912
@jwfromm have you tried pytorch 1.4 + onnx 1.6? So far I have no problem with this combo. I want to update onnx CI as well if possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] masahi edited a comment on issue #4756: [Docker]
Update torch version to 1.4
Posted by GitBox <gi...@apache.org>.
masahi edited a comment on issue #4756: [Docker] Update torch version to 1.4
URL: https://github.com/apache/incubator-tvm/pull/4756#issuecomment-581640387
@jwfromm I posted what I think is the solution to "onnx segfault problem" at https://github.com/onnx/onnx/issues/2394#issuecomment-581638840. I encourage you to try it with pytorch 1.3 or 1.4.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] jwfromm commented on issue #4756: [Docker] Update
torch version to 1.4
Posted by GitBox <gi...@apache.org>.
jwfromm commented on issue #4756: [Docker] Update torch version to 1.4
URL: https://github.com/apache/incubator-tvm/pull/4756#issuecomment-581564923
I don't think I've tried that version combo. If it's working for you then I'd say let's update!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] masahi commented on issue #4756: [Docker] Update
torch version to 1.4
Posted by GitBox <gi...@apache.org>.
masahi commented on issue #4756: [Docker] Update torch version to 1.4
URL: https://github.com/apache/incubator-tvm/pull/4756#issuecomment-577406065
@leandron yes, torchvision 0.5 seems to be compatible with PIL 7.0. My installation was already 7.0.
```
In [5]: import PIL
In [6]: import torchvision
In [7]: PIL.__version__
Out[7]: '7.0.0'
In [8]: torchvision.__version__
Out[8]: '0.5.0'
```
does this answer your question?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] masahi edited a comment on issue #4756: [Docker]
Update torch version to 1.4
Posted by GitBox <gi...@apache.org>.
masahi edited a comment on issue #4756: [Docker] Update torch version to 1.4
URL: https://github.com/apache/incubator-tvm/pull/4756#issuecomment-577406065
@leandron yes, torchvision 0.5 seems to be compatible with PIL 7.0 (fixed in [#1501](https://github.com/pytorch/vision/pull/1501)). My installation was already 7.0.
```
In [5]: import PIL
In [6]: import torchvision
In [7]: PIL.__version__
Out[7]: '7.0.0'
In [8]: torchvision.__version__
Out[8]: '0.5.0'
```
does this answer your question?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] masahi commented on issue #4756: [Docker] update
onnx to 1.6 and torch to 1.4
Posted by GitBox <gi...@apache.org>.
masahi commented on issue #4756: [Docker] update onnx to 1.6 and torch to 1.4
URL: https://github.com/apache/incubator-tvm/pull/4756#issuecomment-583163841
does `ci-cpu` run on CI to test PRs? If so I cannot send torch 1.4 and onnx 1.6 dependent changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] leandron commented on issue #4756: [Docker] Update
torch version to 1.4
Posted by GitBox <gi...@apache.org>.
leandron commented on issue #4756: [Docker] Update torch version to 1.4
URL: https://github.com/apache/incubator-tvm/pull/4756#issuecomment-577603634
Yes @masahi. Then, if you want, you can remove those `<7` in Pillow installations, in the context of this PR, so it is a self-contained torch update? I'm happy to review it for you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen closed pull request #4756: [Docker] update
onnx to 1.6 and torch to 1.4
Posted by GitBox <gi...@apache.org>.
tqchen closed pull request #4756: [Docker] update onnx to 1.6 and torch to 1.4
URL: https://github.com/apache/incubator-tvm/pull/4756
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] masahi commented on issue #4756: [Docker] Update
torch version to 1.4
Posted by GitBox <gi...@apache.org>.
masahi commented on issue #4756: [Docker] Update torch version to 1.4
URL: https://github.com/apache/incubator-tvm/pull/4756#issuecomment-576965598
There is no hurry, we can wait until mxnet issues are fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] masahi commented on issue #4756: [Docker] update
onnx to 1.6 and torch to 1.4
Posted by GitBox <gi...@apache.org>.
masahi commented on issue #4756: [Docker] update onnx to 1.6 and torch to 1.4
URL: https://github.com/apache/incubator-tvm/pull/4756#issuecomment-583124373
@tqchen can we send torch 1.4 and onnx 1.6 dependent changes now that #4827 and #4826 were merged?
Also this PR can be closed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] leandron commented on issue #4756: [Docker] Update
torch version to 1.4
Posted by GitBox <gi...@apache.org>.
leandron commented on issue #4756: [Docker] Update torch version to 1.4
URL: https://github.com/apache/incubator-tvm/pull/4756#issuecomment-578681838
Sorry @masahi , I don't know how that error is related to the Pillow dependency and couldn't find any related issue on sphinx.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] masahi edited a comment on issue #4756: [Docker]
update onnx to 1.6 and torch to 1.4
Posted by GitBox <gi...@apache.org>.
masahi edited a comment on issue #4756: [Docker] update onnx to 1.6 and torch to 1.4
URL: https://github.com/apache/incubator-tvm/pull/4756#issuecomment-583124373
@tqchen can we send torch 1.4 and onnx 1.6 dependent changes now that #4827 and #4826 were merged? It seems only `ci-gpu` was updated, I wonder what happen if I run my test on `ci-cpu`.
Also it seems this PR can be closed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] masahi commented on issue #4756: [Docker] Update
torch version to 1.4
Posted by GitBox <gi...@apache.org>.
masahi commented on issue #4756: [Docker] Update torch version to 1.4
URL: https://github.com/apache/incubator-tvm/pull/4756#issuecomment-580259814
ok CI is fixed.
@tqchen since the update of MXNet seems to be having issues, and we want to test the [PyTorch frontend](https://github.com/apache/incubator-tvm/pull/4497) on the latest version, we want the PyTorch update to be built first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on issue #4756: [Docker] update
onnx to 1.6 and torch to 1.4
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #4756: [Docker] update onnx to 1.6 and torch to 1.4
URL: https://github.com/apache/incubator-tvm/pull/4756#issuecomment-583190431
I believe it runs unit-tests but not integration(frontend tests)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on issue #4756: [Docker] update
onnx to 1.6 and torch to 1.4
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #4756: [Docker] update onnx to 1.6 and torch to 1.4
URL: https://github.com/apache/incubator-tvm/pull/4756#issuecomment-582718289
updates
- https://github.com/apache/incubator-tvm/pull/4827
- https://github.com/apache/incubator-tvm/pull/4826
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] leandron commented on issue #4756: [Docker] Update
torch version to 1.4
Posted by GitBox <gi...@apache.org>.
leandron commented on issue #4756: [Docker] Update torch version to 1.4
URL: https://github.com/apache/incubator-tvm/pull/4756#issuecomment-577296355
Hi @masahi, I think it is also relevant to see whether these change I sent a few weeks ago (https://github.com/apache/incubator-tvm/pull/4632), can be reverted by updating torch to 1.4.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] masahi commented on issue #4756: [Docker] Update
torch version to 1.4
Posted by GitBox <gi...@apache.org>.
masahi commented on issue #4756: [Docker] Update torch version to 1.4
URL: https://github.com/apache/incubator-tvm/pull/4756#issuecomment-577900368
hmm no idea why CI is failing. @leandron do you know what is going with sphinx issues?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] masahi commented on issue #4756: [Docker] update
onnx to 1.6 and torch to 1.4
Posted by GitBox <gi...@apache.org>.
masahi commented on issue #4756: [Docker] update onnx to 1.6 and torch to 1.4
URL: https://github.com/apache/incubator-tvm/pull/4756#issuecomment-581697770
@tqchen we are ready to upgrade!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on issue #4756: [Docker] update
onnx to 1.6 and torch to 1.4
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #4756: [Docker] update onnx to 1.6 and torch to 1.4
URL: https://github.com/apache/incubator-tvm/pull/4756#issuecomment-581712105
OK, will report back in one to two days
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on issue #4756: [Docker] update
onnx to 1.6 and torch to 1.4
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #4756: [Docker] update onnx to 1.6 and torch to 1.4
URL: https://github.com/apache/incubator-tvm/pull/4756#issuecomment-583153220
Only ci-cpu is updated atm. Let me know if we also need to update ci-cpu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] masahi commented on issue #4756: [Docker] Update
torch version to 1.4
Posted by GitBox <gi...@apache.org>.
masahi commented on issue #4756: [Docker] Update torch version to 1.4
URL: https://github.com/apache/incubator-tvm/pull/4756#issuecomment-581640387
@jwfromm I posted what I think is the solution to "onnx segfault problem" at https://github.com/onnx/onnx/issues/2394. I encourage you to try it with pytorch 1.3 or 1.4.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on issue #4756: [Docker] Update
torch version to 1.4
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #4756: [Docker] Update torch version to 1.4
URL: https://github.com/apache/incubator-tvm/pull/4756#issuecomment-576960115
Right now the CI update was blocked by https://github.com/apache/incubator-tvm/issues/4764, but we could build a torch update separately, depending on how quickly we can resolve the blocker.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services