You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Marcus Eriksson (Jira)" <ji...@apache.org> on 2019/11/28 08:37:00 UTC
[jira] [Comment Edited] (CASSANDRA-15076) Align record header of
FQL and audit binary log
[ https://issues.apache.org/jira/browse/CASSANDRA-15076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16984231#comment-16984231 ]
Marcus Eriksson edited comment on CASSANDRA-15076 at 11/28/19 8:36 AM:
-----------------------------------------------------------------------
-[~eperott] was preparing to commit this, but noticed [this|https://github.com/apache/cassandra/pull/372/files#diff-bdaab1104a93e723ce0b609a6477c9c4L1262-L1266] - was that included on purpose?-
edit: yep, leftover from CASSANDRA-14373
was (Author: krummas):
[~eperott] was preparing to commit this, but noticed [this|https://github.com/apache/cassandra/pull/372/files#diff-bdaab1104a93e723ce0b609a6477c9c4L1262-L1266] - was that included on purpose?
> Align record header of FQL and audit binary log
> -----------------------------------------------
>
> Key: CASSANDRA-15076
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15076
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Tools, Tool/fql
> Reporter: Per Otterström
> Assignee: Per Otterström
> Priority: Normal
> Fix For: 4.0
>
>
> The new full query logger and the audit logger support logging into binary Chronicle logs. Both create records with a small header to indicate what follows, but the two features have adopted different header formats. Let's align the record header format with this ticket.
> * Both features should use the same header layout. This makes it possible to give more user friendly error messages in the {{fqltool}} and {{auditlogviewr}} commands.
> * The record header should have a distinct {{type}} to indicate the type of record.
> * The record header should have a {{version}} so that the record format can evolve.
> Current record header format of the FQL is:
> {noformat}
> version:0(int16)
> type:<type>(text)
> {noformat}
> where {{<type>}} can be either {{batch}} or {{single-query}}.
> Current record header format of the binary audit log is:
> {noformat}
> type:AuditLog(text)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org