[GitHub] spark pull request #20096: [SPARK-22908] Add kafka source and sink for conti...

[tdas <gi...@git.apache.org>]

Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20096#discussion_r159504846
  
    --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceOffset.scala ---
    @@ -31,10 +32,14 @@ case class KafkaSourceOffset(partitionToOffsets: Map[TopicPartition, Long]) exte
       override val json = JsonUtils.partitionOffsets(partitionToOffsets)
     }
     
    +private[kafka010]
    +case class KafkaSourcePartitionOffset(topicPartition: TopicPartition, partitionOffset: Long)
    +  extends PartitionOffset
    +
     /** Companion object of the [[KafkaSourceOffset]] */
     private[kafka010] object KafkaSourceOffset {
     
    -  def getPartitionOffsets(offset: Offset): Map[TopicPartition, Long] = {
    +  def getPartitionOffsets(offset: LegacyOffset): Map[TopicPartition, Long] = {
    --- End diff --
    
    nit: can we use OffsetV1 or something like that to make the difference more obvious 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org