You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@twill.apache.org by chtyim <gi...@git.apache.org> on 2015/11/11 23:03:46 UTC

[GitHub] incubator-twill pull request: (TWILL-155) Sort file listed from di...

GitHub user chtyim opened a pull request:

    https://github.com/apache/incubator-twill/pull/71

    (TWILL-155) Sort file listed from directory in TwillLauncher

    This gives a deterministic behavior on the ClassLoader created
    by TwillLauncher

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chtyim/incubator-twill feature/twill-155

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-twill/pull/71.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #71
    
----
commit 468ab33db90cf7257625fde5f087a0c924709e28
Author: Terence Yim <ch...@apache.org>
Date:   2015-11-11T22:03:27Z

    (TWILL-155) Sort file listed from directory in TwillLauncher
    
    This gives a deterministic behavior on the ClassLoader created
    by TwillLauncher

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-twill pull request: (TWILL-155) Sort file listed from di...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-twill/pull/71


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-twill pull request: (TWILL-155) Sort file listed from di...

Posted by hsaputra <gi...@git.apache.org>.

Github user hsaputra commented on the pull request:

    https://github.com/apache/incubator-twill/pull/71#issuecomment-156005228
  
    LGTM 
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-twill pull request: (TWILL-155) Sort file listed from di...

Posted by chtyim <gi...@git.apache.org>.

Github user chtyim commented on the pull request:

    https://github.com/apache/incubator-twill/pull/71#issuecomment-156012834
  
    Thanks @hsaputra 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---