You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/14 01:23:16 UTC

[GitHub] [superset] etr2460 commented on a diff in pull request #19708: fix(nav): infinite redirect and upload dataset nav permissions

etr2460 commented on code in PR #19708:
URL: https://github.com/apache/superset/pull/19708#discussion_r850010855


##########
superset-frontend/packages/superset-ui-core/src/connection/SupersetClientClass.ts:
##########
@@ -161,7 +163,7 @@ export default class SupersetClientClass {
     headers,
     timeout,
     fetchRetryOptions,
-    ignoreUnauthorized,
+    ignoreUnauthorized = false,

Review Comment:
   I think we always want to redirect to login on a 401. 401 means that there's no auth token at all. 403 should be used if the the user is forbidden, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org