You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "WVenus (via GitHub)" <gi...@apache.org> on 2023/04/13 05:29:25 UTC
[GitHub] [apisix-ingress-controller] WVenus opened a new pull request, #1788: Chore: Upgrade Go tool chain version 1.19 to version 1.20
WVenus opened a new pull request, #1788:
URL: https://github.com/apache/apisix-ingress-controller/pull/1788
<!-- Please answer these questions before submitting a pull request -->
### Type of change:
<!-- Please delete options that are not relevant. -->
<!-- Select all the options from below that matches the type your PR best -->
- [ ] Chore
### What this PR does / why we need it:
Upgrade Go tool chain version 1.19 to version 1.20, reference (#1786)
### Pre-submission checklist:
<!--
Please follow the requirements:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. Use "request review" to notify the reviewer once you have resolved the review
-->
- [ ] Did you explain what problem does this PR solve? Or what new features have been added?
- [ ] Have you added corresponding test cases?
- [ ] Have you modified the corresponding document?
- [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix-ingress-controller#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1788: Chore: Upgrade Go tool chain version 1.19 to version 1.20
Posted by "tao12345666333 (via GitHub)" <gi...@apache.org>.
tao12345666333 commented on PR #1788:
URL: https://github.com/apache/apisix-ingress-controller/pull/1788#issuecomment-1664893345
The failed test case is unrelated to this modification, I will merge it. Thank you.
```
[FAILED]
Error Trace: /home/runner/work/apisix-ingress-controller/apisix-ingress-controller/test/e2e/suite-ingress/suite-ingress-resource/stream.go:143
/home/runner/go/pkg/mod/github.com/onsi/ginkgo/v2@v2.9.5/internal/node.go:463
/home/runner/go/pkg/mod/github.com/onsi/ginkgo/v2@v2.9.5/internal/suite.go:863
/opt/hostedtoolcache/go/1.20.6/x64/src/runtime/asm_amd64.s:1598
Error: Expected nil, but got: &net.DNSError{Err:"read udp [::1]:34936->[::1]:31846: read: connection refused", Name:"httpbin.org", Server:"127.0.0.53:53", IsTimeout:false, IsTemporary:true, IsNotFound:false}
Test: suite-ingress-resource: ApisixRoute stream Testing suite-ingress-resource: scaffold v2 stream udp proxy
Messages: dns query error
In [It] at: /home/runner/work/apisix-ingress-controller/apisix-ingress-controller/test/e2e/suite-ingress/suite-ingress-resource/stream.go:143 @ 08/04/23 01:15:58.675
Full Stack Trace
github.com/apache/apisix-ingress-controller/test/e2e/suite-ingress/suite-ingress-resource.glob..func10.1.2()
/home/runner/work/apisix-ingress-controller/apisix-ingress-controller/test/e2e/suite-ingress/suite-ingress-resource/stream.go:143 +0x537
There were additional failures detected. To view them in detail run ginkgo -vv
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #1788: Chore: Upgrade Go tool chain version 1.19 to version 1.20
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1788:
URL: https://github.com/apache/apisix-ingress-controller/pull/1788#issuecomment-1506392980
## [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1788?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1788](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1788?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (84b0ade) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/3a8fdf641cde6d0095ecee6917c35cec7193624d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3a8fdf6) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 84b0ade differs from pull request most recent head fffaa90. Consider uploading reports for the commit fffaa90 to get more accurate results
```diff
@@ Coverage Diff @@
## master #1788 +/- ##
=======================================
Coverage 39.30% 39.30%
=======================================
Files 91 91
Lines 8073 8073
=======================================
Hits 3173 3173
Misses 4494 4494
Partials 406 406
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] Gallardot commented on pull request #1788: Chore: Upgrade Go tool chain version 1.19 to version 1.20
Posted by "Gallardot (via GitHub)" <gi...@apache.org>.
Gallardot commented on PR #1788:
URL: https://github.com/apache/apisix-ingress-controller/pull/1788#issuecomment-1506747334
@WVenus
Thank you for your contribution.
Notice that CI failed. I've retried the failed job, but it still doesn't work. Before merging, you need to fix CI. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1788: Chore: Upgrade Go tool chain version 1.19 to version 1.20
Posted by "tao12345666333 (via GitHub)" <gi...@apache.org>.
tao12345666333 commented on PR #1788:
URL: https://github.com/apache/apisix-ingress-controller/pull/1788#issuecomment-1512508321
I checked the errors in CI, all of which were caused by the failure to start the coredns pod.
```
[FAILED] in [It] - /home/runner/work/apisix-ingress-controller/apisix-ingress-controller/test/e2e/suite-ingress/suite-ingress-resource/stream.go:143 @ 04/14/23 02:31:51.863
Dumping namespace contents
NAME READY UP-TO-DATE AVAILABLE AGE
deployment.apps/apisix-deployment-e2e-test 1/1 1 1 33s
deployment.apps/coredns 0/1 1 0 6s
deployment.apps/etcd-deployment-e2e-test 1/1 1 1 38s
deployment.apps/httpbin-deployment-e2e-test 1/1 1 1 28s
deployment.apps/ingress-apisix-controller-deployment-e2e-test 1/1 1 1 22s
deployment.apps/test-backend-deployment-e2e-test 1/1 1 1 26s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 merged pull request #1788: Chore: Upgrade Go tool chain version 1.19 to version 1.20
Posted by "tao12345666333 (via GitHub)" <gi...@apache.org>.
tao12345666333 merged PR #1788:
URL: https://github.com/apache/apisix-ingress-controller/pull/1788
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org