You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tinkerpop.apache.org by "Cole-Greer (via GitHub)" <gi...@apache.org> on 2023/02/03 17:57:08 UTC

[GitHub] [tinkerpop] Cole-Greer commented on pull request #1960: patch: Fixing generateUserAgent() to handle null and undefined properly

Cole-Greer commented on PR #1960:
URL: https://github.com/apache/tinkerpop/pull/1960#issuecomment-1416211415

   @iAmmarTahir Thanks that looks great! To get this merged now it will need 3 VOTE +1's from tinkerpop committers. Alternatively if it gets a single VOTE +1 and a week passes, it can be merged with "lazy consensus". You can typically expect some committers to review a PR within a couple of days.
   
   I'm not a tinkerpop committer so I cannot give an official vote here but I will give a VOTE +1 (non-binding) as I think this PR should be accepted.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org