You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@reef.apache.org by "Mariia Mykhailova (JIRA)" <ji...@apache.org> on 2015/06/22 23:33:01 UTC

[jira] [Created] (REEF-397) Fix violations of FinalClass and HideUtilityClassConstructor checkstyles

Mariia Mykhailova created REEF-397:
--------------------------------------

             Summary: Fix violations of FinalClass and HideUtilityClassConstructor checkstyles
                 Key: REEF-397
                 URL: https://issues.apache.org/jira/browse/REEF-397
             Project: REEF
          Issue Type: Sub-task
          Components: All
            Reporter: Mariia Mykhailova
            Assignee: Mariia Mykhailova
            Priority: Minor
             Fix For: 0.12


* FinalClass (if a class only has private constructors, it should be declared as final so that the intention for it to not be overridden is clear) has 11 violations, plan to add final declaration
* HideUtilityClassConstructor (if a class has only static methods/fields, it's utility and doesn't need to be instantiated) has 51 violations, plan to add private constructors / declare existing constructors private and see whether this breaks something in our code (i.e. whether we have instances of any utility classes).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)