[GH] (pekko-persistence-jdbc/remove-legacy-schema-support): Workflow run "Basic checks" failed!

[GitBox <gi...@apache.org>]

The GitHub Actions job "Basic checks" on pekko-persistence-jdbc.git/remove-legacy-schema-support has failed.
Run started by GitHub user pjfanning (triggered by pjfanning).

Head commit for run:
deaade04b34ed5802700b8f5d6222448e7db9cb3 / PJ Fanning <pj...@users.noreply.github.com>
Drop the Oracle workarounds from JournalSequenceActorTest

Motivation:
Two Oracle-only branches in JournalSequenceActorTest were written for the
legacy Oracle schema, whose insert trigger always overwrote the ordering
column from a sequence. The current EVENT_JOURNAL trigger only fires when
ordering is null, so forced inserts keep their explicit values on Oracle
as on every other database. The "assume max ordering after queryDelay *
maxTries" test therefore deleted no rows on Oracle and expected 50000
where the database held 100000.

Modification:
- Expect the inserted maximum on every database instead of halving it
  and deleting odd rows on Oracle.
- Run the "large gaps" recovery test on Oracle too; it was skipped with
  the same, now stale, reasoning about forced inserts.

Result:
The Oracle integration job passes the sequence actor tests.

Tests:
- sbt "core/testOnly *H2JournalSequenceActorTest" (4 passed)
- scalafmt; git diff --check
- Not run locally: Oracle integration tests (no local database); left to CI

References:
Refs #621

Report URL: https://github.com/apache/pekko-persistence-jdbc/actions/runs/35979311473

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org