You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/02/10 00:21:25 UTC

[GitHub] [tvm] rkimball opened a new pull request #7431: Many fixes to get unit tests passing on Windows.

rkimball opened a new pull request #7431:
URL: https://github.com/apache/tvm/pull/7431


   Not everything passes, but much more passes than used to.
   * Fixed some compiler warnings
   * nvcc working on Windows
   * CUDA codegen tests passing
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] rkimball commented on a change in pull request #7431: Many fixes to get unit tests passing on Windows.

Posted by GitBox <gi...@apache.org>.
rkimball commented on a change in pull request #7431:
URL: https://github.com/apache/tvm/pull/7431#discussion_r573355807



##########
File path: python/tvm/contrib/cc.py
##########
@@ -212,9 +214,9 @@ def _linux_compile(output, objects, options, compile_cmd="g++", compile_shared=F
         raise RuntimeError(msg)
 
 
-def _windows_shared(output, objects, options):
+def _windows_compile(output, objects, options):
     cmd = ["clang"]
-    cmd += ["-O2", "-flto=full", "-fuse-ld=lld-link"]
+    cmd += ["-O2", "-v", "-fvisibility=default", "-export-all-symbols"]

Review comment:
       Yes, there are some debug flags in there too, -v. That line needs to be cleaned up.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] tqchen commented on pull request #7431: Many fixes to get unit tests passing on Windows.

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #7431:
URL: https://github.com/apache/tvm/pull/7431#issuecomment-786145854


   Thanks @rkimball !


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] rkimball commented on a change in pull request #7431: Many fixes to get unit tests passing on Windows.

Posted by GitBox <gi...@apache.org>.
rkimball commented on a change in pull request #7431:
URL: https://github.com/apache/tvm/pull/7431#discussion_r582139400



##########
File path: python/tvm/contrib/cc.py
##########
@@ -212,9 +214,9 @@ def _linux_compile(output, objects, options, compile_cmd="g++", compile_shared=F
         raise RuntimeError(msg)
 
 
-def _windows_shared(output, objects, options):
+def _windows_compile(output, objects, options):
     cmd = ["clang"]
-    cmd += ["-O2", "-flto=full", "-fuse-ld=lld-link"]
+    cmd += ["-O2", "-v", "-fvisibility=default", "-export-all-symbols"]

Review comment:
       The current code in the PR only has the flag `-O2`. The other flags are not required.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] tqchen merged pull request #7431: Many fixes to get unit tests passing on Windows.

Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #7431:
URL: https://github.com/apache/tvm/pull/7431


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] tqchen commented on a change in pull request #7431: Many fixes to get unit tests passing on Windows.

Posted by GitBox <gi...@apache.org>.
tqchen commented on a change in pull request #7431:
URL: https://github.com/apache/tvm/pull/7431#discussion_r574865652



##########
File path: python/tvm/contrib/cc.py
##########
@@ -212,9 +214,9 @@ def _linux_compile(output, objects, options, compile_cmd="g++", compile_shared=F
         raise RuntimeError(msg)
 
 
-def _windows_shared(output, objects, options):
+def _windows_compile(output, objects, options):
     cmd = ["clang"]
-    cmd += ["-O2", "-flto=full", "-fuse-ld=lld-link"]
+    cmd += ["-O2", "-v", "-fvisibility=default", "-export-all-symbols"]

Review comment:
       OK, thanks, please add a comment about the need of debug flags there.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] tqchen commented on a change in pull request #7431: Many fixes to get unit tests passing on Windows.

Posted by GitBox <gi...@apache.org>.
tqchen commented on a change in pull request #7431:
URL: https://github.com/apache/tvm/pull/7431#discussion_r573354069



##########
File path: python/tvm/contrib/cc.py
##########
@@ -212,9 +214,9 @@ def _linux_compile(output, objects, options, compile_cmd="g++", compile_shared=F
         raise RuntimeError(msg)
 
 
-def _windows_shared(output, objects, options):
+def _windows_compile(output, objects, options):
     cmd = ["clang"]
-    cmd += ["-O2", "-flto=full", "-fuse-ld=lld-link"]
+    cmd += ["-O2", "-v", "-fvisibility=default", "-export-all-symbols"]

Review comment:
       Can we check if we need `-export-all-symbols` after https://github.com/apache/tvm/pull/6698? I believe we should have marked the life scopes correctly.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org