You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/07/10 17:59:08 UTC

[GitHub] [apisix] KishaniKandasamy opened a new pull request #4582: docs: fix incorrect link

KishaniKandasamy opened a new pull request #4582:
URL: https://github.com/apache/apisix/pull/4582


   ### What this PR does / why we need it:
   Update incorrect link in zh docs
   fix: [399](https://github.com/apache/apisix-website/issues/399)
   ### Pre-submission checklist:
   
   * [x] Did you explain what problem does this PR solve? Or what new features have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] KishaniKandasamy commented on a change in pull request #4582: docs: fix incorrect link

Posted by GitBox <gi...@apache.org>.
KishaniKandasamy commented on a change in pull request #4582:
URL: https://github.com/apache/apisix/pull/4582#discussion_r668392885



##########
File path: docs/zh/latest/admin-api.md
##########
@@ -39,7 +39,7 @@ title: Admin API
 
 Admin API 是为 Apache APISIX 服务的一组 API,我们可以将参数传递给 Admin API 以控制 APISIX 节点。更好地了解其工作原理,请参阅 [architecture-design](./architecture-design/apisix.md) 中的文档。
 
-启动 Apache APISIX 时,默认情况下 Admin API 将监听 `9080` 端口(HTTPS 的 `9443` 端口)。您可以通过修改 [conf/config.yaml](../../../conf/config.yaml) 文件来改变默认监听的端口。
+启动 Apache APISIX 时,默认情况下 Admin API 将监听 `9080` 端口(HTTPS 的 `9443` 端口)。您可以通过修改 [conf/config.yaml](https://github.com/apache/apisix/blob/master/conf/config.yaml) 文件来改变默认监听的端口。

Review comment:
       @tokers  The relative link of  config.yaml github page  in this markdown hasn't been directed to intended path in our website.So what about using https://github.com/apache/apisix/blob/master/conf/config.yaml ?
   ![my](https://user-images.githubusercontent.com/53715187/125625801-0e3ef8f0-567f-45d9-9477-8149b2bd095b.jpg)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] KishaniKandasamy commented on a change in pull request #4582: docs: fix incorrect link

Posted by GitBox <gi...@apache.org>.
KishaniKandasamy commented on a change in pull request #4582:
URL: https://github.com/apache/apisix/pull/4582#discussion_r669598499



##########
File path: docs/zh/latest/admin-api.md
##########
@@ -39,7 +39,7 @@ title: Admin API
 
 Admin API 是为 Apache APISIX 服务的一组 API,我们可以将参数传递给 Admin API 以控制 APISIX 节点。更好地了解其工作原理,请参阅 [architecture-design](./architecture-design/apisix.md) 中的文档。
 
-启动 Apache APISIX 时,默认情况下 Admin API 将监听 `9080` 端口(HTTPS 的 `9443` 端口)。您可以通过修改 [conf/config.yaml](../../../conf/config.yaml) 文件来改变默认监听的端口。
+启动 Apache APISIX 时,默认情况下 Admin API 将监听 `9080` 端口(HTTPS 的 `9443` 端口)。您可以通过修改 [conf/config.yaml](https://github.com/apache/apisix/blob/master/conf/config.yaml) 文件来改变默认监听的端口。

Review comment:
       Since the same change was made to Eng docs It isn't  fixed .I don't know why still  Page Not Found 😕😕
   ![ki](https://user-images.githubusercontent.com/53715187/125627096-2c4dfba1-2f74-4c55-bbb6-0713be02d5b4.jpg)
    




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] KishaniKandasamy commented on a change in pull request #4582: docs: fix incorrect link

Posted by GitBox <gi...@apache.org>.
KishaniKandasamy commented on a change in pull request #4582:
URL: https://github.com/apache/apisix/pull/4582#discussion_r669584693



##########
File path: docs/zh/latest/admin-api.md
##########
@@ -39,7 +39,7 @@ title: Admin API
 
 Admin API 是为 Apache APISIX 服务的一组 API,我们可以将参数传递给 Admin API 以控制 APISIX 节点。更好地了解其工作原理,请参阅 [architecture-design](./architecture-design/apisix.md) 中的文档。
 
-启动 Apache APISIX 时,默认情况下 Admin API 将监听 `9080` 端口(HTTPS 的 `9443` 端口)。您可以通过修改 [conf/config.yaml](../../../conf/config.yaml) 文件来改变默认监听的端口。

Review comment:
       Really  Sorry It is a mistake ..actually wanted to change it as conf/config.yaml->config.yaml




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] spacewander commented on a change in pull request #4582: docs: fix incorrect link

Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #4582:
URL: https://github.com/apache/apisix/pull/4582#discussion_r668709338



##########
File path: docs/zh/latest/admin-api.md
##########
@@ -39,7 +39,7 @@ title: Admin API
 
 Admin API 是为 Apache APISIX 服务的一组 API,我们可以将参数传递给 Admin API 以控制 APISIX 节点。更好地了解其工作原理,请参阅 [architecture-design](./architecture-design/apisix.md) 中的文档。
 
-启动 Apache APISIX 时,默认情况下 Admin API 将监听 `9080` 端口(HTTPS 的 `9443` 端口)。您可以通过修改 [conf/config.yaml](../../../conf/config.yaml) 文件来改变默认监听的端口。

Review comment:
       Why remove the extension name?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] tokers commented on a change in pull request #4582: docs: fix incorrect link

Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #4582:
URL: https://github.com/apache/apisix/pull/4582#discussion_r667591999



##########
File path: docs/zh/latest/admin-api.md
##########
@@ -39,7 +39,7 @@ title: Admin API
 
 Admin API 是为 Apache APISIX 服务的一组 API,我们可以将参数传递给 Admin API 以控制 APISIX 节点。更好地了解其工作原理,请参阅 [architecture-design](./architecture-design/apisix.md) 中的文档。
 
-启动 Apache APISIX 时,默认情况下 Admin API 将监听 `9080` 端口(HTTPS 的 `9443` 端口)。您可以通过修改 [conf/config.yaml](../../../conf/config.yaml) 文件来改变默认监听的端口。
+启动 Apache APISIX 时,默认情况下 Admin API 将监听 `9080` 端口(HTTPS 的 `9443` 端口)。您可以通过修改 [conf/config.yaml](https://github.com/apache/apisix/blob/master/conf/config.yaml) 文件来改变默认监听的端口。

Review comment:
       Why not use a relative link? We cannot redirect to this doc in the current branch if we use this link.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] spacewander commented on a change in pull request #4582: docs: fix incorrect link

Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #4582:
URL: https://github.com/apache/apisix/pull/4582#discussion_r669590867



##########
File path: docs/zh/latest/admin-api.md
##########
@@ -39,7 +39,7 @@ title: Admin API
 
 Admin API 是为 Apache APISIX 服务的一组 API,我们可以将参数传递给 Admin API 以控制 APISIX 节点。更好地了解其工作原理,请参阅 [architecture-design](./architecture-design/apisix.md) 中的文档。
 
-启动 Apache APISIX 时,默认情况下 Admin API 将监听 `9080` 端口(HTTPS 的 `9443` 端口)。您可以通过修改 [conf/config.yaml](../../../conf/config.yaml) 文件来改变默认监听的端口。

Review comment:
       It should be the same as the English one.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] spacewander commented on a change in pull request #4582: docs: fix incorrect link

Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #4582:
URL: https://github.com/apache/apisix/pull/4582#discussion_r670053993



##########
File path: docs/zh/latest/admin-api.md
##########
@@ -39,7 +39,7 @@ title: Admin API
 
 Admin API 是为 Apache APISIX 服务的一组 API,我们可以将参数传递给 Admin API 以控制 APISIX 节点。更好地了解其工作原理,请参阅 [architecture-design](./architecture-design/apisix.md) 中的文档。
 
-启动 Apache APISIX 时,默认情况下 Admin API 将监听 `9080` 端口(HTTPS 的 `9443` 端口)。您可以通过修改 [conf/config.yaml](../../../conf/config.yaml) 文件来改变默认监听的端口。
+启动 Apache APISIX 时,默认情况下 Admin API 将监听 `9080` 端口(HTTPS 的 `9443` 端口)。您可以通过修改 [conf/config.yaml](https://github.com/apache/apisix/blob/master/conf/config.yaml) 文件来改变默认监听的端口。

Review comment:
       Maybe @juzhiyuan can help?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] KishaniKandasamy commented on a change in pull request #4582: docs: fix incorrect link

Posted by GitBox <gi...@apache.org>.
KishaniKandasamy commented on a change in pull request #4582:
URL: https://github.com/apache/apisix/pull/4582#discussion_r668392885



##########
File path: docs/zh/latest/admin-api.md
##########
@@ -39,7 +39,7 @@ title: Admin API
 
 Admin API 是为 Apache APISIX 服务的一组 API,我们可以将参数传递给 Admin API 以控制 APISIX 节点。更好地了解其工作原理,请参阅 [architecture-design](./architecture-design/apisix.md) 中的文档。
 
-启动 Apache APISIX 时,默认情况下 Admin API 将监听 `9080` 端口(HTTPS 的 `9443` 端口)。您可以通过修改 [conf/config.yaml](../../../conf/config.yaml) 文件来改变默认监听的端口。
+启动 Apache APISIX 时,默认情况下 Admin API 将监听 `9080` 端口(HTTPS 的 `9443` 端口)。您可以通过修改 [conf/config.yaml](https://github.com/apache/apisix/blob/master/conf/config.yaml) 文件来改变默认监听的端口。

Review comment:
       Okay




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] KishaniKandasamy commented on a change in pull request #4582: docs: fix incorrect link

Posted by GitBox <gi...@apache.org>.
KishaniKandasamy commented on a change in pull request #4582:
URL: https://github.com/apache/apisix/pull/4582#discussion_r675630915



##########
File path: docs/zh/latest/admin-api.md
##########
@@ -39,7 +39,7 @@ title: Admin API
 
 Admin API 是为 Apache APISIX 服务的一组 API,我们可以将参数传递给 Admin API 以控制 APISIX 节点。更好地了解其工作原理,请参阅 [architecture-design](./architecture-design/apisix.md) 中的文档。
 
-启动 Apache APISIX 时,默认情况下 Admin API 将监听 `9080` 端口(HTTPS 的 `9443` 端口)。您可以通过修改 [conf/config.yaml](../../../conf/config.yaml) 文件来改变默认监听的端口。
+启动 Apache APISIX 时,默认情况下 Admin API 将监听 `9080` 端口(HTTPS 的 `9443` 端口)。您可以通过修改 [conf/config.yaml](https://github.com/apache/apisix/blob/master/conf/config.yaml) 文件来改变默认监听的端口。

Review comment:
       Ok👍




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] juzhiyuan commented on a change in pull request #4582: docs: fix incorrect link

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #4582:
URL: https://github.com/apache/apisix/pull/4582#discussion_r670104193



##########
File path: docs/zh/latest/admin-api.md
##########
@@ -39,7 +39,7 @@ title: Admin API
 
 Admin API 是为 Apache APISIX 服务的一组 API,我们可以将参数传递给 Admin API 以控制 APISIX 节点。更好地了解其工作原理,请参阅 [architecture-design](./architecture-design/apisix.md) 中的文档。
 
-启动 Apache APISIX 时,默认情况下 Admin API 将监听 `9080` 端口(HTTPS 的 `9443` 端口)。您可以通过修改 [conf/config.yaml](../../../conf/config.yaml) 文件来改变默认监听的端口。
+启动 Apache APISIX 时,默认情况下 Admin API 将监听 `9080` 端口(HTTPS 的 `9443` 端口)。您可以通过修改 [conf/config.yaml](https://github.com/apache/apisix/blob/master/conf/config.yaml) 文件来改变默认监听的端口。

Review comment:
       @KishaniKandasamy see this link https://docusaurus.io/docs/docs-markdown-features , and then try searching `docusarus relative links`, if still not work, let me know.

##########
File path: docs/zh/latest/admin-api.md
##########
@@ -39,7 +39,7 @@ title: Admin API
 
 Admin API 是为 Apache APISIX 服务的一组 API,我们可以将参数传递给 Admin API 以控制 APISIX 节点。更好地了解其工作原理,请参阅 [architecture-design](./architecture-design/apisix.md) 中的文档。
 
-启动 Apache APISIX 时,默认情况下 Admin API 将监听 `9080` 端口(HTTPS 的 `9443` 端口)。您可以通过修改 [conf/config.yaml](../../../conf/config.yaml) 文件来改变默认监听的端口。
+启动 Apache APISIX 时,默认情况下 Admin API 将监听 `9080` 端口(HTTPS 的 `9443` 端口)。您可以通过修改 [conf/config.yaml](https://github.com/apache/apisix/blob/master/conf/config.yaml) 文件来改变默认监听的端口。

Review comment:
       @KishaniKandasamy see this link https://docusaurus.io/docs/docs-markdown-features , and then try searching `docusarus relative links`, if still not work, let me know.
   
   cc @iamayushdas 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] spacewander merged pull request #4582: docs: fix incorrect link

Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #4582:
URL: https://github.com/apache/apisix/pull/4582


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org