You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/02 08:28:17 UTC

[GitHub] [spark] JoshRosen commented on a change in pull request #27754: [SPARK-31003][TESTS] Fix incorrect uses of assume() in tests

JoshRosen commented on a change in pull request #27754: [SPARK-31003][TESTS] Fix incorrect uses of assume() in tests
URL: https://github.com/apache/spark/pull/27754#discussion_r386250490
 
 

 ##########
 File path: core/src/test/scala/org/apache/spark/storage/LocalDirsSuite.scala
 ##########
 @@ -39,7 +39,7 @@ class LocalDirsSuite extends SparkFunSuite with BeforeAndAfter {
 
   private def assumeNonExistentAndNotCreatable(f: File): Unit = {
     try {
-      assume(!f.exists() && !f.mkdirs())
+      assert(!f.exists() && !f.mkdirs())
 
 Review comment:
   I've reverted this line.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org