You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/15 13:16:33 UTC
[GitHub] [flink] hequn8128 opened a new pull request #13156: [FLINK-18949][python] Support Streaming File Sink for Python DataStream API
hequn8128 opened a new pull request #13156:
URL: https://github.com/apache/flink/pull/13156
## What is the purpose of the change
This pull request supports StreamingFileSink on Python DataStream API. Row-encoded Formats is only supported in this PR, i.e., Bulk-encoded Formats are not supported.
## Brief change log
- Add StreamingFileSink on Python API.
- Add Row-encoded Formats related APIs.
## Verifying this change
This change added tests and can be verified as follows:
- Added `test_stream_file_sink` integration tests in test_data_stream
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (yes)
- If yes, how is the feature documented? (PythonDocs)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] shuiqiangchen commented on a change in pull request #13156: [FLINK-18949][python] Support Streaming File Sink for Python DataStream API
Posted by GitBox <gi...@apache.org>.
shuiqiangchen commented on a change in pull request #13156:
URL: https://github.com/apache/flink/pull/13156#discussion_r471874945
##########
File path: flink-python/pyflink/common/serialization.py
##########
@@ -365,3 +365,27 @@ def __init__(self, record_class: str = None, avro_schema_string: str = None):
j_serialization_schema = JAvroRowSerializationSchema(avro_schema_string)
super(AvroRowSerializationSchema, self).__init__(j_serialization_schema)
+
+
+class Encoder(object):
+ """
+ A `Encoder` is used by the streaming file sink to perform the actual writing
+ of the incoming elements to the files in a bucket.
+ """
+
+ def __init__(self, j_encoder):
+ self.j_encoder = j_encoder
Review comment:
For extensibility, it would be better to support passing a fully-qualified class name of user defined java encoder. In the future, we can provide such a common util for this series of constructors that uses either can pass a string or a java object.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13156: [FLINK-18949][python] Support Streaming File Sink for Python DataStream API
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13156:
URL: https://github.com/apache/flink/pull/13156#issuecomment-674395551
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 2ee1d96a5033c05e21ddd43004784e63a3fd8c61 (Sat Aug 15 13:18:36 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13156: [FLINK-18949][python] Support Streaming File Sink for Python DataStream API
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13156:
URL: https://github.com/apache/flink/pull/13156#issuecomment-674396240
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ee1d96a5033c05e21ddd43004784e63a3fd8c61",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5553",
"triggerID" : "2ee1d96a5033c05e21ddd43004784e63a3fd8c61",
"triggerType" : "PUSH"
}, {
"hash" : "5f32c5179e7dd108a51bdc261187966b1017b662",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5640",
"triggerID" : "5f32c5179e7dd108a51bdc261187966b1017b662",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2ee1d96a5033c05e21ddd43004784e63a3fd8c61 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5553)
* 5f32c5179e7dd108a51bdc261187966b1017b662 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5640)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] hequn8128 commented on pull request #13156: [FLINK-18949][python] Support Streaming File Sink for Python DataStream API
Posted by GitBox <gi...@apache.org>.
hequn8128 commented on pull request #13156:
URL: https://github.com/apache/flink/pull/13156#issuecomment-675217107
@shuiqiangchen Thanks a lot for your review and suggestions. I have updated the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] hequn8128 merged pull request #13156: [FLINK-18949][python] Support Streaming File Sink for Python DataStream API
Posted by GitBox <gi...@apache.org>.
hequn8128 merged pull request #13156:
URL: https://github.com/apache/flink/pull/13156
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13156: [FLINK-18949][python] Support Streaming File Sink for Python DataStream API
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13156:
URL: https://github.com/apache/flink/pull/13156#issuecomment-674396240
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ee1d96a5033c05e21ddd43004784e63a3fd8c61",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5553",
"triggerID" : "2ee1d96a5033c05e21ddd43004784e63a3fd8c61",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2ee1d96a5033c05e21ddd43004784e63a3fd8c61 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5553)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13156: [FLINK-18949][python] Support Streaming File Sink for Python DataStream API
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13156:
URL: https://github.com/apache/flink/pull/13156#issuecomment-674396240
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ee1d96a5033c05e21ddd43004784e63a3fd8c61",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5553",
"triggerID" : "2ee1d96a5033c05e21ddd43004784e63a3fd8c61",
"triggerType" : "PUSH"
}, {
"hash" : "5f32c5179e7dd108a51bdc261187966b1017b662",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5640",
"triggerID" : "5f32c5179e7dd108a51bdc261187966b1017b662",
"triggerType" : "PUSH"
}, {
"hash" : "fa6e899b08f75c99871c23d5b129af36bb655830",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5647",
"triggerID" : "fa6e899b08f75c99871c23d5b129af36bb655830",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2ee1d96a5033c05e21ddd43004784e63a3fd8c61 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5553)
* 5f32c5179e7dd108a51bdc261187966b1017b662 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5640)
* fa6e899b08f75c99871c23d5b129af36bb655830 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5647)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13156: [FLINK-18949][python] Support Streaming File Sink for Python DataStream API
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13156:
URL: https://github.com/apache/flink/pull/13156#issuecomment-674396240
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ee1d96a5033c05e21ddd43004784e63a3fd8c61",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5553",
"triggerID" : "2ee1d96a5033c05e21ddd43004784e63a3fd8c61",
"triggerType" : "PUSH"
}, {
"hash" : "5f32c5179e7dd108a51bdc261187966b1017b662",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5640",
"triggerID" : "5f32c5179e7dd108a51bdc261187966b1017b662",
"triggerType" : "PUSH"
}, {
"hash" : "fa6e899b08f75c99871c23d5b129af36bb655830",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa6e899b08f75c99871c23d5b129af36bb655830",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2ee1d96a5033c05e21ddd43004784e63a3fd8c61 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5553)
* 5f32c5179e7dd108a51bdc261187966b1017b662 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5640)
* fa6e899b08f75c99871c23d5b129af36bb655830 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13156: [FLINK-18949][python] Support Streaming File Sink for Python DataStream API
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13156:
URL: https://github.com/apache/flink/pull/13156#issuecomment-674396240
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ee1d96a5033c05e21ddd43004784e63a3fd8c61",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5553",
"triggerID" : "2ee1d96a5033c05e21ddd43004784e63a3fd8c61",
"triggerType" : "PUSH"
}, {
"hash" : "5f32c5179e7dd108a51bdc261187966b1017b662",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5640",
"triggerID" : "5f32c5179e7dd108a51bdc261187966b1017b662",
"triggerType" : "PUSH"
}, {
"hash" : "fa6e899b08f75c99871c23d5b129af36bb655830",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5647",
"triggerID" : "fa6e899b08f75c99871c23d5b129af36bb655830",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5f32c5179e7dd108a51bdc261187966b1017b662 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5640)
* fa6e899b08f75c99871c23d5b129af36bb655830 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5647)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13156: [FLINK-18949][python] Support Streaming File Sink for Python DataStream API
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13156:
URL: https://github.com/apache/flink/pull/13156#issuecomment-674396240
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ee1d96a5033c05e21ddd43004784e63a3fd8c61",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5553",
"triggerID" : "2ee1d96a5033c05e21ddd43004784e63a3fd8c61",
"triggerType" : "PUSH"
}, {
"hash" : "5f32c5179e7dd108a51bdc261187966b1017b662",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5f32c5179e7dd108a51bdc261187966b1017b662",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2ee1d96a5033c05e21ddd43004784e63a3fd8c61 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5553)
* 5f32c5179e7dd108a51bdc261187966b1017b662 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13156: [FLINK-18949][python] Support Streaming File Sink for Python DataStream API
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13156:
URL: https://github.com/apache/flink/pull/13156#issuecomment-674396240
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ee1d96a5033c05e21ddd43004784e63a3fd8c61",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2ee1d96a5033c05e21ddd43004784e63a3fd8c61",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2ee1d96a5033c05e21ddd43004784e63a3fd8c61 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13156: [FLINK-18949][python] Support Streaming File Sink for Python DataStream API
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13156:
URL: https://github.com/apache/flink/pull/13156#issuecomment-674396240
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2ee1d96a5033c05e21ddd43004784e63a3fd8c61",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5553",
"triggerID" : "2ee1d96a5033c05e21ddd43004784e63a3fd8c61",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2ee1d96a5033c05e21ddd43004784e63a3fd8c61 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5553)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org