You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/09/28 17:33:14 UTC
[GitHub] [pulsar-client-go] zzzming opened a new pull request #373: [PR366] Make sure reconnectToBroker invoked before tearing down connection
zzzming opened a new pull request #373:
URL: https://github.com/apache/pulsar-client-go/pull/373
<--
### Contribution Checklist
Master Issue: https://github.com/apache/pulsar-client-go/pull/366
### Motivation
We have seen consumer hanging issues reported similar to https://github.com/apache/pulsar-client-go/pull/366
Consumer was unable to reconnect to broker under these conditions
- multiple consumers with shared subscriptions
- topic is unloaded and reloaded to another broker due to load balancing
As @jiazhai pointed that partition consumer's reconnectToBroker() may have never been invoked due to deadlock of closed Connection. This is described at the end of PR 366 comments.
### Modifications
Reorganize the code to ensure consumer and producer handlers are closed before the connection is torn down, so that broker reconnect mechanism can run independently to retry until successful or reach the retry limit.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change is already covered by existing tests, such as *(please describe tests)*.
### Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
### Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
- If a feature is not applicable for documentation, explain why?
This is not a feature but a bug fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] wolfstudy commented on pull request #373: [PR366] Make sure reconnectToBroker invoked before tearing down connection
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #373:
URL: https://github.com/apache/pulsar-client-go/pull/373#issuecomment-706463619
The issue will be fixed in https://github.com/apache/pulsar-client-go/pull/376, will close this pull request, thanks @zzzming work for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] wolfstudy closed pull request #373: [PR366] Make sure reconnectToBroker invoked before tearing down connection
Posted by GitBox <gi...@apache.org>.
wolfstudy closed pull request #373:
URL: https://github.com/apache/pulsar-client-go/pull/373
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org