You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/03/01 08:49:11 UTC

[GitHub] [ignite-3] korlov42 commented on a change in pull request #692: IGNITE-16558 Sql schema synchronization

korlov42 commented on a change in pull request #692:
URL: https://github.com/apache/ignite-3/pull/692#discussion_r816560515



##########
File path: modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/rel/IgniteTableModify.java
##########
@@ -117,6 +117,8 @@ public IgniteRel clone(RelOptCluster cluster, List<IgniteRel> inputs) {
     public RelWriter explainTerms(RelWriter pw) {
         return super.explainTerms(pw)
                 .itemIf("tableId", getTable().unwrap(InternalIgniteTable.class).id().toString(),
+                        pw.getDetailLevel() == ALL_ATTRIBUTES)

Review comment:
       It's kinda mess here. In fact, we are using `ALL_ATTRIBUTES` in plan serialisation as well as in plan explanation. So, I'he changed `ProjectableFilterableTableScan#explainTerms` to be consistent with TableModify rel.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org