You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by hsaputra <gi...@git.apache.org> on 2015/08/12 18:26:39 UTC
[GitHub] flink pull request: [CLEANUP] Add space between quotes and plus si...
GitHub user hsaputra opened a pull request:
https://github.com/apache/flink/pull/1010
[CLEANUP] Add space between quotes and plus sign in String concat for readability in flink-yarn module
While working on Flink on YARN, do some simple nit cleanups to add space between quote and plus sign for readability in yarn module for readability.
Use StringBuilder instad of StringBuffer in FlinkYarnClient since the String materializes immediately, so no need synchronize protection.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hsaputra/flink cleanup_yarn_branch
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1010.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1010
----
commit a6fc9e132e463d9605467296f0a57e8e2d91d47b
Author: hsaputra <hs...@apache.org>
Date: 2015-08-11T20:43:00Z
Add space between quote and plus sign for readability in flink-yarn module.
Use StringBuilder instad of StringBuffer in FlinkYarnClient since the String materializes immediately.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [CLEANUP] Add space between quotes and plus si...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/1010#issuecomment-130386385
+1
We agree that we would play it loose with style but this kind of cleanup helps readability.
I will send PR to change the check style to be more strict on this kind of violations.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [CLEANUP] Add space between quotes and plus si...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1010#issuecomment-130633384
Thanks Henry, please add this rule. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [CLEANUP] Add space between quotes and plus si...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1010#issuecomment-131770992
+1 for adding a rule (otherwise, I will not learn it ;) )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [CLEANUP] Add space between quotes and plus si...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/1010#issuecomment-130443578
Thanks @StephanEwen merging ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [CLEANUP] Add space between quotes and plus si...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/1010#issuecomment-132005060
Thanks all, will do
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [CLEANUP] Add space between quotes and plus si...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1010#issuecomment-130383158
I like this.
I would actually like to make this a checkstyle rule. Most of the code is in this shape, occasional files go with a different style.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [CLEANUP] Add space between quotes and plus si...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1010#issuecomment-130415584
+1, good to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [CLEANUP] Add space between quotes and plus si...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/1010#issuecomment-130386480
Builds pass, will merge this EOD if no more comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [CLEANUP] Add space between quotes and plus si...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1010
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---