[GitHub] [incubator-mxnet] szha commented on a change in pull request #16207: Bump numpy version >=1.17.0

[GitBox <gi...@apache.org>]

szha commented on a change in pull request #16207: Bump numpy version >=1.17.0
URL: https://github.com/apache/incubator-mxnet/pull/16207#discussion_r336814314
 
 

 ##########
 File path: python/setup.py
 ##########
 @@ -30,7 +30,12 @@
 else:
     from setuptools import setup
     from setuptools.extension import Extension
-    kwargs = {'install_requires': ['numpy>1.16.0,<2.0.0', 'requests>=2.20.0,<3', 'graphviz<0.9.0,>=0.8.1'], 'zip_safe': False}
+    kwargs = {
+        'install_requires': ['requests>=2.20.0,<3', 'graphviz<0.9.0,>=0.8.1']
+            .append('numpy>=1.17.0,<2.0.0' if sys.version_info.major >= 3 and sys.version_info.minor >= 5
+                    else 'numpy>1.16.0,<2.0.0'),
 
 Review comment:
   what's the concern for just switching to `>= 1.17`? was it CI?
   setup.py may be evaluated on a platform that builds binary distributions that is different from the platform on which the distribution is installed. in this scenario, the condition won't be evaluated on the target platform

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services