You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/05/17 16:24:54 UTC

[GitHub] [incubator-druid] leventov commented on a change in pull request #7681: Add checkstyle for "Local variable names shouldn't start with capital"

leventov commented on a change in pull request #7681: Add checkstyle for "Local variable names shouldn't start with capital"
URL: https://github.com/apache/incubator-druid/pull/7681#discussion_r285197147
 
 

 ##########
 File path: server/src/main/java/org/apache/druid/server/StatusResource.java
 ##########
 @@ -134,18 +134,18 @@ public Memory getMemory()
     @Override
     public String toString()
     {
-      final String NL = System.getProperty("line.separator");
+      final String lineSeparator = System.getProperty("line.separator");
 
 Review comment:
   Please extract a constant, `StringUtils` may be a good place for it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org