You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Chris Goffinet (JIRA)" <ji...@apache.org> on 2009/11/25 03:02:39 UTC
[jira] Created: (CASSANDRA-581) RandomPartitioner
convertFromDiskFormat is slow
RandomPartitioner convertFromDiskFormat is slow
-----------------------------------------------
Key: CASSANDRA-581
URL: https://issues.apache.org/jira/browse/CASSANDRA-581
Project: Cassandra
Issue Type: Bug
Affects Versions: 0.5
Reporter: Chris Goffinet
Assignee: Chris Goffinet
Priority: Minor
Fix For: 0.5
Attachments: 0001-Make-convertFromDiskFormat-use-substring-over-split-.patch
convertFromDiskFormat in RandomPartitioner is slow. It uses split. We were testing with 1000+ keys using multi-get on a local node. We saw on average 200ms~, with the applied patch it went down to 76ms~.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-581) RandomPartitioner
convertFromDiskFormat is slow
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12782278#action_12782278 ]
Stu Hood commented on CASSANDRA-581:
------------------------------------
+1 Looks good to me.
> RandomPartitioner convertFromDiskFormat is slow
> -----------------------------------------------
>
> Key: CASSANDRA-581
> URL: https://issues.apache.org/jira/browse/CASSANDRA-581
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.5
> Reporter: Chris Goffinet
> Assignee: Chris Goffinet
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 0001-Make-convertFromDiskFormat-use-substring-over-split-.patch
>
>
> convertFromDiskFormat in RandomPartitioner is slow. It uses split. We were testing with 1000+ keys using multi-get on a local node. We saw on average 200ms~, with the applied patch it went down to 76ms~.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-581) RandomPartitioner
convertFromDiskFormat is slow
Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Goffinet updated CASSANDRA-581:
-------------------------------------
Attachment: 0001-Make-convertFromDiskFormat-use-substring-over-split-.patch
> RandomPartitioner convertFromDiskFormat is slow
> -----------------------------------------------
>
> Key: CASSANDRA-581
> URL: https://issues.apache.org/jira/browse/CASSANDRA-581
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.5
> Reporter: Chris Goffinet
> Assignee: Chris Goffinet
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 0001-Make-convertFromDiskFormat-use-substring-over-split-.patch
>
>
> convertFromDiskFormat in RandomPartitioner is slow. It uses split. We were testing with 1000+ keys using multi-get on a local node. We saw on average 200ms~, with the applied patch it went down to 76ms~.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-581) RandomPartitioner
convertFromDiskFormat is slow
Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Goffinet updated CASSANDRA-581:
-------------------------------------
Attachment: (was: 0001-Make-convertFromDiskFormat-use-substring-over-split-.patch)
> RandomPartitioner convertFromDiskFormat is slow
> -----------------------------------------------
>
> Key: CASSANDRA-581
> URL: https://issues.apache.org/jira/browse/CASSANDRA-581
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.5
> Reporter: Chris Goffinet
> Assignee: Chris Goffinet
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 0001-Make-convertFromDiskFormat-use-substring-over-split-.patch
>
>
> convertFromDiskFormat in RandomPartitioner is slow. It uses split. We were testing with 1000+ keys using multi-get on a local node. We saw on average 200ms~, with the applied patch it went down to 76ms~.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-581) RandomPartitioner
convertFromDiskFormat is slow
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12782291#action_12782291 ]
Jonathan Ellis commented on CASSANDRA-581:
------------------------------------------
Can you add a test that catches the +1 bug? This is definitely "should be covered by the test suite" area.
> RandomPartitioner convertFromDiskFormat is slow
> -----------------------------------------------
>
> Key: CASSANDRA-581
> URL: https://issues.apache.org/jira/browse/CASSANDRA-581
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.5
> Reporter: Chris Goffinet
> Assignee: Chris Goffinet
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 0001-Make-convertFromDiskFormat-use-substring-over-split-.patch
>
>
> convertFromDiskFormat in RandomPartitioner is slow. It uses split. We were testing with 1000+ keys using multi-get on a local node. We saw on average 200ms~, with the applied patch it went down to 76ms~.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-581) RandomPartitioner
convertFromDiskFormat is slow
Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12782280#action_12782280 ]
Chris Goffinet commented on CASSANDRA-581:
------------------------------------------
Forgot the +1 on the splitPoint for second.
> RandomPartitioner convertFromDiskFormat is slow
> -----------------------------------------------
>
> Key: CASSANDRA-581
> URL: https://issues.apache.org/jira/browse/CASSANDRA-581
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.5
> Reporter: Chris Goffinet
> Assignee: Chris Goffinet
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 0001-Make-convertFromDiskFormat-use-substring-over-split-.patch
>
>
> convertFromDiskFormat in RandomPartitioner is slow. It uses split. We were testing with 1000+ keys using multi-get on a local node. We saw on average 200ms~, with the applied patch it went down to 76ms~.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CASSANDRA-581) RandomPartitioner
convertFromDiskFormat is slow
Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Goffinet resolved CASSANDRA-581.
--------------------------------------
Resolution: Fixed
> RandomPartitioner convertFromDiskFormat is slow
> -----------------------------------------------
>
> Key: CASSANDRA-581
> URL: https://issues.apache.org/jira/browse/CASSANDRA-581
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.5
> Reporter: Chris Goffinet
> Assignee: Chris Goffinet
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 0001-Make-convertFromDiskFormat-use-substring-over-split-.patch
>
>
> convertFromDiskFormat in RandomPartitioner is slow. It uses split. We were testing with 1000+ keys using multi-get on a local node. We saw on average 200ms~, with the applied patch it went down to 76ms~.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-581) RandomPartitioner
convertFromDiskFormat is slow
Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Goffinet updated CASSANDRA-581:
-------------------------------------
Attachment: 0001-Make-convertFromDiskFormat-use-substring-over-split-.patch
> RandomPartitioner convertFromDiskFormat is slow
> -----------------------------------------------
>
> Key: CASSANDRA-581
> URL: https://issues.apache.org/jira/browse/CASSANDRA-581
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.5
> Reporter: Chris Goffinet
> Assignee: Chris Goffinet
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 0001-Make-convertFromDiskFormat-use-substring-over-split-.patch
>
>
> convertFromDiskFormat in RandomPartitioner is slow. It uses split. We were testing with 1000+ keys using multi-get on a local node. We saw on average 200ms~, with the applied patch it went down to 76ms~.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-581) RandomPartitioner
convertFromDiskFormat is slow
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786392#action_12786392 ]
Hudson commented on CASSANDRA-581:
----------------------------------
Integrated in Cassandra #278 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/278/])
Change convertFromDiskFormat to use substring splitting vs using split operation (slow). patch by goffinet; reviewed by stuhood for
> RandomPartitioner convertFromDiskFormat is slow
> -----------------------------------------------
>
> Key: CASSANDRA-581
> URL: https://issues.apache.org/jira/browse/CASSANDRA-581
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.5
> Reporter: Chris Goffinet
> Assignee: Chris Goffinet
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 0001-Make-convertFromDiskFormat-use-substring-over-split-.patch
>
>
> convertFromDiskFormat in RandomPartitioner is slow. It uses split. We were testing with 1000+ keys using multi-get on a local node. We saw on average 200ms~, with the applied patch it went down to 76ms~.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-581) RandomPartitioner
convertFromDiskFormat is slow
Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786299#action_12786299 ]
Chris Goffinet commented on CASSANDRA-581:
------------------------------------------
Jonathan,
The test already exist, just my fault on that patch change. I verified the test under RandomPartitionerTest validates the +1 change I did.
Commited.
> RandomPartitioner convertFromDiskFormat is slow
> -----------------------------------------------
>
> Key: CASSANDRA-581
> URL: https://issues.apache.org/jira/browse/CASSANDRA-581
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.5
> Reporter: Chris Goffinet
> Assignee: Chris Goffinet
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 0001-Make-convertFromDiskFormat-use-substring-over-split-.patch
>
>
> convertFromDiskFormat in RandomPartitioner is slow. It uses split. We were testing with 1000+ keys using multi-get on a local node. We saw on average 200ms~, with the applied patch it went down to 76ms~.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.