[GH] (opennlp/gazetteer-api): Workflow run "Java CI" is working again!

[GitBox <gi...@apache.org>]

The GitHub Actions job "Java CI" on opennlp.git/gazetteer-api has succeeded.
Run started by GitHub user krickert (triggered by krickert).

Head commit for run:
b72c4862060df596855bf4dcf746de33b2572ed2 / Kristian Rickert <kr...@gmail.com>
OPENNLP-1879: Address review: reuse toolkit string helpers, name arguments in messages, ship opennlp-geo

- Drop StringUtil.isBlank and its test. opennlp-api already ships isUnicodeBlank,
  which is null safe and uses the same whitespace definition, so the added helper
  was a duplicate of an existing one. PlaceAncestor, Suppression, UserGazetteer,
  GeoNamesGazetteer and OvertureGazetteer now call isUnicodeBlank directly and lose
  their separate null check.
- Replace the private stripped() helper in ContainmentSpine with the existing
  StringUtil.trimUnicodeWhitespace, which trims by that same definition, so the
  CSV and Who's On First readers no longer carry their own copy.
- Spell argument names in IllegalArgumentException messages exactly as the
  signature spells them, lower case, across the geo records, the gazetteers, the
  geocoders and GazetteerIndex, and update the assertions in the matching tests.
- Extract the CSV reader's empty pushback marker in ContainmentSpine as the
  NO_PENDING constant instead of a local named none, and document why it is not the
  -1 a Reader returns at end of input.
- Narrow CandidateRanking.featureClassRank to private; nothing outside the class
  calls it.
- Compare Suppression names with equalsIgnoreCase instead of lower casing both
  sides on every call, which also drops the now unused Locale import.
- Fill in the Javadoc tags that were missing on BundledGazetteer.parseTable, on
  GazetteerIndex add, lookup and byId, on the ContainmentSpine file readers and its
  CsvRows.row callback, and describe the previously undocumented Node record.
- Drop the "seam" metaphor from the Gazetteer and Geocoder Javadoc, the
  OverlayGazetteer Javadoc, the manual and the test comments, naming the interface
  or the method that is actually meant.
- Stop promising thread safety on behalf of implementors. Gazetteer and Geocoder
  now state that thread safety is implementation specific, OverlayGazetteer
  promises it only when the composed gazetteers provide it, and the manual asks an
  implementor to document its own guarantee while noting that the implementations
  shipped here are immutable.
- Correct the geo manual, which counted three file-backed implementations while the
  module ships four, by listing UserGazetteer with the others, and align the
  CrmGazetteer byId example with the compiled CrmGazetteer, which rejects source
  and recordId separately.
- Add opennlp-geo to the root dependencyManagement block and to opennlp-distr so
  the module reaches the binary distribution like the other extensions.

Report URL: https://github.com/apache/opennlp/actions/runs/30372478604

With regards,
GitHub Actions via GitBox