You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2014/06/10 19:08:26 UTC
Review Request 22420: Call to fetch metrics takes over 20 seconds
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22420/
-----------------------------------------------------------
Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
Bugs: AMBARI-6070
https://issues.apache.org/jira/browse/AMBARI-6070
Repository: ambari
Description
-------
CPU is consumed by NagiosPropertyProvider and JMXPropertyProvider.
For JMXPropertyProvider execution of ConfigHelper.isStaleConfigs() takes 10-15% of the time now. isStale could be easily cached with Guava Cache. isStale may be changed in 4 cases:
1. Configuration change
2. ConfigGroup created/deleted
3. Start/restart report receiving
4. Host registeration
So we could invalidate appropriate recorrd in cache in these points
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 364cdaa
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 6576861
ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 16f8382
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 706c375
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 3586c08
ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 24cb486
Diff: https://reviews.apache.org/r/22420/diff/
Testing
-------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [2.106s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.309s]
[INFO] Ambari Web ........................................ SUCCESS [10.804s]
[INFO] Ambari Views ...................................... SUCCESS [1.530s]
[INFO] Ambari Server ..................................... SUCCESS [13:43.128s]
[INFO] Ambari Agent ...................................... SUCCESS [3.430s]
[INFO] Ambari Client ..................................... SUCCESS [0.038s]
[INFO] Ambari Python Client .............................. SUCCESS [0.664s]
[INFO] Ambari Groovy Client .............................. SUCCESS [2.631s]
[INFO] Ambari Shell ...................................... SUCCESS [4.316s]
Thanks,
Dmytro Sen
Re: Review Request 22420: Call to fetch metrics takes over 20 seconds
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22420/#review45387
-----------------------------------------------------------
Ship it!
Ship It!
- Sid Wagle
On June 10, 2014, 5:08 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22420/
> -----------------------------------------------------------
>
> (Updated June 10, 2014, 5:08 p.m.)
>
>
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
>
>
> Bugs: AMBARI-6070
> https://issues.apache.org/jira/browse/AMBARI-6070
>
>
> Repository: ambari
>
>
> Description
> -------
>
> CPU is consumed by NagiosPropertyProvider and JMXPropertyProvider.
> For JMXPropertyProvider execution of ConfigHelper.isStaleConfigs() takes 10-15% of the time now. isStale could be easily cached with Guava Cache. isStale may be changed in 4 cases:
> 1. Configuration change
> 2. ConfigGroup created/deleted
> 3. Start/restart report receiving
> 4. Host registeration
> So we could invalidate appropriate recorrd in cache in these points
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 364cdaa
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 6576861
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 16f8382
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 706c375
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 3586c08
> ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 24cb486
>
> Diff: https://reviews.apache.org/r/22420/diff/
>
>
> Testing
> -------
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [2.106s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.309s]
> [INFO] Ambari Web ........................................ SUCCESS [10.804s]
> [INFO] Ambari Views ...................................... SUCCESS [1.530s]
> [INFO] Ambari Server ..................................... SUCCESS [13:43.128s]
> [INFO] Ambari Agent ...................................... SUCCESS [3.430s]
> [INFO] Ambari Client ..................................... SUCCESS [0.038s]
> [INFO] Ambari Python Client .............................. SUCCESS [0.664s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [2.631s]
> [INFO] Ambari Shell ...................................... SUCCESS [4.316s]
>
>
> Thanks,
>
> Dmytro Sen
>
>