You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "zuston (via GitHub)" <gi...@apache.org> on 2023/01/30 07:20:42 UTC

[GitHub] [incubator-uniffle] zuston opened a new issue, #519: [Improvement] Speed up ConcurrentHashMap#computeIfAbsent

zuston opened a new issue, #519:
URL: https://github.com/apache/incubator-uniffle/issues/519

   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   
   
   ### Search before asking
   
   - [X] I have searched in the [issues](https://github.com/apache/incubator-uniffle/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### What would you like to be improved?
   
   According to the bug mentioned in https://bugs.openjdk.org/browse/JDK-8161372, we could check the key existence before invoking `computeIfAbsent`, especially for the critical path like `ShuffleTaskManager#refreshAppId`
   
   ### How should we improve?
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


[GitHub] [incubator-uniffle] advancedxy commented on issue #519: [Improvement] Speed up ConcurrentHashMap#computeIfAbsent

Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on issue #519:
URL: https://github.com/apache/incubator-uniffle/issues/519#issuecomment-1408147883

   Ouch, does `putIfAbsent` has similar issue under JDK 8?
   
   If `putIfAbsent` doesn't have this problem, I believe we should prefer `putIfAbsent` for simple cases to improve readability. 
   
   Otherwise, I'm opt for this solution.
   
   BTW, https://cwiki.apache.org/confluence/display/HADOOP/Hadoop+Java+Versions JDK 1.8 seems to be lasting for a long time since only hadoop 3.3 supports JDK11 in runtime.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


[GitHub] [incubator-uniffle] zuston commented on issue #519: [Improvement] Speed up ConcurrentHashMap#computeIfAbsent

Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on issue #519:
URL: https://github.com/apache/incubator-uniffle/issues/519#issuecomment-1410135087

   > Ouch, does putIfAbsent has similar issue under JDK 8?
   
   From its implementation, it also has similar problems. 
   
   > BTW, https://cwiki.apache.org/confluence/display/HADOOP/Hadoop+Java+Versions JDK 1.8 seems to be lasting for a long time since only hadoop 3.3 supports JDK11 in runtime.
   
   Yes. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


[GitHub] [incubator-uniffle] zuston commented on issue #519: [Improvement] Speed up ConcurrentHashMap#computeIfAbsent

Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on issue #519:
URL: https://github.com/apache/incubator-uniffle/issues/519#issuecomment-1408109569

   cc @kaijchen @advancedxy @jerqi 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


[GitHub] [incubator-uniffle] zuston closed issue #519: [Improvement] Speed up ConcurrentHashMap#computeIfAbsent

Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston closed issue #519: [Improvement] Speed up ConcurrentHashMap#computeIfAbsent
URL: https://github.com/apache/incubator-uniffle/issues/519


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org