You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ignite.apache.org by GitBox <gi...@apache.org> on 2020/11/26 18:48:46 UTC
[GitHub] [ignite-3] AMashenkov opened a new pull request #2: IGNITE-13748: Schema configuration public API.
AMashenkov opened a new pull request #2:
URL: https://github.com/apache/ignite-3/pull/2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] AMashenkov merged pull request #2: IGNITE-13748: Schema configuration public API.
Posted by GitBox <gi...@apache.org>.
AMashenkov merged pull request #2:
URL: https://github.com/apache/ignite-3/pull/2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] alamar commented on a change in pull request #2: IGNITE-13748: Schema configuration public API.
Posted by GitBox <gi...@apache.org>.
alamar commented on a change in pull request #2:
URL: https://github.com/apache/ignite-3/pull/2#discussion_r549299897
##########
File path: modules/commons/src/test/java/org/apache/ignite/internal/schema/SchemaConfigurationTest.java
##########
@@ -0,0 +1,106 @@
+package org.apache.ignite.internal.schema;
+
+import org.apache.ignite.schema.ColumnType;
+import org.apache.ignite.schema.SchemaBuilders;
+import org.apache.ignite.schema.SchemaTable;
+import org.apache.ignite.schema.builder.SchemaTableBuilder;
+import org.junit.jupiter.api.Test;
+
+public class SchemaConfigurationTest {
+ @Test
+ public void testInitialSchema() {
+ //TODO: Do we need separate 'Schema builder' or left 'schema' name as kind of 'namespace'.
+ final SchemaTableBuilder builder = SchemaBuilders.tableBuilder("PUBLIC", "table1");
+
+ builder
+ .columns(
+ // Declaring columns in user order.
+ SchemaBuilders.column("id").withType(ColumnType.INT64).build(),
+ SchemaBuilders.column("label").withType(ColumnType.stringOf(2)).withDefaultValue("AI").build(),
+ SchemaBuilders.column("name").withType(ColumnType.string()).asNonNull().build(),
+ SchemaBuilders.column("data").withType(ColumnType.blobOf(255)).asNullable().build(),
+ SchemaBuilders.column("affId").withType(ColumnType.INT32).build()
+ )
+
+ // PK index type can't be changed as highly coupled core implementation.
+ .pk()
+ .withColumns("id", "affId", "label") // Declare index column in order.
+ .withAffinityColumns("affId") // Optional affinity declaration. If not set, all columns will be affinity cols.
+ //TODO: As we have affinity columns here,
+ //TODO: do we want to add affinity function config here???
+ .done()
+
+ // 'withIndex' single entry point allows extended index support.
+ // E.g. we may want to support GEO indices later with some plugin.
+ .withindex(
Review comment:
Why lower case index?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] AMashenkov commented on a change in pull request #2: IGNITE-13748: Schema configuration public API.
Posted by GitBox <gi...@apache.org>.
AMashenkov commented on a change in pull request #2:
URL: https://github.com/apache/ignite-3/pull/2#discussion_r560913083
##########
File path: modules/commons/src/main/java/org/apache/ignite/schema/builder/Builder.java
##########
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.schema.builder;
+
+/**
+ * Builder base interface.
+ */
+public interface Builder {
+ /**
+ * @return Built object.
+ */
+ Object build();
Review comment:
This will lead us to the hell of generics.
Assume, you have 2 classes A and B and 2 interfaces BuilderB extends BuilderA.
A try to generify builders via extending Builder<T> will make it impossible to reuse code in implementations BuilderB extends BuilderA even if B extends A.
Just try and you quickly end up with generics hell.
Templates like <? extends T> make things even worse.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] Berkof commented on a change in pull request #2: IGNITE-13748: Schema configuration public API.
Posted by GitBox <gi...@apache.org>.
Berkof commented on a change in pull request #2:
URL: https://github.com/apache/ignite-3/pull/2#discussion_r560114854
##########
File path: modules/commons/src/main/java/org/apache/ignite/schema/builder/Builder.java
##########
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.schema.builder;
+
+/**
+ * Builder base interface.
+ */
+public interface Builder {
+ /**
+ * @return Built object.
+ */
+ Object build();
Review comment:
What if we parametrize this class, to avoid specifying
"@" Override build();
method and replace it with
extends Builder <HashIndex> {
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] Berkof commented on a change in pull request #2: IGNITE-13748: Schema configuration public API.
Posted by GitBox <gi...@apache.org>.
Berkof commented on a change in pull request #2:
URL: https://github.com/apache/ignite-3/pull/2#discussion_r560114854
##########
File path: modules/commons/src/main/java/org/apache/ignite/schema/builder/Builder.java
##########
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.schema.builder;
+
+/**
+ * Builder base interface.
+ */
+public interface Builder {
+ /**
+ * @return Built object.
+ */
+ Object build();
Review comment:
What if we parametrize this class, to avoid specifying
"@" Override HashIndex build();
method and replace it with
extends Builder <HashIndex> {
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] AMashenkov commented on pull request #2: IGNITE-13748: Schema configuration public API.
Posted by GitBox <gi...@apache.org>.
AMashenkov commented on pull request #2:
URL: https://github.com/apache/ignite-3/pull/2#issuecomment-763569419
> Do we need some other objects like FunctionalBasedIndex (like
> CREATE UNIQUE INDEX MY_UPPER_IDX on MY_TABLE(upper(LOGIN))
> or even combine it with partial one, like:
> CREATE UNIQUE INDEX MY_UPPER_IDX on MY_TABLE(upper(NAME)) WHERE (deleted = false)
Let's add functional index support within a separate ticket. A functional index can't be UNIQUE because it is not columnar index, but UNIQUE index must contain all affinity columns.
UNIQUE index on arbitrary columns/values will be very slow on update operation and we won't support this case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] Berkof commented on pull request #2: IGNITE-13748: Schema configuration public API.
Posted by GitBox <gi...@apache.org>.
Berkof commented on pull request #2:
URL: https://github.com/apache/ignite-3/pull/2#issuecomment-762790749
Do we need some other objects like FunctionalBasedIndex (like
CREATE UNIQUE INDEX MY_UPPER_IDX on MY_TABLE(upper(LOGIN))
or even compile it with partial one, like:
CREATE UNIQUE INDEX MY_UPPER_IDX on MY_TABLE(upper(NAME)) WHERE (deleted = false)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] Berkof commented on a change in pull request #2: IGNITE-13748: Schema configuration public API.
Posted by GitBox <gi...@apache.org>.
Berkof commented on a change in pull request #2:
URL: https://github.com/apache/ignite-3/pull/2#discussion_r560113175
##########
File path: modules/commons/src/main/java/org/apache/ignite/schema/TableIndex.java
##########
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.schema;
+
+/**
+ * Table index base interface
+ */
+public interface TableIndex {
+ /**
+ * @return Index name.
+ */
+ String name();
Review comment:
Should we add some base schema class?
What about the description field (it can be in the base class with a name to allow each object to be named and described)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] Berkof edited a comment on pull request #2: IGNITE-13748: Schema configuration public API.
Posted by GitBox <gi...@apache.org>.
Berkof edited a comment on pull request #2:
URL: https://github.com/apache/ignite-3/pull/2#issuecomment-762790749
Do we need some other objects like FunctionalBasedIndex (like
CREATE UNIQUE INDEX MY_UPPER_IDX on MY_TABLE(upper(LOGIN))
or even combine it with partial one, like:
CREATE UNIQUE INDEX MY_UPPER_IDX on MY_TABLE(upper(NAME)) WHERE (deleted = false)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org