You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2021/02/04 06:40:32 UTC
[GitHub] [openwhisk] bdoyle0182 opened a new pull request #5058: drop healthcheck activations from invoker that are over threshold age
bdoyle0182 opened a new pull request #5058:
URL: https://github.com/apache/openwhisk/pull/5058
## Description
The invoker will now drop healthcheck activations read from kafka that are older than a configurable threshold. The default is 30 minutes. The max backlog of healthcheck activations backlogged in the invoker topics that will be processed are therefore # controllers * number of minutes threshold since each controller sends a healthcheck once per minute when unhealthy. The invoker also will no longer become healthy prior to eating through these old messages and processing a young enough healthcheck message at which point should be the end of the kafka backlog and safe to mark the invoker as healthy.
## Related issue and scope
- [x] I opened an issue to propose and discuss this change (#5053 )
## My changes affect the following components
- [ ] API
- [ ] Controller
- [ ] Message Bus (e.g., Kafka)
- [ ] Loadbalancer
- [x] Invoker
- [ ] Intrinsic actions (e.g., sequences, conductors)
- [ ] Data stores (e.g., CouchDB)
- [ ] Tests
- [ ] Deployment
- [ ] CLI
- [ ] General tooling
- [ ] Documentation
## Types of changes
- [x] Bug fix (generally a non-breaking change which closes an issue).
- [ ] Enhancement or new feature (adds new functionality).
- [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
## Checklist:
- [x] I signed an [Apache CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md).
- [x] I reviewed the [style guides](https://github.com/apache/openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).
- [ ] I added tests to cover my changes.
- [ ] My changes require further changes to the documentation.
- [ ] I updated the documentation where necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] bdoyle0182 closed pull request #5058: drop healthcheck activations from invoker that are over threshold age
Posted by GitBox <gi...@apache.org>.
bdoyle0182 closed pull request #5058:
URL: https://github.com/apache/openwhisk/pull/5058
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] bdoyle0182 commented on pull request #5058: drop healthcheck activations from invoker that are over threshold age
Posted by GitBox <gi...@apache.org>.
bdoyle0182 commented on pull request #5058:
URL: https://github.com/apache/openwhisk/pull/5058#issuecomment-772931887
updated so that the controller creates a new tid with the same healthcheck id string so that the time used is different for each healthcheck activation, and made any place that compares the healthcheck tid to check against the string id and not the object itself. Think this should work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] bdoyle0182 closed pull request #5058: drop healthcheck activations from invoker that are over threshold age
Posted by GitBox <gi...@apache.org>.
bdoyle0182 closed pull request #5058:
URL: https://github.com/apache/openwhisk/pull/5058
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] bdoyle0182 commented on pull request #5058: drop healthcheck activations from invoker that are over threshold age
Posted by GitBox <gi...@apache.org>.
bdoyle0182 commented on pull request #5058:
URL: https://github.com/apache/openwhisk/pull/5058#issuecomment-770151821
Realized that the TransactionId is a constant for healthcheck transaction id so will need to tweak this a little since it will always have the same start time from when the controller server was started.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] bdoyle0182 closed pull request #5058: drop healthcheck activations from invoker that are over threshold age
Posted by GitBox <gi...@apache.org>.
bdoyle0182 closed pull request #5058:
URL: https://github.com/apache/openwhisk/pull/5058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] bdoyle0182 closed pull request #5058: drop healthcheck activations from invoker that are over threshold age
Posted by GitBox <gi...@apache.org>.
bdoyle0182 closed pull request #5058:
URL: https://github.com/apache/openwhisk/pull/5058
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] ningyougang commented on pull request #5058: drop healthcheck activations from invoker that are over threshold age
Posted by GitBox <gi...@apache.org>.
ningyougang commented on pull request #5058:
URL: https://github.com/apache/openwhisk/pull/5058#issuecomment-789357698
BTW, need to drop the normal action's old activation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] bdoyle0182 closed pull request #5058: drop healthcheck activations from invoker that are over threshold age
Posted by GitBox <gi...@apache.org>.
bdoyle0182 closed pull request #5058:
URL: https://github.com/apache/openwhisk/pull/5058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org