You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Donald Woods (JIRA)" <ji...@apache.org> on 2008/06/02 21:47:46 UTC
[jira] Created: (GERONIMO-4093) gsh scripts are not looking for
optional setjavaenv script
gsh scripts are not looking for optional setjavaenv script
----------------------------------------------------------
Key: GERONIMO-4093
URL: https://issues.apache.org/jira/browse/GERONIMO-4093
Project: Geronimo
Issue Type: Bug
Security Level: public (Regular issues)
Affects Versions: 2.1.1, 2.1, 2.1.2, 2.2
Reporter: Donald Woods
Assignee: Donald Woods
Fix For: 2.1.2, 2.2
gsh scripts are not allowing users to provide the optional setjavaenv scripts, like the previous geronimo/deploy scripts allowed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4093) gsh scripts are not looking for
optional setjavaenv script
Posted by "Jason Dillon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603609#action_12603609 ]
Jason Dillon commented on GERONIMO-4093:
----------------------------------------
I still *really, really, really* do not like this change.... and still would like to see this cruft dropped.
> gsh scripts are not looking for optional setjavaenv script
> ----------------------------------------------------------
>
> Key: GERONIMO-4093
> URL: https://issues.apache.org/jira/browse/GERONIMO-4093
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 2.1, 2.1.1, 2.1.2, 2.2
> Reporter: Donald Woods
> Assignee: Donald Woods
> Fix For: 2.1.2, 2.2
>
>
> gsh scripts are not allowing users to provide the optional setjavaenv scripts, like the previous geronimo/deploy scripts allowed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4093) gsh scripts are not using
setjavaenv or optional setenv script
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632446#action_12632446 ]
David Jencks commented on GERONIMO-4093:
----------------------------------------
I'm not OK with requiring people to define JAVA_HOME on mac. I've committed something that eliminates this requirement, rev 696852.
I'm happy to vote against any proposed releases that do require defining JAVA_HOME.
I still think most of the script crud is not appropriate since it is for starting gshell, NOT geronimo. How much control does anyone need to start gshell?
> gsh scripts are not using setjavaenv or optional setenv script
> --------------------------------------------------------------
>
> Key: GERONIMO-4093
> URL: https://issues.apache.org/jira/browse/GERONIMO-4093
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 2.1, 2.1.1, 2.1.2, 2.2
> Reporter: Donald Woods
> Assignee: Donald Woods
> Fix For: 2.2
>
>
> gsh scripts are not allowing users to provide the optional setjavaenv scripts, like the previous geronimo/deploy scripts allowed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (GERONIMO-4093) gsh scripts are not using setjavaenv
or optional setenv script
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Donald Woods closed GERONIMO-4093.
----------------------------------
Resolution: Fixed
fixed with r666718 in branches/2.1 and r666720 in trunk.
> gsh scripts are not using setjavaenv or optional setenv script
> --------------------------------------------------------------
>
> Key: GERONIMO-4093
> URL: https://issues.apache.org/jira/browse/GERONIMO-4093
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 2.1, 2.1.1, 2.1.2, 2.2
> Reporter: Donald Woods
> Assignee: Donald Woods
> Fix For: 2.1.2, 2.2
>
>
> gsh scripts are not allowing users to provide the optional setjavaenv scripts, like the previous geronimo/deploy scripts allowed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-4093) gsh scripts are not using
setjavaenv or optional setenv script
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Donald Woods updated GERONIMO-4093:
-----------------------------------
Summary: gsh scripts are not using setjavaenv or optional setenv script (was: gsh scripts are not looking for optional setjavaenv script)
> gsh scripts are not using setjavaenv or optional setenv script
> --------------------------------------------------------------
>
> Key: GERONIMO-4093
> URL: https://issues.apache.org/jira/browse/GERONIMO-4093
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 2.1, 2.1.1, 2.1.2, 2.2
> Reporter: Donald Woods
> Assignee: Donald Woods
> Fix For: 2.1.2, 2.2
>
>
> gsh scripts are not allowing users to provide the optional setjavaenv scripts, like the previous geronimo/deploy scripts allowed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4093) gsh scripts are not looking for
optional setjavaenv script
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601788#action_12601788 ]
David Jencks commented on GERONIMO-4093:
----------------------------------------
I thought that this funcationality was taken over by etc/rc.d/start-server,default.groovy and possibly defining a profile. Is there some functionality missing from this new way of starting geronimo?
> gsh scripts are not looking for optional setjavaenv script
> ----------------------------------------------------------
>
> Key: GERONIMO-4093
> URL: https://issues.apache.org/jira/browse/GERONIMO-4093
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 2.1, 2.1.1, 2.1.2, 2.2
> Reporter: Donald Woods
> Assignee: Donald Woods
> Fix For: 2.1.2, 2.2
>
>
> gsh scripts are not allowing users to provide the optional setjavaenv scripts, like the previous geronimo/deploy scripts allowed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (GERONIMO-4093) gsh scripts are not looking for
optional setjavaenv script
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Donald Woods closed GERONIMO-4093.
----------------------------------
Resolution: Fixed
r665729 in branches/2.1 (2.1.2-SNAPSHOT)
r665749 in trunk (2.2-SNAPSHOT)
> gsh scripts are not looking for optional setjavaenv script
> ----------------------------------------------------------
>
> Key: GERONIMO-4093
> URL: https://issues.apache.org/jira/browse/GERONIMO-4093
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 2.1, 2.1.1, 2.1.2, 2.2
> Reporter: Donald Woods
> Assignee: Donald Woods
> Fix For: 2.1.2, 2.2
>
>
> gsh scripts are not allowing users to provide the optional setjavaenv scripts, like the previous geronimo/deploy scripts allowed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4093) gsh scripts are not looking for
optional setjavaenv script
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601913#action_12601913 ]
Donald Woods commented on GERONIMO-4093:
----------------------------------------
Well, gsh only looks for JAVA_HOME, whereas deploy/geronimo can use either JRE_HOME or JAVA_HOME and actually prefers JRE_HOME unless you are starting the server in debug mode, so we've lost that option with gsh.
Also, the setenv/setjavaenv scripts allowed users to override settings, without mucking with server provided files.
> gsh scripts are not looking for optional setjavaenv script
> ----------------------------------------------------------
>
> Key: GERONIMO-4093
> URL: https://issues.apache.org/jira/browse/GERONIMO-4093
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 2.1, 2.1.1, 2.1.2, 2.2
> Reporter: Donald Woods
> Assignee: Donald Woods
> Fix For: 2.1.2, 2.2
>
>
> gsh scripts are not allowing users to provide the optional setjavaenv scripts, like the previous geronimo/deploy scripts allowed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (GERONIMO-4093) gsh scripts are not using
setjavaenv or optional setenv script
Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jarek Gawor reopened GERONIMO-4093:
-----------------------------------
After these changes all commands fail if $JAVA_HOME contains spaces! E.g.:
C:\>c:\target\geronimo-tomcat6-javaee5-2.2-SNAPSHOT\bin\geronimo.bat run
Using GERONIMO_BASE: C:\target\geronimo-tomcat6-javaee5-2.2-SNAPSHOT
Using GERONIMO_HOME: C:\target\geronimo-tomcat6-javaee5-2.2-SNAPSHOT
Using GERONIMO_TMPDIR: var\temp
Using JRE_HOME: ###=\jre
The system cannot find the path specified.
> gsh scripts are not using setjavaenv or optional setenv script
> --------------------------------------------------------------
>
> Key: GERONIMO-4093
> URL: https://issues.apache.org/jira/browse/GERONIMO-4093
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 2.1, 2.1.1, 2.1.2, 2.2
> Reporter: Donald Woods
> Assignee: Donald Woods
> Fix For: 2.1.2, 2.2
>
>
> gsh scripts are not allowing users to provide the optional setjavaenv scripts, like the previous geronimo/deploy scripts allowed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4093) gsh scripts are not using
setjavaenv or optional setenv script
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621798#action_12621798 ]
Donald Woods commented on GERONIMO-4093:
----------------------------------------
It's common practice to require JAVA_HOME to be defined. Linux provides it (RHEL, SUSE, Ubuntu) and Windows JVM installers provide it, so I'd say Mac is the one at fault here and any Mac users (which I'm one of them) should be expected to define JAVA_HOME if needed.
> gsh scripts are not using setjavaenv or optional setenv script
> --------------------------------------------------------------
>
> Key: GERONIMO-4093
> URL: https://issues.apache.org/jira/browse/GERONIMO-4093
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 2.1, 2.1.1, 2.1.2, 2.2
> Reporter: Donald Woods
> Assignee: Donald Woods
> Fix For: 2.1.2, 2.2
>
>
> gsh scripts are not allowing users to provide the optional setjavaenv scripts, like the previous geronimo/deploy scripts allowed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-4093) gsh scripts are not using
setjavaenv or optional setenv script
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Donald Woods updated GERONIMO-4093:
-----------------------------------
Fix Version/s: (was: 2.1.2)
> gsh scripts are not using setjavaenv or optional setenv script
> --------------------------------------------------------------
>
> Key: GERONIMO-4093
> URL: https://issues.apache.org/jira/browse/GERONIMO-4093
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 2.1, 2.1.1, 2.1.2, 2.2
> Reporter: Donald Woods
> Assignee: Donald Woods
> Fix For: 2.2
>
>
> gsh scripts are not allowing users to provide the optional setjavaenv scripts, like the previous geronimo/deploy scripts allowed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (GERONIMO-4093) gsh scripts are not using setjavaenv
or optional setenv script
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Donald Woods closed GERONIMO-4093.
----------------------------------
Resolution: Fixed
Fix Version/s: 2.1.4
Updates made in GERONIMO-4312 should resolve your concerns on requiring JAVA_HOME.
The optional setenv script can still be useful for our users, by allowing them to provide env vars for such cases as running Geronimo as a service on Linux/Unix.
The provided setjavaenv script is still useful, as it validates that a Java runtime can be found.
> gsh scripts are not using setjavaenv or optional setenv script
> --------------------------------------------------------------
>
> Key: GERONIMO-4093
> URL: https://issues.apache.org/jira/browse/GERONIMO-4093
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 2.1, 2.1.1, 2.1.2, 2.2
> Reporter: Donald Woods
> Assignee: Donald Woods
> Fix For: 2.1.4, 2.2
>
>
> gsh scripts are not allowing users to provide the optional setjavaenv scripts, like the previous geronimo/deploy scripts allowed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4093) gsh scripts are not looking for
optional setjavaenv script
Posted by "Jason Dillon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601820#action_12601820 ]
Jason Dillon commented on GERONIMO-4093:
----------------------------------------
I sent email about this a while ago and IMO we do not want to add support for the older setjavaenv stuff, instead use the platform independent groovy scripts.
> gsh scripts are not looking for optional setjavaenv script
> ----------------------------------------------------------
>
> Key: GERONIMO-4093
> URL: https://issues.apache.org/jira/browse/GERONIMO-4093
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 2.1, 2.1.1, 2.1.2, 2.2
> Reporter: Donald Woods
> Assignee: Donald Woods
> Fix For: 2.1.2, 2.2
>
>
> gsh scripts are not allowing users to provide the optional setjavaenv scripts, like the previous geronimo/deploy scripts allowed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (GERONIMO-4093) gsh scripts are not using
setjavaenv or optional setenv script
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Jencks reopened GERONIMO-4093:
------------------------------------
I can't run trunk without it complaining about needing JAVA_HOME or JRE_HOME to be defined. This is unnecessary on mac osx. I've reverted this change locally but don't think its acceptable to break a common development environment in this way.
> gsh scripts are not using setjavaenv or optional setenv script
> --------------------------------------------------------------
>
> Key: GERONIMO-4093
> URL: https://issues.apache.org/jira/browse/GERONIMO-4093
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 2.1, 2.1.1, 2.1.2, 2.2
> Reporter: Donald Woods
> Assignee: Donald Woods
> Fix For: 2.1.2, 2.2
>
>
> gsh scripts are not allowing users to provide the optional setjavaenv scripts, like the previous geronimo/deploy scripts allowed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.