You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/09/02 08:42:37 UTC

[GitHub] [iotdb] LebronAl commented on a change in pull request #3439: [IOTDB-1450] Deletion should only delete related time partitions

LebronAl commented on a change in pull request #3439:
URL: https://github.com/apache/iotdb/pull/3439#discussion_r700875271



##########
File path: cluster/src/main/java/org/apache/iotdb/cluster/log/applier/DataLogApplier.java
##########
@@ -79,6 +81,12 @@ public void apply(Log log) {
       } else if (log instanceof PhysicalPlanLog) {
         PhysicalPlanLog physicalPlanLog = (PhysicalPlanLog) log;
         PhysicalPlan plan = physicalPlanLog.getPlan();
+        if (plan instanceof DeletePlan) {

Review comment:
       Maybe we should consider the case when replicaNum == 1  when enable timePartition




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org