[GitHub] [kafka] C0urante commented on a diff in pull request #13530: KAFKA-14858: Handle exceptions thrown from Connector::taskConfigs in Connect's standalone mode

["C0urante (via GitHub)" <gi...@apache.org>]

C0urante commented on code in PR #13530:
URL: https://github.com/apache/kafka/pull/13530#discussion_r1164425895


##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerder.java:
##########
@@ -229,7 +229,12 @@ private synchronized void putConnectorConfig(String connName,
                 }
 
                 requestExecutorService.submit(() -> {
-                    updateConnectorTasks(connName);
+                    try {
+                        updateConnectorTasks(connName);
+                    } catch (Throwable t) {
+                        callback.onCompletion(t, null);

Review Comment:
   If the REST request times out, will we still see an exception in the logs?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org