You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/23 16:22:47 UTC
[GitHub] [flink] tillrohrmann opened a new pull request #11887: [DRAFT][FLINK-14816] Add thread dump feature for taskmanager
tillrohrmann opened a new pull request #11887:
URL: https://github.com/apache/flink/pull/11887
Extension of #10228.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #11887: [FLINK-14816] Add thread dump feature for taskmanager
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #11887:
URL: https://github.com/apache/flink/pull/11887#discussion_r415835040
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/taskmanager/ThreadDumpInfo.java
##########
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.rest.messages.taskmanager;
+
+import org.apache.flink.runtime.rest.messages.ResponseBody;
+
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonCreator;
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonProperty;
+
+import java.io.Serializable;
+import java.util.Collection;
+import java.util.Objects;
+
+/**
+ * Class containing thread dump information.
+ */
+public class ThreadDumpInfo implements ResponseBody, Serializable {
+ private static final long serialVersionUID = 1L;
+
+ public static final String FIELD_NAME_THREAD_INFOS = "threadInfos";
+
+ @JsonProperty(FIELD_NAME_THREAD_INFOS)
+ private final Collection<ThreadInfo> threadInfos;
Review comment:
Actually, I think whether it is stored in a map or not is an implementation detail. Moreover, we don't offer a method `getThreadInfo(String threadName)` yet. Hence, there is actually no reason to store them internally as a map. Once the requirement changes, I'm happy to adapt the class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11887: [FLINK-14816] Add thread dump feature for taskmanager
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11887:
URL: https://github.com/apache/flink/pull/11887#issuecomment-618505450
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161670239",
"triggerID" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"triggerType" : "PUSH"
}, {
"hash" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=142",
"triggerID" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"triggerType" : "PUSH"
}, {
"hash" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161790852",
"triggerID" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"triggerType" : "PUSH"
}, {
"hash" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=185",
"triggerID" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"triggerType" : "PUSH"
}, {
"hash" : "bc5fd415d52f54be1aec59ff86b0d1571fb88489",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=206",
"triggerID" : "bc5fd415d52f54be1aec59ff86b0d1571fb88489",
"triggerType" : "PUSH"
}, {
"hash" : "bc5fd415d52f54be1aec59ff86b0d1571fb88489",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161834854",
"triggerID" : "bc5fd415d52f54be1aec59ff86b0d1571fb88489",
"triggerType" : "PUSH"
}, {
"hash" : "5ecc88f14d8d7ebd8ad31749399e0c6d9e54ab00",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162237825",
"triggerID" : "5ecc88f14d8d7ebd8ad31749399e0c6d9e54ab00",
"triggerType" : "PUSH"
}, {
"hash" : "5ecc88f14d8d7ebd8ad31749399e0c6d9e54ab00",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=329",
"triggerID" : "5ecc88f14d8d7ebd8ad31749399e0c6d9e54ab00",
"triggerType" : "PUSH"
}, {
"hash" : "89f3c0d90b160aa2a6e813255e80630882d6c2d3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "89f3c0d90b160aa2a6e813255e80630882d6c2d3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5ecc88f14d8d7ebd8ad31749399e0c6d9e54ab00 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/162237825) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=329)
* 89f3c0d90b160aa2a6e813255e80630882d6c2d3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #11887: [FLINK-14816] Add thread dump feature for taskmanager
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #11887:
URL: https://github.com/apache/flink/pull/11887#discussion_r415810380
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
##########
@@ -1012,10 +1016,34 @@ public void disconnectResourceManager(Exception cause) {
}
}
+ @Override
+ public CompletableFuture<ThreadDumpInfo> requestThreadDump(Time timeout) {
+ final Collection<ThreadInfo> threadDump = JvmUtils.createThreadDump();
+
+ final Collection<ThreadDumpInfo.ThreadInfo> threadInfos = threadDump.stream()
+ .map(threadInfo -> ThreadDumpInfo.ThreadInfo.create(threadInfo.getThreadName(), threadInfo.toString()))
+ .collect(Collectors.toList());
+
+ return CompletableFuture.completedFuture(ThreadDumpInfo.create(threadInfos));
+ }
+
// ======================================================================
// Internal methods
// ======================================================================
+ private CompletableFuture<TransientBlobKey> putTransientBlobStream(InputStream inputStream, String fileTag) {
+ final TransientBlobCache transientBlobService = blobCacheService.getTransientBlobService();
+ final TransientBlobKey transientBlobKey;
+
+ try {
+ transientBlobKey = transientBlobService.putTransient(inputStream);
+ } catch (IOException e) {
+ log.debug("Could not upload file {}.", fileTag, e);
+ return FutureUtils.completedExceptionally(new FlinkException("Could not upload file " + fileTag + '.', e));
+ }
+ return CompletableFuture.completedFuture(transientBlobKey);
+ }
+
Review comment:
Technically yes but I think it is ok to not twiddle with this commit because the benefit would be marginal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11887: [FLINK-14816] Add thread dump feature for taskmanager
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11887:
URL: https://github.com/apache/flink/pull/11887#issuecomment-618505450
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161670239",
"triggerID" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"triggerType" : "PUSH"
}, {
"hash" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=142",
"triggerID" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"triggerType" : "PUSH"
}, {
"hash" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161790852",
"triggerID" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"triggerType" : "PUSH"
}, {
"hash" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=185",
"triggerID" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"triggerType" : "PUSH"
}, {
"hash" : "bc5fd415d52f54be1aec59ff86b0d1571fb88489",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=206",
"triggerID" : "bc5fd415d52f54be1aec59ff86b0d1571fb88489",
"triggerType" : "PUSH"
}, {
"hash" : "bc5fd415d52f54be1aec59ff86b0d1571fb88489",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161834854",
"triggerID" : "bc5fd415d52f54be1aec59ff86b0d1571fb88489",
"triggerType" : "PUSH"
}, {
"hash" : "5ecc88f14d8d7ebd8ad31749399e0c6d9e54ab00",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162237825",
"triggerID" : "5ecc88f14d8d7ebd8ad31749399e0c6d9e54ab00",
"triggerType" : "PUSH"
}, {
"hash" : "5ecc88f14d8d7ebd8ad31749399e0c6d9e54ab00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=329",
"triggerID" : "5ecc88f14d8d7ebd8ad31749399e0c6d9e54ab00",
"triggerType" : "PUSH"
}, {
"hash" : "89f3c0d90b160aa2a6e813255e80630882d6c2d3",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162418438",
"triggerID" : "89f3c0d90b160aa2a6e813255e80630882d6c2d3",
"triggerType" : "PUSH"
}, {
"hash" : "89f3c0d90b160aa2a6e813255e80630882d6c2d3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=373",
"triggerID" : "89f3c0d90b160aa2a6e813255e80630882d6c2d3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 89f3c0d90b160aa2a6e813255e80630882d6c2d3 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/162418438) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=373)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] lamber-ken commented on pull request #11887: [DRAFT][FLINK-14816] Add thread dump feature for taskmanager
Posted by GitBox <gi...@apache.org>.
lamber-ken commented on pull request #11887:
URL: https://github.com/apache/flink/pull/11887#issuecomment-618621288
hi @tillrohrmann, thanks for doing this, 💯
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on pull request #11887: [DRAFT][FLINK-14816] Add thread dump feature for taskmanager
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #11887:
URL: https://github.com/apache/flink/pull/11887#issuecomment-618870957
Thanks for the pointer @lamber-ken. I will update the PR to fix the `RestAPIStabilityTest`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on pull request #11887: [FLINK-14816] Add thread dump feature for taskmanager
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #11887:
URL: https://github.com/apache/flink/pull/11887#issuecomment-618997181
cc @zentol: The `TaskManagerThreadDumpHandler` now returns a `ThreadDumpInfo` which contains an array of `ThreadDumpInfo.ThreadInfo`. `ThreadDumpInfo.ThreadInfo` contains the name of the thread and the stringified thread info. This is kind of the compromise I found wrt our offline discussion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #11887: [FLINK-14816] Add thread dump feature for taskmanager
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11887:
URL: https://github.com/apache/flink/pull/11887#discussion_r415734221
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/FileType.java
##########
@@ -22,6 +22,13 @@
* Different file types to request from the {@link TaskExecutor}.
*/
public enum FileType {
+ /**
+ * the log file type for taskmanager
Review comment:
this seems unrelated?
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
##########
@@ -1012,10 +1016,34 @@ public void disconnectResourceManager(Exception cause) {
}
}
+ @Override
+ public CompletableFuture<ThreadDumpInfo> requestThreadDump(Time timeout) {
+ final Collection<ThreadInfo> threadDump = JvmUtils.createThreadDump();
+
+ final Collection<ThreadDumpInfo.ThreadInfo> threadInfos = threadDump.stream()
+ .map(threadInfo -> ThreadDumpInfo.ThreadInfo.create(threadInfo.getThreadName(), threadInfo.toString()))
Review comment:
I'm wondering whether this conversion should really be done on the TaskExecutor.
I'd prefer if conversions to REST responses are done by the handler just to separate things a bit.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
##########
@@ -1012,10 +1016,34 @@ public void disconnectResourceManager(Exception cause) {
}
}
+ @Override
+ public CompletableFuture<ThreadDumpInfo> requestThreadDump(Time timeout) {
+ final Collection<ThreadInfo> threadDump = JvmUtils.createThreadDump();
+
+ final Collection<ThreadDumpInfo.ThreadInfo> threadInfos = threadDump.stream()
+ .map(threadInfo -> ThreadDumpInfo.ThreadInfo.create(threadInfo.getThreadName(), threadInfo.toString()))
+ .collect(Collectors.toList());
+
+ return CompletableFuture.completedFuture(ThreadDumpInfo.create(threadInfos));
+ }
+
// ======================================================================
// Internal methods
// ======================================================================
+ private CompletableFuture<TransientBlobKey> putTransientBlobStream(InputStream inputStream, String fileTag) {
+ final TransientBlobCache transientBlobService = blobCacheService.getTransientBlobService();
+ final TransientBlobKey transientBlobKey;
+
+ try {
+ transientBlobKey = transientBlobService.putTransient(inputStream);
+ } catch (IOException e) {
+ log.debug("Could not upload file {}.", fileTag, e);
+ return FutureUtils.completedExceptionally(new FlinkException("Could not upload file " + fileTag + '.', e));
+ }
+ return CompletableFuture.completedFuture(transientBlobKey);
+ }
+
Review comment:
They still belong into a separate commit though.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/taskmanager/ThreadDumpInfo.java
##########
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.rest.messages.taskmanager;
+
+import org.apache.flink.runtime.rest.messages.ResponseBody;
+
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonCreator;
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonProperty;
+
+import java.io.Serializable;
+import java.util.Collection;
+import java.util.Objects;
+
+/**
+ * Class containing thread dump information.
+ */
+public class ThreadDumpInfo implements ResponseBody, Serializable {
+ private static final long serialVersionUID = 1L;
+
+ public static final String FIELD_NAME_THREAD_INFOS = "threadInfos";
+
+ @JsonProperty(FIELD_NAME_THREAD_INFOS)
+ private final Collection<ThreadInfo> threadInfos;
Review comment:
Why not a map thread_name -> thread_info? I think this would be more generally usable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #11887: [FLINK-14816] Add thread dump feature for taskmanager
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #11887:
URL: https://github.com/apache/flink/pull/11887#discussion_r415807514
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/FileType.java
##########
@@ -22,6 +22,13 @@
* Different file types to request from the {@link TaskExecutor}.
*/
public enum FileType {
+ /**
+ * the log file type for taskmanager
Review comment:
Somewhat. But I believe that the extra effort splitting this change into a separate commit won't pay off. Hence, I would like to keep it as is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on issue #11887: [DRAFT][FLINK-14816] Add thread dump feature for taskmanager
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11887:
URL: https://github.com/apache/flink/pull/11887#issuecomment-618505450
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161670239",
"triggerID" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"triggerType" : "PUSH"
}, {
"hash" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=142",
"triggerID" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 04664a73fedb414f0d3308eec861bf09ed4a5426 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/161670239) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=142)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #11887: [FLINK-14816] Add thread dump feature for taskmanager
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11887:
URL: https://github.com/apache/flink/pull/11887#discussion_r416069322
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/FileType.java
##########
@@ -22,6 +22,13 @@
* Different file types to request from the {@link TaskExecutor}.
*/
public enum FileType {
+ /**
+ * the log file type for taskmanager
Review comment:
Per the [code-style guide](https://flink.apache.org/contributing/code-style-and-quality-pull-requests.html#separate-refactoring-cleanup-and-independent-changes):
> Pull Requests must put cleanup, refactoring, and core changes into separate commits.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #11887: [FLINK-14816] Add thread dump feature for taskmanager
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11887:
URL: https://github.com/apache/flink/pull/11887#discussion_r416068241
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/taskmanager/ThreadDumpInfo.java
##########
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.rest.messages.taskmanager;
+
+import org.apache.flink.runtime.rest.messages.ResponseBody;
+
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonCreator;
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonProperty;
+
+import java.io.Serializable;
+import java.util.Collection;
+import java.util.Objects;
+
+/**
+ * Class containing thread dump information.
+ */
+public class ThreadDumpInfo implements ResponseBody, Serializable {
+ private static final long serialVersionUID = 1L;
+
+ public static final String FIELD_NAME_THREAD_INFOS = "threadInfos";
+
+ @JsonProperty(FIELD_NAME_THREAD_INFOS)
+ private final Collection<ThreadInfo> threadInfos;
Review comment:
I wasn't talking about changing the internal storage, but to expose it as a map instead (i.e., changing the JOSN representation)
Assuming a user is interested in a particular thread, then with a map one can do `threadDump['myThreadName']`, instead of having to iterate over the array.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11887: [FLINK-14816] Add thread dump feature for taskmanager
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11887:
URL: https://github.com/apache/flink/pull/11887#issuecomment-618505450
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161670239",
"triggerID" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"triggerType" : "PUSH"
}, {
"hash" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=142",
"triggerID" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"triggerType" : "PUSH"
}, {
"hash" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161790852",
"triggerID" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"triggerType" : "PUSH"
}, {
"hash" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=185",
"triggerID" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"triggerType" : "PUSH"
}, {
"hash" : "bc5fd415d52f54be1aec59ff86b0d1571fb88489",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=206",
"triggerID" : "bc5fd415d52f54be1aec59ff86b0d1571fb88489",
"triggerType" : "PUSH"
}, {
"hash" : "bc5fd415d52f54be1aec59ff86b0d1571fb88489",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161834854",
"triggerID" : "bc5fd415d52f54be1aec59ff86b0d1571fb88489",
"triggerType" : "PUSH"
}, {
"hash" : "5ecc88f14d8d7ebd8ad31749399e0c6d9e54ab00",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162237825",
"triggerID" : "5ecc88f14d8d7ebd8ad31749399e0c6d9e54ab00",
"triggerType" : "PUSH"
}, {
"hash" : "5ecc88f14d8d7ebd8ad31749399e0c6d9e54ab00",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=329",
"triggerID" : "5ecc88f14d8d7ebd8ad31749399e0c6d9e54ab00",
"triggerType" : "PUSH"
}, {
"hash" : "89f3c0d90b160aa2a6e813255e80630882d6c2d3",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162418438",
"triggerID" : "89f3c0d90b160aa2a6e813255e80630882d6c2d3",
"triggerType" : "PUSH"
}, {
"hash" : "89f3c0d90b160aa2a6e813255e80630882d6c2d3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=373",
"triggerID" : "89f3c0d90b160aa2a6e813255e80630882d6c2d3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5ecc88f14d8d7ebd8ad31749399e0c6d9e54ab00 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/162237825) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=329)
* 89f3c0d90b160aa2a6e813255e80630882d6c2d3 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/162418438) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=373)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11887: [FLINK-14816] Add thread dump feature for taskmanager
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11887:
URL: https://github.com/apache/flink/pull/11887#issuecomment-618505450
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161670239",
"triggerID" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"triggerType" : "PUSH"
}, {
"hash" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=142",
"triggerID" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"triggerType" : "PUSH"
}, {
"hash" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161790852",
"triggerID" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"triggerType" : "PUSH"
}, {
"hash" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=185",
"triggerID" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"triggerType" : "PUSH"
}, {
"hash" : "bc5fd415d52f54be1aec59ff86b0d1571fb88489",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=206",
"triggerID" : "bc5fd415d52f54be1aec59ff86b0d1571fb88489",
"triggerType" : "PUSH"
}, {
"hash" : "bc5fd415d52f54be1aec59ff86b0d1571fb88489",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161834854",
"triggerID" : "bc5fd415d52f54be1aec59ff86b0d1571fb88489",
"triggerType" : "PUSH"
}, {
"hash" : "5ecc88f14d8d7ebd8ad31749399e0c6d9e54ab00",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162237825",
"triggerID" : "5ecc88f14d8d7ebd8ad31749399e0c6d9e54ab00",
"triggerType" : "PUSH"
}, {
"hash" : "5ecc88f14d8d7ebd8ad31749399e0c6d9e54ab00",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=329",
"triggerID" : "5ecc88f14d8d7ebd8ad31749399e0c6d9e54ab00",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5ecc88f14d8d7ebd8ad31749399e0c6d9e54ab00 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/162237825) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=329)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on pull request #11887: [FLINK-14816] Add thread dump feature for taskmanager
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #11887:
URL: https://github.com/apache/flink/pull/11887#issuecomment-620559427
Thanks for the review @lamber-ken.
@zentol I've split the unrelated changes into separate commits. I won't change the JSON format though. I will merge this PR once CI gives green light.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #11887: [FLINK-14816] Add thread dump feature for taskmanager
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #11887:
URL: https://github.com/apache/flink/pull/11887#discussion_r415563809
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
##########
@@ -1012,10 +1016,34 @@ public void disconnectResourceManager(Exception cause) {
}
}
+ @Override
+ public CompletableFuture<ThreadDumpInfo> requestThreadDump(Time timeout) {
+ final Collection<ThreadInfo> threadDump = JvmUtils.createThreadDump();
+
+ final Collection<ThreadDumpInfo.ThreadInfo> threadInfos = threadDump.stream()
+ .map(threadInfo -> ThreadDumpInfo.ThreadInfo.create(threadInfo.getThreadName(), threadInfo.toString()))
+ .collect(Collectors.toList());
+
+ return CompletableFuture.completedFuture(ThreadDumpInfo.create(threadInfos));
+ }
+
// ======================================================================
// Internal methods
// ======================================================================
+ private CompletableFuture<TransientBlobKey> putTransientBlobStream(InputStream inputStream, String fileTag) {
+ final TransientBlobCache transientBlobService = blobCacheService.getTransientBlobService();
+ final TransientBlobKey transientBlobKey;
+
+ try {
+ transientBlobKey = transientBlobService.putTransient(inputStream);
+ } catch (IOException e) {
+ log.debug("Could not upload file {}.", fileTag, e);
+ return FutureUtils.completedExceptionally(new FlinkException("Could not upload file " + fileTag + '.', e));
+ }
+ return CompletableFuture.completedFuture(transientBlobKey);
+ }
+
Review comment:
I think this change is still good since it breaks up a longer method into smaller units.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #11887: [FLINK-14816] Add thread dump feature for taskmanager
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #11887:
URL: https://github.com/apache/flink/pull/11887#discussion_r415808063
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
##########
@@ -1012,10 +1016,34 @@ public void disconnectResourceManager(Exception cause) {
}
}
+ @Override
+ public CompletableFuture<ThreadDumpInfo> requestThreadDump(Time timeout) {
+ final Collection<ThreadInfo> threadDump = JvmUtils.createThreadDump();
+
+ final Collection<ThreadDumpInfo.ThreadInfo> threadInfos = threadDump.stream()
+ .map(threadInfo -> ThreadDumpInfo.ThreadInfo.create(threadInfo.getThreadName(), threadInfo.toString()))
Review comment:
As soon as the Rest response and the internal cluster message differ I will separate the classes. As long as they are identical I think it is fine to use the same class here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11887: [FLINK-14816] Add thread dump feature for taskmanager
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11887:
URL: https://github.com/apache/flink/pull/11887#issuecomment-618505450
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161670239",
"triggerID" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"triggerType" : "PUSH"
}, {
"hash" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=142",
"triggerID" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"triggerType" : "PUSH"
}, {
"hash" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161790852",
"triggerID" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"triggerType" : "PUSH"
}, {
"hash" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=185",
"triggerID" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"triggerType" : "PUSH"
}, {
"hash" : "bc5fd415d52f54be1aec59ff86b0d1571fb88489",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=206",
"triggerID" : "bc5fd415d52f54be1aec59ff86b0d1571fb88489",
"triggerType" : "PUSH"
}, {
"hash" : "bc5fd415d52f54be1aec59ff86b0d1571fb88489",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161834854",
"triggerID" : "bc5fd415d52f54be1aec59ff86b0d1571fb88489",
"triggerType" : "PUSH"
}, {
"hash" : "5ecc88f14d8d7ebd8ad31749399e0c6d9e54ab00",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5ecc88f14d8d7ebd8ad31749399e0c6d9e54ab00",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bc5fd415d52f54be1aec59ff86b0d1571fb88489 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/161834854) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=206)
* 5ecc88f14d8d7ebd8ad31749399e0c6d9e54ab00 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #11887: [FLINK-14816] Add thread dump feature for taskmanager
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #11887:
URL: https://github.com/apache/flink/pull/11887#discussion_r416483536
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/taskmanager/ThreadDumpInfo.java
##########
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.rest.messages.taskmanager;
+
+import org.apache.flink.runtime.rest.messages.ResponseBody;
+
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonCreator;
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonProperty;
+
+import java.io.Serializable;
+import java.util.Collection;
+import java.util.Objects;
+
+/**
+ * Class containing thread dump information.
+ */
+public class ThreadDumpInfo implements ResponseBody, Serializable {
+ private static final long serialVersionUID = 1L;
+
+ public static final String FIELD_NAME_THREAD_INFOS = "threadInfos";
+
+ @JsonProperty(FIELD_NAME_THREAD_INFOS)
+ private final Collection<ThreadInfo> threadInfos;
Review comment:
Good point. I will take another look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] lamber-ken edited a comment on pull request #11887: [DRAFT][FLINK-14816] Add thread dump feature for taskmanager
Posted by GitBox <gi...@apache.org>.
lamber-ken edited a comment on pull request #11887:
URL: https://github.com/apache/flink/pull/11887#issuecomment-618621288
hi @tillrohrmann, thanks for doing this, 💯 , but `RestAPIStabilityTest` run failed.
Worked fine.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on issue #11887: [DRAFT][FLINK-14816] Add thread dump feature for taskmanager
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11887:
URL: https://github.com/apache/flink/pull/11887#issuecomment-618505450
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161670239",
"triggerID" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"triggerType" : "PUSH"
}, {
"hash" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=142",
"triggerID" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 04664a73fedb414f0d3308eec861bf09ed4a5426 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/161670239) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=142)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11887: [FLINK-14816] Add thread dump feature for taskmanager
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11887:
URL: https://github.com/apache/flink/pull/11887#issuecomment-618505450
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161670239",
"triggerID" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"triggerType" : "PUSH"
}, {
"hash" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=142",
"triggerID" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"triggerType" : "PUSH"
}, {
"hash" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161790852",
"triggerID" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"triggerType" : "PUSH"
}, {
"hash" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=185",
"triggerID" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 04664a73fedb414f0d3308eec861bf09ed4a5426 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/161670239) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=142)
* c81293a45fa206a7715d02e2f23cdba617e0b198 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/161790852) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=185)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #11887: [FLINK-14816] Add thread dump feature for taskmanager
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #11887:
URL: https://github.com/apache/flink/pull/11887#discussion_r416482996
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/FileType.java
##########
@@ -22,6 +22,13 @@
* Different file types to request from the {@link TaskExecutor}.
*/
public enum FileType {
+ /**
+ * the log file type for taskmanager
Review comment:
You are right Chesnay. I will refactor the changes into separate commits in order to follow the code style guide.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] lamber-ken commented on a change in pull request #11887: [FLINK-14816] Add thread dump feature for taskmanager
Posted by GitBox <gi...@apache.org>.
lamber-ken commented on a change in pull request #11887:
URL: https://github.com/apache/flink/pull/11887#discussion_r415197059
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
##########
@@ -1012,10 +1016,34 @@ public void disconnectResourceManager(Exception cause) {
}
}
+ @Override
+ public CompletableFuture<ThreadDumpInfo> requestThreadDump(Time timeout) {
+ final Collection<ThreadInfo> threadDump = JvmUtils.createThreadDump();
+
+ final Collection<ThreadDumpInfo.ThreadInfo> threadInfos = threadDump.stream()
+ .map(threadInfo -> ThreadDumpInfo.ThreadInfo.create(threadInfo.getThreadName(), threadInfo.toString()))
+ .collect(Collectors.toList());
+
+ return CompletableFuture.completedFuture(ThreadDumpInfo.create(threadInfos));
+ }
+
// ======================================================================
// Internal methods
// ======================================================================
+ private CompletableFuture<TransientBlobKey> putTransientBlobStream(InputStream inputStream, String fileTag) {
+ final TransientBlobCache transientBlobService = blobCacheService.getTransientBlobService();
+ final TransientBlobKey transientBlobKey;
+
+ try {
+ transientBlobKey = transientBlobService.putTransient(inputStream);
+ } catch (IOException e) {
+ log.debug("Could not upload file {}.", fileTag, e);
+ return FutureUtils.completedExceptionally(new FlinkException("Could not upload file " + fileTag + '.', e));
+ }
+ return CompletableFuture.completedFuture(transientBlobKey);
+ }
+
Review comment:
hi @tillrohrmann, since doesn't make thread dump as stream in your design right now, we can revert it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11887: [FLINK-14816] Add thread dump feature for taskmanager
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11887:
URL: https://github.com/apache/flink/pull/11887#issuecomment-618505450
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161670239",
"triggerID" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"triggerType" : "PUSH"
}, {
"hash" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=142",
"triggerID" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"triggerType" : "PUSH"
}, {
"hash" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 04664a73fedb414f0d3308eec861bf09ed4a5426 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/161670239) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=142)
* c81293a45fa206a7715d02e2f23cdba617e0b198 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11887: [FLINK-14816] Add thread dump feature for taskmanager
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11887:
URL: https://github.com/apache/flink/pull/11887#issuecomment-618505450
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161670239",
"triggerID" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"triggerType" : "PUSH"
}, {
"hash" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=142",
"triggerID" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"triggerType" : "PUSH"
}, {
"hash" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161790852",
"triggerID" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"triggerType" : "PUSH"
}, {
"hash" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=185",
"triggerID" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"triggerType" : "PUSH"
}, {
"hash" : "bc5fd415d52f54be1aec59ff86b0d1571fb88489",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=206",
"triggerID" : "bc5fd415d52f54be1aec59ff86b0d1571fb88489",
"triggerType" : "PUSH"
}, {
"hash" : "bc5fd415d52f54be1aec59ff86b0d1571fb88489",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161834854",
"triggerID" : "bc5fd415d52f54be1aec59ff86b0d1571fb88489",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bc5fd415d52f54be1aec59ff86b0d1571fb88489 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/161834854) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=206)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on pull request #11887: [FLINK-14816] Add thread dump feature for taskmanager
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #11887:
URL: https://github.com/apache/flink/pull/11887#issuecomment-620003971
Thanks for the review @zentol. I answered all your comments. Please take another look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] lamber-ken commented on a change in pull request #11887: [FLINK-14816] Add thread dump feature for taskmanager
Posted by GitBox <gi...@apache.org>.
lamber-ken commented on a change in pull request #11887:
URL: https://github.com/apache/flink/pull/11887#discussion_r415196998
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
##########
@@ -1675,15 +1703,12 @@ private boolean isJobManagerConnectionValid(JobID jobId, JobMasterId jobMasterId
return CompletableFuture.supplyAsync(() -> {
final File file = new File(filePath);
if (file.exists()) {
- final TransientBlobCache transientBlobService = blobCacheService.getTransientBlobService();
- final TransientBlobKey transientBlobKey;
- try (FileInputStream fileInputStream = new FileInputStream(file)) {
- transientBlobKey = transientBlobService.putTransient(fileInputStream);
- } catch (IOException e) {
+ try {
+ return putTransientBlobStream(new FileInputStream(file), fileTag).get();
+ } catch (Exception e) {
Review comment:
hi @tillrohrmann, since doesn't make thread dump as stream in your design right now, we can revert it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11887: [FLINK-14816] Add thread dump feature for taskmanager
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11887:
URL: https://github.com/apache/flink/pull/11887#issuecomment-618505450
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161670239",
"triggerID" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"triggerType" : "PUSH"
}, {
"hash" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=142",
"triggerID" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"triggerType" : "PUSH"
}, {
"hash" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161790852",
"triggerID" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"triggerType" : "PUSH"
}, {
"hash" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=185",
"triggerID" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"triggerType" : "PUSH"
}, {
"hash" : "bc5fd415d52f54be1aec59ff86b0d1571fb88489",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=206",
"triggerID" : "bc5fd415d52f54be1aec59ff86b0d1571fb88489",
"triggerType" : "PUSH"
}, {
"hash" : "bc5fd415d52f54be1aec59ff86b0d1571fb88489",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161834854",
"triggerID" : "bc5fd415d52f54be1aec59ff86b0d1571fb88489",
"triggerType" : "PUSH"
}, {
"hash" : "5ecc88f14d8d7ebd8ad31749399e0c6d9e54ab00",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162237825",
"triggerID" : "5ecc88f14d8d7ebd8ad31749399e0c6d9e54ab00",
"triggerType" : "PUSH"
}, {
"hash" : "5ecc88f14d8d7ebd8ad31749399e0c6d9e54ab00",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=329",
"triggerID" : "5ecc88f14d8d7ebd8ad31749399e0c6d9e54ab00",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5ecc88f14d8d7ebd8ad31749399e0c6d9e54ab00 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/162237825) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=329)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on issue #11887: [DRAFT][FLINK-14816] Add thread dump feature for taskmanager
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11887:
URL: https://github.com/apache/flink/pull/11887#issuecomment-618499394
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 04664a73fedb414f0d3308eec861bf09ed4a5426 (Thu Apr 23 16:26:27 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] lamber-ken edited a comment on pull request #11887: [DRAFT][FLINK-14816] Add thread dump feature for taskmanager
Posted by GitBox <gi...@apache.org>.
lamber-ken edited a comment on pull request #11887:
URL: https://github.com/apache/flink/pull/11887#issuecomment-618621288
hi @tillrohrmann, thanks for doing this, 💯 , but `RestAPIStabilityTest` run failed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11887: [FLINK-14816] Add thread dump feature for taskmanager
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11887:
URL: https://github.com/apache/flink/pull/11887#issuecomment-618505450
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161670239",
"triggerID" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"triggerType" : "PUSH"
}, {
"hash" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=142",
"triggerID" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"triggerType" : "PUSH"
}, {
"hash" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161790852",
"triggerID" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"triggerType" : "PUSH"
}, {
"hash" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=185",
"triggerID" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"triggerType" : "PUSH"
}, {
"hash" : "bc5fd415d52f54be1aec59ff86b0d1571fb88489",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=206",
"triggerID" : "bc5fd415d52f54be1aec59ff86b0d1571fb88489",
"triggerType" : "PUSH"
}, {
"hash" : "bc5fd415d52f54be1aec59ff86b0d1571fb88489",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161834854",
"triggerID" : "bc5fd415d52f54be1aec59ff86b0d1571fb88489",
"triggerType" : "PUSH"
}, {
"hash" : "5ecc88f14d8d7ebd8ad31749399e0c6d9e54ab00",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162237825",
"triggerID" : "5ecc88f14d8d7ebd8ad31749399e0c6d9e54ab00",
"triggerType" : "PUSH"
}, {
"hash" : "5ecc88f14d8d7ebd8ad31749399e0c6d9e54ab00",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=329",
"triggerID" : "5ecc88f14d8d7ebd8ad31749399e0c6d9e54ab00",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bc5fd415d52f54be1aec59ff86b0d1571fb88489 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/161834854) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=206)
* 5ecc88f14d8d7ebd8ad31749399e0c6d9e54ab00 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/162237825) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=329)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #11887: [FLINK-14816] Add thread dump feature for taskmanager
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #11887:
URL: https://github.com/apache/flink/pull/11887#discussion_r415808063
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
##########
@@ -1012,10 +1016,34 @@ public void disconnectResourceManager(Exception cause) {
}
}
+ @Override
+ public CompletableFuture<ThreadDumpInfo> requestThreadDump(Time timeout) {
+ final Collection<ThreadInfo> threadDump = JvmUtils.createThreadDump();
+
+ final Collection<ThreadDumpInfo.ThreadInfo> threadInfos = threadDump.stream()
+ .map(threadInfo -> ThreadDumpInfo.ThreadInfo.create(threadInfo.getThreadName(), threadInfo.toString()))
Review comment:
As soon as the RestResponse and the internal cluster message differ I will introduce a separate the classes. As long as they are identical I think it is fine to use the same class here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11887: [FLINK-14816] Add thread dump feature for taskmanager
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11887:
URL: https://github.com/apache/flink/pull/11887#issuecomment-618505450
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161670239",
"triggerID" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"triggerType" : "PUSH"
}, {
"hash" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=142",
"triggerID" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"triggerType" : "PUSH"
}, {
"hash" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161790852",
"triggerID" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"triggerType" : "PUSH"
}, {
"hash" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=185",
"triggerID" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"triggerType" : "PUSH"
}, {
"hash" : "bc5fd415d52f54be1aec59ff86b0d1571fb88489",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=206",
"triggerID" : "bc5fd415d52f54be1aec59ff86b0d1571fb88489",
"triggerType" : "PUSH"
}, {
"hash" : "bc5fd415d52f54be1aec59ff86b0d1571fb88489",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161834854",
"triggerID" : "bc5fd415d52f54be1aec59ff86b0d1571fb88489",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bc5fd415d52f54be1aec59ff86b0d1571fb88489 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/161834854) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=206)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11887: [DRAFT][FLINK-14816] Add thread dump feature for taskmanager
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11887:
URL: https://github.com/apache/flink/pull/11887#issuecomment-618505450
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161670239",
"triggerID" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"triggerType" : "PUSH"
}, {
"hash" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=142",
"triggerID" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 04664a73fedb414f0d3308eec861bf09ed4a5426 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/161670239) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=142)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11887: [FLINK-14816] Add thread dump feature for taskmanager
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11887:
URL: https://github.com/apache/flink/pull/11887#issuecomment-618505450
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161670239",
"triggerID" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"triggerType" : "PUSH"
}, {
"hash" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=142",
"triggerID" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"triggerType" : "PUSH"
}, {
"hash" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"status" : "CANCELED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161790852",
"triggerID" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"triggerType" : "PUSH"
}, {
"hash" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=185",
"triggerID" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"triggerType" : "PUSH"
}, {
"hash" : "bc5fd415d52f54be1aec59ff86b0d1571fb88489",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=206",
"triggerID" : "bc5fd415d52f54be1aec59ff86b0d1571fb88489",
"triggerType" : "PUSH"
}, {
"hash" : "bc5fd415d52f54be1aec59ff86b0d1571fb88489",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161834854",
"triggerID" : "bc5fd415d52f54be1aec59ff86b0d1571fb88489",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c81293a45fa206a7715d02e2f23cdba617e0b198 Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/161790852) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=185)
* bc5fd415d52f54be1aec59ff86b0d1571fb88489 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/161834854) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=206)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #11887: [FLINK-14816] Add thread dump feature for taskmanager
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #11887:
URL: https://github.com/apache/flink/pull/11887#discussion_r415809201
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/taskmanager/ThreadDumpInfo.java
##########
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.rest.messages.taskmanager;
+
+import org.apache.flink.runtime.rest.messages.ResponseBody;
+
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonCreator;
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonProperty;
+
+import java.io.Serializable;
+import java.util.Collection;
+import java.util.Objects;
+
+/**
+ * Class containing thread dump information.
+ */
+public class ThreadDumpInfo implements ResponseBody, Serializable {
+ private static final long serialVersionUID = 1L;
+
+ public static final String FIELD_NAME_THREAD_INFOS = "threadInfos";
+
+ @JsonProperty(FIELD_NAME_THREAD_INFOS)
+ private final Collection<ThreadInfo> threadInfos;
Review comment:
The main reason was the duplicated thread name information as a key and as part of the `ThreadInfo` class. But I guess this is premature optimization. I will change it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11887: [FLINK-14816] Add thread dump feature for taskmanager
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11887:
URL: https://github.com/apache/flink/pull/11887#issuecomment-618505450
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161670239",
"triggerID" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"triggerType" : "PUSH"
}, {
"hash" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=142",
"triggerID" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"triggerType" : "PUSH"
}, {
"hash" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161790852",
"triggerID" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"triggerType" : "PUSH"
}, {
"hash" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=185",
"triggerID" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"triggerType" : "PUSH"
}, {
"hash" : "bc5fd415d52f54be1aec59ff86b0d1571fb88489",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=206",
"triggerID" : "bc5fd415d52f54be1aec59ff86b0d1571fb88489",
"triggerType" : "PUSH"
}, {
"hash" : "bc5fd415d52f54be1aec59ff86b0d1571fb88489",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161834854",
"triggerID" : "bc5fd415d52f54be1aec59ff86b0d1571fb88489",
"triggerType" : "PUSH"
}, {
"hash" : "5ecc88f14d8d7ebd8ad31749399e0c6d9e54ab00",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162237825",
"triggerID" : "5ecc88f14d8d7ebd8ad31749399e0c6d9e54ab00",
"triggerType" : "PUSH"
}, {
"hash" : "5ecc88f14d8d7ebd8ad31749399e0c6d9e54ab00",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=329",
"triggerID" : "5ecc88f14d8d7ebd8ad31749399e0c6d9e54ab00",
"triggerType" : "PUSH"
}, {
"hash" : "89f3c0d90b160aa2a6e813255e80630882d6c2d3",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162418438",
"triggerID" : "89f3c0d90b160aa2a6e813255e80630882d6c2d3",
"triggerType" : "PUSH"
}, {
"hash" : "89f3c0d90b160aa2a6e813255e80630882d6c2d3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=373",
"triggerID" : "89f3c0d90b160aa2a6e813255e80630882d6c2d3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 89f3c0d90b160aa2a6e813255e80630882d6c2d3 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/162418438) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=373)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #11887: [FLINK-14816] Add thread dump feature for taskmanager
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #11887:
URL: https://github.com/apache/flink/pull/11887#discussion_r416550511
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/taskmanager/ThreadDumpInfo.java
##########
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.rest.messages.taskmanager;
+
+import org.apache.flink.runtime.rest.messages.ResponseBody;
+
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonCreator;
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonProperty;
+
+import java.io.Serializable;
+import java.util.Collection;
+import java.util.Objects;
+
+/**
+ * Class containing thread dump information.
+ */
+public class ThreadDumpInfo implements ResponseBody, Serializable {
+ private static final long serialVersionUID = 1L;
+
+ public static final String FIELD_NAME_THREAD_INFOS = "threadInfos";
+
+ @JsonProperty(FIELD_NAME_THREAD_INFOS)
+ private final Collection<ThreadInfo> threadInfos;
Review comment:
After having looked at it again, I still believe that the response should be a collection of `ThreadInfos`. If the user needs to do a named lookup, then she can still create a map from the collection. It should not be the responsibility response class to present the elements in a certain order. Moreover, we don't have this requirement at the moment. Hence, I won't do the proposed change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on issue #11887: [DRAFT][FLINK-14816] Add thread dump feature for taskmanager
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11887:
URL: https://github.com/apache/flink/pull/11887#issuecomment-618505450
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 04664a73fedb414f0d3308eec861bf09ed4a5426 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #11887: [FLINK-14816] Add thread dump feature for taskmanager
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #11887:
URL: https://github.com/apache/flink/pull/11887#discussion_r415808063
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
##########
@@ -1012,10 +1016,34 @@ public void disconnectResourceManager(Exception cause) {
}
}
+ @Override
+ public CompletableFuture<ThreadDumpInfo> requestThreadDump(Time timeout) {
+ final Collection<ThreadInfo> threadDump = JvmUtils.createThreadDump();
+
+ final Collection<ThreadDumpInfo.ThreadInfo> threadInfos = threadDump.stream()
+ .map(threadInfo -> ThreadDumpInfo.ThreadInfo.create(threadInfo.getThreadName(), threadInfo.toString()))
Review comment:
As soon as the RestResponse and the internal cluster message differ I willseparate the classes. As long as they are identical I think it is fine to use the same class here.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
##########
@@ -1012,10 +1016,34 @@ public void disconnectResourceManager(Exception cause) {
}
}
+ @Override
+ public CompletableFuture<ThreadDumpInfo> requestThreadDump(Time timeout) {
+ final Collection<ThreadInfo> threadDump = JvmUtils.createThreadDump();
+
+ final Collection<ThreadDumpInfo.ThreadInfo> threadInfos = threadDump.stream()
+ .map(threadInfo -> ThreadDumpInfo.ThreadInfo.create(threadInfo.getThreadName(), threadInfo.toString()))
Review comment:
As soon as the RestResponse and the internal cluster message differ I will separate the classes. As long as they are identical I think it is fine to use the same class here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] lamber-ken commented on a change in pull request #11887: [FLINK-14816] Add thread dump feature for taskmanager
Posted by GitBox <gi...@apache.org>.
lamber-ken commented on a change in pull request #11887:
URL: https://github.com/apache/flink/pull/11887#discussion_r415775714
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
##########
@@ -1012,10 +1016,34 @@ public void disconnectResourceManager(Exception cause) {
}
}
+ @Override
+ public CompletableFuture<ThreadDumpInfo> requestThreadDump(Time timeout) {
+ final Collection<ThreadInfo> threadDump = JvmUtils.createThreadDump();
+
+ final Collection<ThreadDumpInfo.ThreadInfo> threadInfos = threadDump.stream()
+ .map(threadInfo -> ThreadDumpInfo.ThreadInfo.create(threadInfo.getThreadName(), threadInfo.toString()))
+ .collect(Collectors.toList());
+
+ return CompletableFuture.completedFuture(ThreadDumpInfo.create(threadInfos));
+ }
+
// ======================================================================
// Internal methods
// ======================================================================
+ private CompletableFuture<TransientBlobKey> putTransientBlobStream(InputStream inputStream, String fileTag) {
+ final TransientBlobCache transientBlobService = blobCacheService.getTransientBlobService();
+ final TransientBlobKey transientBlobKey;
+
+ try {
+ transientBlobKey = transientBlobService.putTransient(inputStream);
+ } catch (IOException e) {
+ log.debug("Could not upload file {}.", fileTag, e);
+ return FutureUtils.completedExceptionally(new FlinkException("Could not upload file " + fileTag + '.', e));
+ }
+ return CompletableFuture.completedFuture(transientBlobKey);
+ }
+
Review comment:
> I think this change is still good since it breaks up a longer method into smaller units.
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11887: [FLINK-14816] Add thread dump feature for taskmanager
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11887:
URL: https://github.com/apache/flink/pull/11887#issuecomment-618505450
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161670239",
"triggerID" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"triggerType" : "PUSH"
}, {
"hash" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=142",
"triggerID" : "04664a73fedb414f0d3308eec861bf09ed4a5426",
"triggerType" : "PUSH"
}, {
"hash" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161790852",
"triggerID" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"triggerType" : "PUSH"
}, {
"hash" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=185",
"triggerID" : "c81293a45fa206a7715d02e2f23cdba617e0b198",
"triggerType" : "PUSH"
}, {
"hash" : "bc5fd415d52f54be1aec59ff86b0d1571fb88489",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bc5fd415d52f54be1aec59ff86b0d1571fb88489",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 04664a73fedb414f0d3308eec861bf09ed4a5426 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/161670239) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=142)
* c81293a45fa206a7715d02e2f23cdba617e0b198 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/161790852) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=185)
* bc5fd415d52f54be1aec59ff86b0d1571fb88489 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] lamber-ken commented on a change in pull request #11887: [FLINK-14816] Add thread dump feature for taskmanager
Posted by GitBox <gi...@apache.org>.
lamber-ken commented on a change in pull request #11887:
URL: https://github.com/apache/flink/pull/11887#discussion_r415196998
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
##########
@@ -1675,15 +1703,12 @@ private boolean isJobManagerConnectionValid(JobID jobId, JobMasterId jobMasterId
return CompletableFuture.supplyAsync(() -> {
final File file = new File(filePath);
if (file.exists()) {
- final TransientBlobCache transientBlobService = blobCacheService.getTransientBlobService();
- final TransientBlobKey transientBlobKey;
- try (FileInputStream fileInputStream = new FileInputStream(file)) {
- transientBlobKey = transientBlobService.putTransient(fileInputStream);
- } catch (IOException e) {
+ try {
+ return putTransientBlobStream(new FileInputStream(file), fileTag).get();
+ } catch (Exception e) {
Review comment:
hi @tillrohrmann, since doesn't make thread dump as stream in your design right now, we can revert it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org